ShortUrlPropertyAnnotator::addAnnotation() - Code Metrics - Inspection of "2.0 refactoring" - SemanticMediaWiki/SemanticExtraSpecialProperties - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#75)

by mw

created 2017-06-03 14:12 UTC

ShortUrlPropertyAnnotator::addAnnotation() A

↳ Parent: ShortUrlPropertyAnnotator

Complexity

Conditions	4
Paths	5

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	5
nop	2
dl	0
loc	17
rs	9.2
c	0
b	0
f	0
ccs	0
cts	13
cp	0
crap	20

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDIUri as DIUri;
use SESP\PropertyAnnotator;
use SESP\AppFactory;
use RuntimeException;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 * @author rotsee
 */
class ShortUrlPropertyAnnotator implements PropertyAnnotator {

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === '___SHORTURL' ;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		if ( !$this->hasShortUrlUtils() ) {
			throw new RuntimeException( 'Class ShortUrlUtils is not available' );
		}

		$dataItem = null;
		$title = $semanticData->getSubject()->getTitle();

		if ( \ShortUrlUtils::needsShortUrl( $title ) ) {
			$dataItem = new DIUri( 'http', $this->getUrlPrefix() . \ShortUrlUtils::encodeTitle( $title ), '', '' );
		}

		if ( $dataItem instanceof DataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

	protected function getUrlPrefix() {

		$shortUrlPrefix = $this->appFactory->getOption( 'wgShortUrlPrefix', '' );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		if ( $shortUrlPrefix === '' ) {
			return SpecialPage::getTitleFor( 'ShortUrl' )->getFullUrl() . '/';
		}

		return $shortUrlPrefix;
	}

	protected function hasShortUrlUtils() {
		return class_exists( 'ShortUrlUtils' );
	}

}


1			<?php
2
3			namespace SESP\PropertyAnnotators;
4
5			use SMW\DIProperty;
6			use SMW\SemanticData;
7			use SMWDataItem as DataItem;
8			use SMWDIUri as DIUri;
9			use SESP\PropertyAnnotator;
10			use SESP\AppFactory;
11			use RuntimeException;
12
13			/**
14			* @private
15			* @ingroup SESP
16			*
17			* @license GNU GPL v2+
18			* @since 2.0
19			*
20			* @author mwjames
21			* @author rotsee
22			*/
23			class ShortUrlPropertyAnnotator implements PropertyAnnotator {
24
25			/**
26			* @var AppFactory
27			*/
28			private $appFactory;
29
30			/**
31			* @since 2.0
32			*
33			* @param AppFactory $appFactory
34			*/
35			public function __construct( AppFactory $appFactory ) {
36			$this->appFactory = $appFactory;
37			}
38
39			/**
40			* @since 2.0
41			*
42			* {@inheritDoc}
43			*/
44			public function isAnnotatorFor( DIProperty $property ) {
45			return $property->getKey() === '___SHORTURL' ;
46			}
47
48			/**
49			* @since 2.0
50			*
51			* {@inheritDoc}
52			*/
53			public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
54
55			if ( !$this->hasShortUrlUtils() ) {
56			throw new RuntimeException( 'Class ShortUrlUtils is not available' );
57			}
58
59			$dataItem = null;
60			$title = $semanticData->getSubject()->getTitle();
61
62			if ( \ShortUrlUtils::needsShortUrl( $title ) ) {
63			$dataItem = new DIUri( 'http', $this->getUrlPrefix() . \ShortUrlUtils::encodeTitle( $title ), '', '' );
64			}
65
66			if ( $dataItem instanceof DataItem ) {
67			$semanticData->addPropertyObjectValue( $property, $dataItem );
68			}
69			}
70
71			protected function getUrlPrefix() {
72
73			$shortUrlPrefix = $this->appFactory->getOption( 'wgShortUrlPrefix', '' );
			0 ignored issues – show Documentation introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report `''` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74
75			if ( $shortUrlPrefix === '' ) {
76			return SpecialPage::getTitleFor( 'ShortUrl' )->getFullUrl() . '/';
77			}
78
79			return $shortUrlPrefix;
80			}
81
82			protected function hasShortUrlUtils() {
83			return class_exists( 'ShortUrlUtils' );
84			}
85
86			}
87

SemanticMediaWiki / SemanticExtraSpecialProperties

Pull Request — master (#75)

ShortUrlPropertyAnnotator::addAnnotation() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like