UserEditCountPropertyAnnotator::addAnnotation() - Code Metrics - SemanticMediaWiki/SemanticExtraSpecialProperties - Measure and Improve Code Quality continuously with Scrutinizer

UserEditCountPropertyAnnotator::addAnnotation() A
last analyzed 2021-05-24 12:18 UTC

↳ Parent: UserEditCountPropertyAnnotator

Complexity

Conditions	6
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	6.0163

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	19
ccs	12
cts	13
cp	0.9231
rs	9.0111
cc	6
nc	5
nop	2
crap	6.0163

<?php

namespace SESP\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDINumber as DINumber;
use SESP\PropertyAnnotator;
use SESP\AppFactory;
use User;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 * @since 2.0
 *
 * @author mwjames
 */
class UserEditCountPropertyAnnotator implements PropertyAnnotator {

	/**
	 * Predefined property ID
	 */
	const PROP_ID = '___USEREDITCNT';

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @since 2.0
	 *
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === self::PROP_ID ;
	}

	/**
	 * @since 2.0
	 *
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		$title = $semanticData->getSubject()->getTitle();

		if ( !$title->inNamespace( NS_USER ) ) {
			return;
		}

		$user = $this->appFactory->newUserFromTitle( $title );
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
		$dataItem = null;

		if ( $user instanceof User && ( $count = $user->getEditCount() ) && is_int( $count ) ) {

			$dataItem = new DINumber( $count );
		}

		if ( $dataItem instanceof DataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

}


1		<?php
2
3		namespace SESP\PropertyAnnotators;
4
5		use SMW\DIProperty;
6		use SMW\SemanticData;
7		use SMWDataItem as DataItem;
8		use SMWDINumber as DINumber;
9		use SESP\PropertyAnnotator;
10		use SESP\AppFactory;
11		use User;
12
13		/**
14		* @private
15		* @ingroup SESP
16		*
17		* @license GNU GPL v2+
18		* @since 2.0
19		*
20		* @author mwjames
21		*/
22		class UserEditCountPropertyAnnotator implements PropertyAnnotator {
23
24		/**
25		* Predefined property ID
26		*/
27		const PROP_ID = '___USEREDITCNT';
28
29		/**
30		* @var AppFactory
31		*/
32		private $appFactory;
33
34		/**
35		* @since 2.0
36		*
37		* @param AppFactory $appFactory
38		*/
39	5	public function __construct( AppFactory $appFactory ) {
40	5	$this->appFactory = $appFactory;
41	5	}
42
43		/**
44		* @since 2.0
45		*
46		* {@inheritDoc}
47		*/
48	1	public function isAnnotatorFor( DIProperty $property ) {
49	1	return $property->getKey() === self::PROP_ID ;
50		}
51
52		/**
53		* @since 2.0
54		*
55		* {@inheritDoc}
56		*/
57	3	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {
58
59	3	$title = $semanticData->getSubject()->getTitle();
60
61	3	if ( !$title->inNamespace( NS_USER ) ) {
62		return;
63		}
64
65	3	$user = $this->appFactory->newUserFromTitle( $title );
		0 ignored issues – show Bug introduced 2017-06-03 14:08 UTC by Report Bug Copy Issue Report It seems like `$title` defined by `$semanticData->getSubject()->getTitle()` on line `59` can be `null`; however, `SESP\AppFactory::newUserFromTitle()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
66	3	$dataItem = null;
67
68	3	if ( $user instanceof User && ( $count = $user->getEditCount() ) && is_int( $count ) ) {
		0 ignored issues – show Bug introduced 2017-06-10 08:09 UTC by Report Bug Copy Issue Report The class `User` does not exist. Is this class maybe located in a folder that is not analyzed, or in a newer version of your dependencies than listed in your composer.lock/composer.json? Loading history...
69	1	$dataItem = new DINumber( $count );
70	1	}
71
72	3	if ( $dataItem instanceof DataItem ) {
73	1	$semanticData->addPropertyObjectValue( $property, $dataItem );
74	1	}
75	3	}
76
77		}
78

SemanticMediaWiki / SemanticExtraSpecialProperties

UserEditCountPropertyAnnotator::addAnnotation() A last analyzed 2021-05-24 12:18 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

UserEditCountPropertyAnnotator::addAnnotation() A
last analyzed 2021-05-24 12:18 UTC