SESP\PropertyAnnotators\ApprovedDatePropertyAnnotator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

84.85%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	setApprovedDate()	0	3	1
A	isAnnotatorFor()	0	3	1
B	addAnnotation()	0	26	6
A	getDataItem()	0	13	2

<?php

namespace SESP\PropertyAnnotators;

use ApprovedRevs;
use SMW\DIProperty;
use SMW\SemanticData;
use SMWDataItem as DataItem;
use SMWDITime as DITime;
use SESP\PropertyAnnotator;
use SESP\AppFactory;

/**
 * @private
 * @ingroup SESP
 *
 * @license GNU GPL v2+
 */
class ApprovedDatePropertyAnnotator implements PropertyAnnotator {

	/**
	 * Predefined property ID
	 */
	const PROP_ID = '___APPROVEDDATE';

	/**
	 * @var AppFactory
	 */
	private $appFactory;

	/**
	 * @var Integer|null
	 */
	private $approvedDate;

	/**
	 * @param AppFactory $appFactory
	 */
	public function __construct( AppFactory $appFactory ) {
		$this->appFactory = $appFactory;
	}

	/**
	 * @since 2.0
	 *
	 * @param Integer $approvedDate
	 */
	public function setApprovedDate( $approvedDate ) {
		$this->approvedDate = $approvedDate;
	}

	/**
	 * {@inheritDoc}
	 */
	public function isAnnotatorFor( DIProperty $property ) {
		return $property->getKey() === self::PROP_ID;
	}

	/**
	 * {@inheritDoc}
	 */
	public function addAnnotation( DIProperty $property, SemanticData $semanticData ) {

		if ( $this->approvedDate === null && class_exists( 'ApprovedRevs' ) ) {
			$title = $semanticData->getSubject()->getTitle();
			if ( ApprovedRevs::pageIsApprovable( $title ) ) {
				$this->approvedDate = ApprovedRevs::getApprovedTimestamp( $title );
			}

			if ( !$this->approvedDate ) {
				$logReader = $this->appFactory->newDatabaseLogReader(
					$semanticData->getSubject()->getTitle(),
					'approval'
				);

				$this->approvedDate = $logReader->getDateOfLogEntry();

It seems like $logReader->getDateOfLogEntry() can also be of type object<MWTimestamp>. However, the property $approvedDate is declared as type integer|null. Maybe add an additional type check?

			}
		}

		$dataItem = $this->getDataItem();

		if ( $dataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		} else {
			$semanticData->removeProperty( $property );
		}
	}

	private function getDataItem() {
		if ( $this->approvedDate ) {

The expression $this->approvedDate of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

			$date = $this->approvedDate;
			return new DITime(
				DITime::CM_GREGORIAN,
				$date->format( 'Y' ),

The method format cannot be called on $date (of type integer).

				$date->format( 'm' ),

The method format cannot be called on $date (of type integer).

				$date->format( 'd' ),

The method format cannot be called on $date (of type integer).

				$date->format( 'H' ),

The method format cannot be called on $date (of type integer).

				$date->format( 'i' )

The method format cannot be called on $date (of type integer).

			);
		}
	}

}