1 | <?php |
||
16 | class EmbeddedLinksReplacerTest extends \PHPUnit_Framework_TestCase { |
||
17 | |||
18 | private $querySource; |
||
19 | |||
20 | protected function setUp() { |
||
23 | |||
24 | public function testCanConstruct() { |
||
31 | |||
32 | /** |
||
33 | * @dataProvider textProvider |
||
34 | */ |
||
35 | public function testReplace( $text, $expected ) { |
||
44 | |||
45 | public function textProvider() { |
||
94 | |||
95 | } |
||
96 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArray
is initialized the first time when the foreach loop is entered. You can also see that the value of thebar
key is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.