DataValueDeserializer::newDataValueFromDataItem() - Code Metrics - Inspection of "Extend coverage" - SemanticMediaWiki/SemanticExternalQueryLookup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd8aad...6526e1 )

by mw

created 2015-11-24 02:25 UTC

DataValueDeserializer::newDataValueFromDataItem() A

↳ Parent: DataValueDeserializer

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0263

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	14
ccs	6
cts	7
cp	0.8571
rs	9.4286
cc	3
eloc	8
nc	3
nop	2
crap	3.0263

<?php

namespace SEQL;

use SMW\DataValueFactory;
use SMW\DIProperty;
use SMW\DIWikiPage;
use SMWContainerSemanticData as ContainerSemanticData;
use SMWDIContainer as DIContainer;
use SMWDITime as DITime;

/**
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class DataValueDeserializer {

	/**
	 * @var string
	 */
	private $querySource;

	/**
	 * @since 1.0
	 *
	 * @param string $querySource
	 */
	public function __construct( $querySource ) {
		$this->querySource = $querySource;
	}

	/**
	 * @since 1.0
	 *
	 * @return string
	 */
	public function getQuerySource() {
		return $this->querySource;
	}

	/**
	 * @since 1.0
	 *
	 * @param DIProperty $property
	 * @param array|string $value
	 *
	 * @return DataValue
	 */
	public function newDataValueFrom( DIProperty $property, $value ) {

		$dv = null;
		$propertyList = array();

		if ( $property->findPropertyTypeId() === '_wpg' || isset( $value['fulltext'] ) ) {
			$dv = $this->newDataValueFromDataItem( $property, $this->newDiWikiPage( $value ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		} elseif ( $property->findPropertyTypeId() === '_rec' ) {
			$dv = $this->newDataValueFromDataItem( $property, $this->newDiContainerOnRecordType( $value, $propertyList ) );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			$dv->setFieldProperties( $propertyList );
		} elseif ( $property->findPropertyTypeId() === '_dat' ) {
			$dv = $this->newDataValueFromDataItem( $property, $this->newDiTime( $value ) );

		} elseif ( $property->findPropertyTypeId() === '_qty' ) {
			$dv = $this->newDataValueFromPropertyObject( $property, $value['value'] . ' ' . $value['unit']  );
		}

		if ( $dv === null ) {
			$dv = $this->newDataValueFromPropertyObject( $property, $value );
		}

		return $dv;
	}

	/**
	 * @since 1.0
	 *
	 * @param array $value
	 *
	 * @return DIWikiPage
	 */
	public function newDiWikiPage( array $value ) {

		$ns = (int)$value['namespace'] === NS_CATEGORY ? NS_CATEGORY : NS_MAIN;

		if ( $ns === NS_CATEGORY ) {
			$value['fulltext'] = substr( $value['fulltext'], ($pos = strpos( $value['fulltext'], ':') ) !== false ? $pos + 1 : 0 );
		}

		$title = \Title::newFromText( $this->querySource . ':' . str_replace(" ", "_", $value['fulltext'] ), $ns );

		return DIWikiPage::newFromTitle( $title );
	}

	private function newDiTime( $value ) {

		if ( isset( $value['raw'] ) ) {
			return DITime::doUnserialize( $value['raw'] );
		}

		// < 0.7 API format
		// Avoid something like "Part of the date is out of bounds" where the API
		// doesn't sent a raw format
		// return 9999 BC to indicate that we hit a bounds with the timespamp
		try{
			$dataItem = DITime::newFromTimestamp( $value );
		} catch ( \Exception $e ) {
			$dataItem = DITime::doUnserialize( '2/-9999' );
		}

		return $dataItem;
	}

	private function newDataValueFromPropertyObject( $property, $value ) {

		try{
			$dv = DataValueFactory::newPropertyObjectValue( $property, $value );
		} catch ( \Exception $e ) {
			$dv = false;
		}

		return $dv;
	}

	private function newDataValueFromDataItem( $property, $dataItem = false ) {

		if ( $dataItem === false ) {
			return false;
		}

		try{
			$dv = DataValueFactory::newDataItemValue( $dataItem, $property );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		} catch ( \Exception $e ) {
			$dv = false;
		}

		return $dv;
	}

	private function newDiContainerOnRecordType( array $value, &$propertyList ) {

		// Remote container to use an anonymous
		$semanticData = ContainerSemanticData::makeAnonymousContainer();

		foreach ( $value as $recValue ) {
			$recordProperty = DIProperty::newFromUserLabel( $recValue['label'] );
			$recordProperty->setInterwiki( $this->querySource );
			$recordProperty->setPropertyTypeId( $recValue['typeid'] );
			$propertyList[] = $recordProperty;

			foreach ( $recValue['item'] as $item ) {
				$dataValue = $this->newDataValueFrom( $recordProperty, $item );

				if ( $dataValue === false ) {
					continue;
				}

				$semanticData->addPropertyObjectValue( $recordProperty, $dataValue->getDataItem() );
			}
		}

		return new DIContainer( $semanticData );
	}

}


1		<?php
2
3		namespace SEQL;
4
5		use SMW\DataValueFactory;
6		use SMW\DIProperty;
7		use SMW\DIWikiPage;
8		use SMWContainerSemanticData as ContainerSemanticData;
9		use SMWDIContainer as DIContainer;
10		use SMWDITime as DITime;
11
12		/**
13		* @license GNU GPL v2+
14		* @since 1.0
15		*
16		* @author mwjames
17		*/
18		class DataValueDeserializer {
19
20		/**
21		* @var string
22		*/
23		private $querySource;
24
25		/**
26		* @since 1.0
27		*
28		* @param string $querySource
29		*/
30	9	public function __construct( $querySource ) {
31	9	$this->querySource = $querySource;
32	9	}
33
34		/**
35		* @since 1.0
36		*
37		* @return string
38		*/
39	5	public function getQuerySource() {
40	5	return $this->querySource;
41		}
42
43		/**
44		* @since 1.0
45		*
46		* @param DIProperty $property
47		* @param array\|string $value
48		*
49		* @return DataValue
50		*/
51	7	public function newDataValueFrom( DIProperty $property, $value ) {
52
53	7	$dv = null;
54	7	$propertyList = array();
55
56	7	if ( $property->findPropertyTypeId() === '_wpg' \|\| isset( $value['fulltext'] ) ) {
57	1	$dv = $this->newDataValueFromDataItem( $property, $this->newDiWikiPage( $value ) );
		0 ignored issues – show Bug introduced 2015-11-23 01:24 UTC by Report Bug Copy Issue Report It seems like `$value` defined by parameter `$value` on line 51 can also be of type `string`; however, `SEQL\DataValueDeserializer::newDiWikiPage()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Documentation introduced 2015-11-24 02:29 UTC by Report Bug Copy Issue Report `$this->newDiWikiPage($value)` is of type `object<SMW\DIWikiPage>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58	7	} elseif ( $property->findPropertyTypeId() === '_rec' ) {
59	1	$dv = $this->newDataValueFromDataItem( $property, $this->newDiContainerOnRecordType( $value, $propertyList ) );
		0 ignored issues – show Bug introduced 2015-11-23 01:24 UTC by Report Bug Copy Issue Report It seems like `$value` defined by parameter `$value` on line 51 can also be of type `string`; however, `SEQL\DataValueDeserializ...ContainerOnRecordType()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history... Documentation introduced 2015-11-24 02:29 UTC by Report Bug Copy Issue Report `$this->newDiContainerOnR...($value, $propertyList)` is of type `object<SMWDIContainer>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60	1	$dv->setFieldProperties( $propertyList );
61	6	} elseif ( $property->findPropertyTypeId() === '_dat' ) {
62	4	$dv = $this->newDataValueFromDataItem( $property, $this->newDiTime( $value ) );
		0 ignored issues – show Bug introduced 2015-11-24 02:29 UTC by Report Bug Copy Issue Report It seems like `$this->newDiTime($value)` targeting `SEQL\DataValueDeserializer::newDiTime()` can also be of type `object<SMWDITime>`; however, `SEQL\DataValueDeserializ...DataValueFromDataItem()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
63	6	} elseif ( $property->findPropertyTypeId() === '_qty' ) {
64	1	$dv = $this->newDataValueFromPropertyObject( $property, $value['value'] . ' ' . $value['unit'] );
65	1	}
66
67	7	if ( $dv === null ) {
68	1	$dv = $this->newDataValueFromPropertyObject( $property, $value );
69	1	}
70
71	7	return $dv;
72		}
73
74		/**
75		* @since 1.0
76		*
77		* @param array $value
78		*
79		* @return DIWikiPage
80		*/
81	6	public function newDiWikiPage( array $value ) {
82
83	6	$ns = (int)$value['namespace'] === NS_CATEGORY ? NS_CATEGORY : NS_MAIN;
84
85	6	if ( $ns === NS_CATEGORY ) {
86	1	$value['fulltext'] = substr( $value['fulltext'], ($pos = strpos( $value['fulltext'], ':') ) !== false ? $pos + 1 : 0 );
87	1	}
88
89	6	$title = \Title::newFromText( $this->querySource . ':' . str_replace(" ", "_", $value['fulltext'] ), $ns );
90
91	6	return DIWikiPage::newFromTitle( $title );
92		}
93
94	4	private function newDiTime( $value ) {
95
96	4	if ( isset( $value['raw'] ) ) {
97	3	return DITime::doUnserialize( $value['raw'] );
98		}
99
100		// < 0.7 API format
101		// Avoid something like "Part of the date is out of bounds" where the API
102		// doesn't sent a raw format
103		// return 9999 BC to indicate that we hit a bounds with the timespamp
104		try{
105	1	$dataItem = DITime::newFromTimestamp( $value );
106	1	} catch ( \Exception $e ) {
107		$dataItem = DITime::doUnserialize( '2/-9999' );
108		}
109
110	1	return $dataItem;
111		}
112
113	2	private function newDataValueFromPropertyObject( $property, $value ) {
114
115		try{
116	2	$dv = DataValueFactory::newPropertyObjectValue( $property, $value );
117	2	} catch ( \Exception $e ) {
118		$dv = false;
119		}
120
121	2	return $dv;
122		}
123
124	6	private function newDataValueFromDataItem( $property, $dataItem = false ) {
125
126	6	if ( $dataItem === false ) {
127	1	return false;
128		}
129
130		try{
131	5	$dv = DataValueFactory::newDataItemValue( $dataItem, $property );
		0 ignored issues – show Documentation introduced 2015-11-24 02:29 UTC by Report Bug Copy Issue Report `$dataItem` is of type `boolean`, but the function expects a `object<SMWDataItem>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
132	5	} catch ( \Exception $e ) {
133		$dv = false;
134		}
135
136	5	return $dv;
137		}
138
139	1	private function newDiContainerOnRecordType( array $value, &$propertyList ) {
140
141		// Remote container to use an anonymous
142	1	$semanticData = ContainerSemanticData::makeAnonymousContainer();
143
144	1	foreach ( $value as $recValue ) {
145	1	$recordProperty = DIProperty::newFromUserLabel( $recValue['label'] );
146	1	$recordProperty->setInterwiki( $this->querySource );
147	1	$recordProperty->setPropertyTypeId( $recValue['typeid'] );
148	1	$propertyList[] = $recordProperty;
149
150	1	foreach ( $recValue['item'] as $item ) {
151	1	$dataValue = $this->newDataValueFrom( $recordProperty, $item );
152
153	1	if ( $dataValue === false ) {
154		continue;
155		}
156
157	1	$semanticData->addPropertyObjectValue( $recordProperty, $dataValue->getDataItem() );
158	1	}
159	1	}
160
161	1	return new DIContainer( $semanticData );
162		}
163
164		}
165

SemanticMediaWiki / SemanticExternalQueryLookup

Push — master ( dd8aad...6526e1 )

DataValueDeserializer::newDataValueFromDataItem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like