QueryEncoderTest::queryElementProvider() - Code Metrics - Inspection of "Localisation updates from https://translatewiki.ne..." - SemanticMediaWiki/SemanticExternalQueryLookup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c3e068...3f9a02 )

unknown

created 2018-06-25 06:19 UTC

QueryEncoderTest::queryElementProvider() B

↳ Parent: QueryEncoderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	60
rs	8.8727
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace SEQL\Tests;

use SEQL\QueryEncoder;

/**
 * @covers \SEQL\QueryEncoder
 * @group semantic-external-query-lookup
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class QueryEncoderTest extends \PHPUnit_Framework_TestCase {

	/**
	 * @dataProvider queryElementProvider
	 */
	public function testEncode( $sortKeys, $extraPrintouts, $expectedEncode, $expectedRawEncode ) {

		$query = $this->getMockBuilder( '\SMWQuery' )
			->disableOriginalConstructor()
			->getMock();

		$query->expects( $this->any() )
			->method( 'getQueryString' )
			->will( $this->returnValue( '[[Foo::bar]]' ) );

		$query->expects( $this->any() )
			->method( 'getLimit' )
			->will( $this->returnValue( 42 ) );

		$query->expects( $this->any() )
			->method( 'getOffset' )
			->will( $this->returnValue( 0 ) );

		$query->expects( $this->any() )
			->method( 'getMainlabel' )
			->will( $this->returnValue( '' ) );

		$query->expects( $this->any() )
			->method( 'getSortKeys' )
			->will( $this->returnValue( $sortKeys ) );

		$query->expects( $this->any() )
			->method( 'getExtraPrintouts' )
			->will( $this->returnValue( $extraPrintouts ) );

		$this->assertSame(
			$expectedEncode,
			QueryEncoder::encode( $query )
		);

		$this->assertSame(
			$expectedRawEncode,
			QueryEncoder::rawUrlEncode( $query )
		);
	}

	public function queryElementProvider() {

		#0
		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			array(),
			array(),
			'[[Foo::bar]]|limit=42|offset=0|mainlabel=',
			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
		);

		#1
		$provider[] = array(
			array( 'Foobar' => 'DESC' ),
			array(),
			'[[Foo::bar]]|limit=42|offset=0|mainlabel=|sort=Foobar|order=desc',
			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D%7Csort%3DFoobar%7Corder%3Ddesc'
		);

		#2
		$provider[] = array(
			array( 'Foobar' => 'DESC', 'Foobaz' => 'ASC' ),
			array(),
			'[[Foo::bar]]|limit=42|offset=0|mainlabel=|sort=Foobar,Foobaz|order=desc,asc',
			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D%7Csort%3DFoobar%2CFoobaz%7Corder%3Ddesc%2Casc'
		);

		#3
		$printRequest = $this->getMockBuilder( '\SMW\Query\PrintRequest' )
			->disableOriginalConstructor()
			->getMock();

		$printRequest->expects( $this->any() )
			->method( 'getSerialisation' )
			->will( $this->returnValue( '?ABC' ) );

		$provider[] = array(
			array(),
			array( $printRequest ),
			'[[Foo::bar]]|?ABC|limit=42|offset=0|mainlabel=',
			'%5B%5BFoo%3A%3Abar%5D%5D%7C%3FABC%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
		);

		#4 (#show returns with an extra =)
		$printRequest = $this->getMockBuilder( '\SMW\Query\PrintRequest' )
			->disableOriginalConstructor()
			->getMock();

		$printRequest->expects( $this->any() )
			->method( 'getSerialisation' )
			->will( $this->returnValue( '?ABC=' ) );

		$provider[] = array(
			array(),
			array( $printRequest ),
			'[[Foo::bar]]|?ABC|limit=42|offset=0|mainlabel=',
			'%5B%5BFoo%3A%3Abar%5D%5D%7C%3FABC%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
		);

		return $provider;
	}

}


1			<?php
2
3			namespace SEQL\Tests;
4
5			use SEQL\QueryEncoder;
6
7			/**
8			* @covers \SEQL\QueryEncoder
9			* @group semantic-external-query-lookup
10			*
11			* @license GNU GPL v2+
12			* @since 1.0
13			*
14			* @author mwjames
15			*/
16			class QueryEncoderTest extends \PHPUnit_Framework_TestCase {
17
18			/**
19			* @dataProvider queryElementProvider
20			*/
21			public function testEncode( $sortKeys, $extraPrintouts, $expectedEncode, $expectedRawEncode ) {
22
23			$query = $this->getMockBuilder( '\SMWQuery' )
24			->disableOriginalConstructor()
25			->getMock();
26
27			$query->expects( $this->any() )
28			->method( 'getQueryString' )
29			->will( $this->returnValue( '[[Foo::bar]]' ) );
30
31			$query->expects( $this->any() )
32			->method( 'getLimit' )
33			->will( $this->returnValue( 42 ) );
34
35			$query->expects( $this->any() )
36			->method( 'getOffset' )
37			->will( $this->returnValue( 0 ) );
38
39			$query->expects( $this->any() )
40			->method( 'getMainlabel' )
41			->will( $this->returnValue( '' ) );
42
43			$query->expects( $this->any() )
44			->method( 'getSortKeys' )
45			->will( $this->returnValue( $sortKeys ) );
46
47			$query->expects( $this->any() )
48			->method( 'getExtraPrintouts' )
49			->will( $this->returnValue( $extraPrintouts ) );
50
51			$this->assertSame(
52			$expectedEncode,
53			QueryEncoder::encode( $query )
54			);
55
56			$this->assertSame(
57			$expectedRawEncode,
58			QueryEncoder::rawUrlEncode( $query )
59			);
60			}
61
62			public function queryElementProvider() {
63
64			#0
65			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-23 01:24 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
66			array(),
67			array(),
68			'[[Foo::bar]]\|limit=42\|offset=0\|mainlabel=',
69			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
70			);
71
72			#1
73			$provider[] = array(
74			array( 'Foobar' => 'DESC' ),
75			array(),
76			'[[Foo::bar]]\|limit=42\|offset=0\|mainlabel=\|sort=Foobar\|order=desc',
77			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D%7Csort%3DFoobar%7Corder%3Ddesc'
78			);
79
80			#2
81			$provider[] = array(
82			array( 'Foobar' => 'DESC', 'Foobaz' => 'ASC' ),
83			array(),
84			'[[Foo::bar]]\|limit=42\|offset=0\|mainlabel=\|sort=Foobar,Foobaz\|order=desc,asc',
85			'%5B%5BFoo%3A%3Abar%5D%5D%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D%7Csort%3DFoobar%2CFoobaz%7Corder%3Ddesc%2Casc'
86			);
87
88			#3
89			$printRequest = $this->getMockBuilder( '\SMW\Query\PrintRequest' )
90			->disableOriginalConstructor()
91			->getMock();
92
93			$printRequest->expects( $this->any() )
94			->method( 'getSerialisation' )
95			->will( $this->returnValue( '?ABC' ) );
96
97			$provider[] = array(
98			array(),
99			array( $printRequest ),
100			'[[Foo::bar]]\|?ABC\|limit=42\|offset=0\|mainlabel=',
101			'%5B%5BFoo%3A%3Abar%5D%5D%7C%3FABC%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
102			);
103
104			#4 (#show returns with an extra =)
105			$printRequest = $this->getMockBuilder( '\SMW\Query\PrintRequest' )
106			->disableOriginalConstructor()
107			->getMock();
108
109			$printRequest->expects( $this->any() )
110			->method( 'getSerialisation' )
111			->will( $this->returnValue( '?ABC=' ) );
112
113			$provider[] = array(
114			array(),
115			array( $printRequest ),
116			'[[Foo::bar]]\|?ABC\|limit=42\|offset=0\|mainlabel=',
117			'%5B%5BFoo%3A%3Abar%5D%5D%7C%3FABC%7Climit%3D42%7Coffset%3D0%7Cmainlabel%3D'
118			);
119
120			return $provider;
121			}
122
123			}
124

SemanticMediaWiki / SemanticExternalQueryLookup

Push — master ( c3e068...3f9a02 )

QueryEncoderTest::queryElementProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like