JsonResponseParserTest::resultProvider() - Code Metrics - SemanticMediaWiki/SemanticExternalQueryLookup - Measure and Improve Code Quality continuously with Scrutinizer

JsonResponseParserTest::resultProvider() B
last analyzed 2021-05-07 09:17 UTC

↳ Parent: JsonResponseParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	62
rs	8.829
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace SEQL\ByHttpRequest\Tests;

use SEQL\ByHttpRequest\JsonResponseParser;
use SMW\DIProperty;

/**
 * @covers \SEQL\ByHttpRequest\JsonResponseParser
 * @group semantic-external-query-lookup
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class JsonResponseParserTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
			->disableOriginalConstructor()
			->getMock();

		$this->assertInstanceOf(
			'\SEQL\ByHttpRequest\JsonResponseParser',
			new JsonResponseParser( $dataValueDeserializer )
		);
	}

	/**
	 * @dataProvider resultProvider
	 */
	public function testDoParse( $result, $rawResponseResult, $hasFurtherResults, $property ) {

		$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
			->disableOriginalConstructor()
			->getMock();

		$instance = new JsonResponseParser( $dataValueDeserializer );

		$instance->doParse( $result );

		$this->assertEquals(
			$rawResponseResult,
			$instance->getRawResponseResult()
		);

		$this->assertEquals(
			$hasFurtherResults,
			$instance->hasFurtherResults()
		);

		if ( $property !== null ) {
			$this->assertEquals(
				$property,
				$instance->findPropertyFromInMemoryExternalRepositoryCache( $property )
			);
		}
	}

	public function testDoParseForRedirect() {

		$result = array(
			'query' => array(
				'printrequests' => array(
					array( 'label' => 'Foo', 'mode' => 2, 'redi' => 'Bar' , 'typeid' => '_wpg' )
				),
			'results' => array()
			)
		);

		$rawResponseResult = array(
			'printrequests' => array(
				array( 'label' => 'Foo', 'mode' => 2, 'redi' => 'Bar' , 'typeid' => '_wpg' )
			),
			'results' => array()
		);

		$property = new DIProperty( 'Foo' );
		$property->setPropertyTypeId( '_wpg' );

		$property->setInterwiki( 'abc' );

		$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
			->disableOriginalConstructor()
			->getMock();

		$dataValueDeserializer->expects( $this->once() )
			->method( 'getQuerySource' )
			->will( $this->returnValue( 'abc' ) );

		$instance = new JsonResponseParser( $dataValueDeserializer );

		$instance->doParse( $result );

		$this->assertEquals(
			$rawResponseResult,
			$instance->getRawResponseResult()
		);

		$this->assertEquals(
			$property,
			$instance->findPropertyFromInMemoryExternalRepositoryCache( new DIProperty( 'Bar' ) )
		);

		$this->assertEquals(
			$property,
			$instance->findPropertyFromInMemoryExternalRepositoryCache( new DIProperty( 'Foo' ) )
		);
	}

	public function resultProvider() {

		#0
		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			array( 'query' => array() ),
			array(),
			false,
			null
		);

		#1
		$provider[] = array(
			array(
				'query-continue-offset' => 3,
				'query' => array()
			),
			array(),
			true,
			null
		);

		#2
		$provider[] = array(
			array(
				'query-continue-offset' => 3,
				'query' => array(
					'printrequests' => array(
						array( 'label' => 'Category', 'mode' => 0 )
					)
				)
			),
			array(
				'printrequests' => array(
					array( 'label' => 'Category', 'mode' => 0 )
				)
			),
			true,
			new DIProperty( '_INST' )
		);

		#3
		$provider[] = array(
			array(
				'query' => array(
					'printrequests' => array(
						array( 'label' => 'Category', 'mode' => 0 )
					),
				'results' => array()
				),
			),
			array(
				'printrequests' => array(
					array( 'label' => 'Category', 'mode' => 0 )
				),
				'results' => array()
			),
			false,
			new DIProperty( '_INST' )
		);

		return $provider;
	}

}


1			<?php
2
3			namespace SEQL\ByHttpRequest\Tests;
4
5			use SEQL\ByHttpRequest\JsonResponseParser;
6			use SMW\DIProperty;
7
8			/**
9			* @covers \SEQL\ByHttpRequest\JsonResponseParser
10			* @group semantic-external-query-lookup
11			*
12			* @license GNU GPL v2+
13			* @since 1.0
14			*
15			* @author mwjames
16			*/
17			class JsonResponseParserTest extends \PHPUnit_Framework_TestCase {
18
19			public function testCanConstruct() {
20
21			$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
22			->disableOriginalConstructor()
23			->getMock();
24
25			$this->assertInstanceOf(
26			'\SEQL\ByHttpRequest\JsonResponseParser',
27			new JsonResponseParser( $dataValueDeserializer )
28			);
29			}
30
31			/**
32			* @dataProvider resultProvider
33			*/
34			public function testDoParse( $result, $rawResponseResult, $hasFurtherResults, $property ) {
35
36			$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
37			->disableOriginalConstructor()
38			->getMock();
39
40			$instance = new JsonResponseParser( $dataValueDeserializer );
41
42			$instance->doParse( $result );
43
44			$this->assertEquals(
45			$rawResponseResult,
46			$instance->getRawResponseResult()
47			);
48
49			$this->assertEquals(
50			$hasFurtherResults,
51			$instance->hasFurtherResults()
52			);
53
54			if ( $property !== null ) {
55			$this->assertEquals(
56			$property,
57			$instance->findPropertyFromInMemoryExternalRepositoryCache( $property )
58			);
59			}
60			}
61
62			public function testDoParseForRedirect() {
63
64			$result = array(
65			'query' => array(
66			'printrequests' => array(
67			array( 'label' => 'Foo', 'mode' => 2, 'redi' => 'Bar' , 'typeid' => '_wpg' )
68			),
69			'results' => array()
70			)
71			);
72
73			$rawResponseResult = array(
74			'printrequests' => array(
75			array( 'label' => 'Foo', 'mode' => 2, 'redi' => 'Bar' , 'typeid' => '_wpg' )
76			),
77			'results' => array()
78			);
79
80			$property = new DIProperty( 'Foo' );
81			$property->setPropertyTypeId( '_wpg' );
			0 ignored issues – show Deprecated Code introduced 2018-01-09 23:31 UTC by Report Bug Copy Issue Report The method `SMW\DIProperty::setPropertyTypeId()` has been deprecated with message: since 3.0, use DIProperty::setPropertyValueType This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
82			$property->setInterwiki( 'abc' );
83
84			$dataValueDeserializer = $this->getMockBuilder( '\SEQL\DataValueDeserializer' )
85			->disableOriginalConstructor()
86			->getMock();
87
88			$dataValueDeserializer->expects( $this->once() )
89			->method( 'getQuerySource' )
90			->will( $this->returnValue( 'abc' ) );
91
92			$instance = new JsonResponseParser( $dataValueDeserializer );
93
94			$instance->doParse( $result );
95
96			$this->assertEquals(
97			$rawResponseResult,
98			$instance->getRawResponseResult()
99			);
100
101			$this->assertEquals(
102			$property,
103			$instance->findPropertyFromInMemoryExternalRepositoryCache( new DIProperty( 'Bar' ) )
104			);
105
106			$this->assertEquals(
107			$property,
108			$instance->findPropertyFromInMemoryExternalRepositoryCache( new DIProperty( 'Foo' ) )
109			);
110			}
111
112			public function resultProvider() {
113
114			#0
115			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-23 01:24 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
116			array( 'query' => array() ),
117			array(),
118			false,
119			null
120			);
121
122			#1
123			$provider[] = array(
124			array(
125			'query-continue-offset' => 3,
126			'query' => array()
127			),
128			array(),
129			true,
130			null
131			);
132
133			#2
134			$provider[] = array(
135			array(
136			'query-continue-offset' => 3,
137			'query' => array(
138			'printrequests' => array(
139			array( 'label' => 'Category', 'mode' => 0 )
140			)
141			)
142			),
143			array(
144			'printrequests' => array(
145			array( 'label' => 'Category', 'mode' => 0 )
146			)
147			),
148			true,
149			new DIProperty( '_INST' )
150			);
151
152			#3
153			$provider[] = array(
154			array(
155			'query' => array(
156			'printrequests' => array(
157			array( 'label' => 'Category', 'mode' => 0 )
158			),
159			'results' => array()
160			),
161			),
162			array(
163			'printrequests' => array(
164			array( 'label' => 'Category', 'mode' => 0 )
165			),
166			'results' => array()
167			),
168			false,
169			new DIProperty( '_INST' )
170			);
171
172			return $provider;
173			}
174
175			}
176

SemanticMediaWiki / SemanticExternalQueryLookup

JsonResponseParserTest::resultProvider() B last analyzed 2021-05-07 09:17 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

JsonResponseParserTest::resultProvider() B
last analyzed 2021-05-07 09:17 UTC