CompoundQueryTest::sampleQueryProvider() - Code Metrics - Inspection of "Create .scrutinizer.yml" - SemanticMediaWiki/SemanticCompoundQueries - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#46)

by Jeroen De

created 2019-08-11 15:38 UTC

CompoundQueryTest::sampleQueryProvider() A

↳ Parent: CompoundQueryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	53
rs	9.0254
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace SCQ\Tests\Api;

use SMW\Tests\Utils\MwApiFactory;
use SCQ\Api\CompoundQuery;

/**
 * @covers \SCQ\Api\CompoundQuery
 * @group semantic-compound-queries
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author Peter Grassberger < [email protected] >
 */
class CompoundQueryTest extends \PHPUnit_Framework_TestCase {

	/**
	 * @var MwApiFactory
	 */
	private $apiFactory;

	protected function setUp() {
		parent::setUp();
		$this->apiFactory = new MwApiFactory();
	}

	public function testCanConstruct() {

		$instance = new CompoundQuery(
			$this->apiFactory->newApiMain( [ 'query' => 'Foo' ] ),
			'compoundquery'
		);

		$this->assertInstanceOf(
			CompoundQuery::class,
			$instance
		);
	}

	/**
	 * @dataProvider sampleQueryProvider
	 */
	public function testExecute( array $query, array $expected ) {

		$results = $this->apiFactory->doApiRequest( [
			'action' => 'compoundquery',
			'query' => implode( '|', $query )
		] );

		$this->assertInternalType(
			'array',
			$results
		);

		// If their is no printrequests array we expect an error array
		if ( isset( $results['query']['printrequests'] ) ) {
			$this->assertEquals( $expected, $results['query']['printrequests'] );
		} else {
			$this->assertArrayHasKey( 'error', $results );
		}
	}

	public function sampleQueryProvider() {

		$provider['Standard query'] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			[
				'[[Modification date::+]];?Modification date;limit=10',
			],
			[
				[
					'label'=> '',
					'typeid' => '_wpg',
					'mode' => 2,
					'format' => false,
					'key' => '',
					'redi' => ''
				],
				[
					'label'=> 'Modification date',
					'typeid' => '_dat',
					'mode' => 1,
					'format' => '',
					'key' => '_MDAT',
					'redi' => ''
				]
			]
		];

		$provider['Compound query'] = [
			[
				'[[Modification date::+]];?Modification date;limit=10',
				'[[Modification date::+]];?Modification date'
			],
			[
				[
					'label'=> '',
					'typeid' => '_wpg',
					'mode' => 2,
					'format' => false,
					'key' => '',
					'redi' => ''
				],
				[
					'label'=> 'Modification date',
					'typeid' => '_dat',
					'mode' => 1,
					'format' => '',
					'key' => '_MDAT',
					'redi' => ''
				]
			]
		];

		return $provider;
	}

}


1			<?php
2
3			namespace SCQ\Tests\Api;
4
5			use SMW\Tests\Utils\MwApiFactory;
6			use SCQ\Api\CompoundQuery;
7
8			/**
9			* @covers \SCQ\Api\CompoundQuery
10			* @group semantic-compound-queries
11			*
12			* @license GNU GPL v2+
13			* @since 1.0
14			*
15			* @author Peter Grassberger < [email protected] >
16			*/
17			class CompoundQueryTest extends \PHPUnit_Framework_TestCase {
18
19			/**
20			* @var MwApiFactory
21			*/
22			private $apiFactory;
23
24			protected function setUp() {
25			parent::setUp();
26			$this->apiFactory = new MwApiFactory();
27			}
28
29			public function testCanConstruct() {
30
31			$instance = new CompoundQuery(
32			$this->apiFactory->newApiMain( [ 'query' => 'Foo' ] ),
33			'compoundquery'
34			);
35
36			$this->assertInstanceOf(
37			CompoundQuery::class,
38			$instance
39			);
40			}
41
42			/**
43			* @dataProvider sampleQueryProvider
44			*/
45			public function testExecute( array $query, array $expected ) {
46
47			$results = $this->apiFactory->doApiRequest( [
48			'action' => 'compoundquery',
49			'query' => implode( '\|', $query )
50			] );
51
52			$this->assertInternalType(
53			'array',
54			$results
55			);
56
57			// If their is no printrequests array we expect an error array
58			if ( isset( $results['query']['printrequests'] ) ) {
59			$this->assertEquals( $expected, $results['query']['printrequests'] );
60			} else {
61			$this->assertArrayHasKey( 'error', $results );
62			}
63			}
64
65			public function sampleQueryProvider() {
66
67			$provider['Standard query'] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2019-08-11 15:46 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
68			[
69			'[[Modification date::+]];?Modification date;limit=10',
70			],
71			[
72			[
73			'label'=> '',
74			'typeid' => '_wpg',
75			'mode' => 2,
76			'format' => false,
77			'key' => '',
78			'redi' => ''
79			],
80			[
81			'label'=> 'Modification date',
82			'typeid' => '_dat',
83			'mode' => 1,
84			'format' => '',
85			'key' => '_MDAT',
86			'redi' => ''
87			]
88			]
89			];
90
91			$provider['Compound query'] = [
92			[
93			'[[Modification date::+]];?Modification date;limit=10',
94			'[[Modification date::+]];?Modification date'
95			],
96			[
97			[
98			'label'=> '',
99			'typeid' => '_wpg',
100			'mode' => 2,
101			'format' => false,
102			'key' => '',
103			'redi' => ''
104			],
105			[
106			'label'=> 'Modification date',
107			'typeid' => '_dat',
108			'mode' => 1,
109			'format' => '',
110			'key' => '_MDAT',
111			'redi' => ''
112			]
113			]
114			];
115
116			return $provider;
117			}
118
119			}
120

SemanticMediaWiki / SemanticCompoundQueries

Pull Request — master (#46)

CompoundQueryTest::sampleQueryProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like