SemanticMediaWiki / SemanticCompoundQueries

src/CompoundQueryProcessor.php

Braces +2 added lines, -5 removed lines

@@ -144,9 +144,7 @@ 
 
 				if ( $c == '[' ) {
 					$uncompleted_square_brackets++;
-				}
-
-				elseif ( $c == ']' ) {
+				} elseif ( $c == ']' ) {
 					$uncompleted_square_brackets--;
 				}
 			}
@@ -240,8 +238,7 @@ 
 			foreach ( $params as $param ) {
 				$parameters[$param->getName()] = $param->getValue();
 			}
-		}
-		else {
+		} else {
 			$parameters = $params;
 		}
 

Spacing +63 added lines, -63 removed lines

@@ -22,13 +22,13 @@ 
 	/**
 	 * Comparison helper function, used in sorting results.
 	 */
-	public static function compareQueryResults( $a, $b ) {
+	public static function compareQueryResults($a, $b) {
 
-		if ( $a->getSerialization() == $b->getSerialization() ) {
+		if ($a->getSerialization() == $b->getSerialization()) {
 			return 0;
 		}
 
-		return ( $a->getSerialization() < $b->getSerialization() ) ? -1 : 1;
+		return ($a->getSerialization() < $b->getSerialization()) ? -1 : 1;
 	}
 
 	/**
@@ -38,20 +38,20 @@ 
 	 *
 	 * @return string
 	 */
-	public static function doCompoundQuery( Parser &$parser ) {
+	public static function doCompoundQuery(Parser&$parser) {
 		global $smwgQEnabled, $smwgIQRunningNumber;
 
-		if ( !$smwgQEnabled ) {
-			return smwfEncodeMessages( [ wfMessage( 'smw_iq_disabled' )->inContentLanguage()->text() ] );
+		if (!$smwgQEnabled) {
+			return smwfEncodeMessages([wfMessage('smw_iq_disabled')->inContentLanguage()->text()]);
 		}
 
 		$smwgIQRunningNumber++;
 
 		$params = func_get_args();
-		array_shift( $params ); // We already know the $parser.
+		array_shift($params); // We already know the $parser.
 
-		list( $queryParams, $otherParams ) = self::separateParams( $params );
-		list( $queryResult, $otherParams ) = self::queryAndMergeResults( $queryParams, $otherParams );
+		list($queryParams, $otherParams) = self::separateParams($params);
+		list($queryResult, $otherParams) = self::queryAndMergeResults($queryParams, $otherParams);
 
 		return self::getResultFromQueryResult(
 			$queryResult,
@@ -66,25 +66,25 @@ 
 	 * @param $params
 	 * @return array
 	 */
-	public static function separateParams( $params ) {
+	public static function separateParams($params) {
 		$queryParams = [];
 		$otherParams = [];
 
-		foreach ( $params as $param ) {
+		foreach ($params as $param) {
 			// Very primitive heuristic - if the parameter
 			// includes a square bracket, then it's a
 			// sub-query; otherwise it's a regular parameter.
-			if ( strpos( $param, '[' ) !== false ) {
+			if (strpos($param, '[') !== false) {
 				$queryParams[] = $param;
 			} else {
-				$parts = explode( '=', $param, 2 );
+				$parts = explode('=', $param, 2);
 
-				if ( count( $parts ) >= 2 ) {
-					$otherParams[strtolower( trim( $parts[0] ) )] = $parts[1]; // don't trim here, some params care for " "
+				if (count($parts) >= 2) {
+					$otherParams[strtolower(trim($parts[0]))] = $parts[1]; // don't trim here, some params care for " "
 				}
 			}
 		}
-		return [ $queryParams, $otherParams ];
+		return [$queryParams, $otherParams];
 	}
 
 	/**
@@ -94,36 +94,36 @@ 
 	 * @param $otherParams
 	 * @return array
 	 */
-	public static function queryAndMergeResults( $queryParams, $otherParams ) {
+	public static function queryAndMergeResults($queryParams, $otherParams) {
 		$results = [];
 		$printRequests = [];
 
-		foreach ( $queryParams as $param ) {
-			$subQueryParams = self::getSubParams( $param );
+		foreach ($queryParams as $param) {
+			$subQueryParams = self::getSubParams($param);
 
-			if ( array_key_exists( 'format', $otherParams ) && !array_key_exists( 'format', $subQueryParams ) ) {
+			if (array_key_exists('format', $otherParams) && !array_key_exists('format', $subQueryParams)) {
 				$subQueryParams['format'] = $otherParams['format'];
 			}
 
 			$nextResult = self::getQueryResultFromFunctionParams($subQueryParams);
 
-			$results = self::mergeSMWQueryResults( $results, $nextResult->getResults() );
-			$printRequests = self::mergeSMWPrintRequests( $printRequests, $nextResult->getPrintRequests() );
+			$results = self::mergeSMWQueryResults($results, $nextResult->getResults());
+			$printRequests = self::mergeSMWPrintRequests($printRequests, $nextResult->getPrintRequests());
 		}
 
 		// Sort results so that they'll show up by page name
-		if( !isset($otherParams['unsorted']) || !strcmp( $otherParams['unsorted'], 'on' ) ) {
-			uasort( $results, [ '\SCQ\CompoundQueryProcessor', 'compareQueryResults' ] );
+		if (!isset($otherParams['unsorted']) || !strcmp($otherParams['unsorted'], 'on')) {
+			uasort($results, ['\SCQ\CompoundQueryProcessor', 'compareQueryResults']);
 		}
 
-		$queryResult = new CompoundQueryResult( $printRequests, new Query(), $results, smwfGetStore() );
+		$queryResult = new CompoundQueryResult($printRequests, new Query(), $results, smwfGetStore());
 
-		if ( version_compare( SMW_VERSION, '1.6.1', '>' ) ) {
-			self::addThisPrintout( $printRequests, $otherParams );
-			$otherParams = self::getProcessedParams( $otherParams, $printRequests );
+		if (version_compare(SMW_VERSION, '1.6.1', '>')) {
+			self::addThisPrintout($printRequests, $otherParams);
+			$otherParams = self::getProcessedParams($otherParams, $printRequests);
 		}
 
-		return [ $queryResult, $otherParams ];
+		return [$queryResult, $otherParams];
 	}
 
 	/**
@@ -135,31 +135,31 @@ 
 	 *
 	 * @return array
 	 */
-	protected static function getSubParams( $param ) {
+	protected static function getSubParams($param) {
 		$sub_params = [];
 		$sub_param = '';
 		$uncompleted_square_brackets = 0;
 
-		for ( $i = 0; $i < strlen( $param ); $i++ ) {
+		for ($i = 0; $i < strlen($param); $i++) {
 			$c = $param[$i];
 
-			if ( ( $c == ';' ) && ( $uncompleted_square_brackets <= 0 ) ) {
-				$sub_params[] = trim( $sub_param );
+			if (($c == ';') && ($uncompleted_square_brackets <= 0)) {
+				$sub_params[] = trim($sub_param);
 				$sub_param = '';
 			} else {
 				$sub_param .= $c;
 
-				if ( $c == '[' ) {
+				if ($c == '[') {
 					$uncompleted_square_brackets++;
 				}
 
-				elseif ( $c == ']' ) {
+				elseif ($c == ']') {
 					$uncompleted_square_brackets--;
 				}
 			}
 		}
 
-		$sub_params[] = trim( $sub_param );
+		$sub_params[] = trim($sub_param);
 
 		return $sub_params;
 	}
@@ -171,10 +171,10 @@ 
 	 *
 	 * @return QueryResult
 	 */
-	protected static function getQueryResultFromFunctionParams( $rawParams, $context = QueryProcessor::INLINE_QUERY, $showMode = false ) {
-		list( $querystring, $params, $printouts ) = self::getComponentsFromFunctionParams( $rawParams, $showMode );
+	protected static function getQueryResultFromFunctionParams($rawParams, $context = QueryProcessor::INLINE_QUERY, $showMode = false) {
+		list($querystring, $params, $printouts) = self::getComponentsFromFunctionParams($rawParams, $showMode);
 
-		return self::getQueryResultFromQueryString( $querystring, $params, $printouts, $context );
+		return self::getQueryResultFromQueryString($querystring, $params, $printouts, $context);
 	}
 
 	/**
@@ -185,19 +185,19 @@ 
 	 *
 	 * @return array
 	 */
-	protected static function mergeSMWQueryResults( $result1, $result2 ) {
-		if ( $result1 == null ) {
+	protected static function mergeSMWQueryResults($result1, $result2) {
+		if ($result1 == null) {
 			return $result2;
 		}
 
 		$existing_page_names = [];
-		foreach ( $result1 as $r1 ) {
+		foreach ($result1 as $r1) {
 			$existing_page_names[] = $r1->getSerialization();
 		}
 
-		foreach ( $result2 as $r2 ) {
+		foreach ($result2 as $r2) {
 			$page_name = $r2->getSerialization();
-			if ( ! in_array( $page_name, $existing_page_names ) ) {
+			if (!in_array($page_name, $existing_page_names)) {
 				$result1[] = $r2;
 			}
 		}
@@ -205,15 +205,15 @@ 
 		return $result1;
 	}
 
-	protected static function mergeSMWPrintRequests( $printRequests1, $printRequests2 ) {
+	protected static function mergeSMWPrintRequests($printRequests1, $printRequests2) {
 		$existingPrintoutLabels = [];
-		foreach ( $printRequests1 as $p1 ) {
+		foreach ($printRequests1 as $p1) {
 			$existingPrintoutLabels[] = $p1->getLabel();
 		}
 
-		foreach ( $printRequests2 as $p2 ) {
+		foreach ($printRequests2 as $p2) {
 			$label = $p2->getLabel();
-			if ( ! in_array( $label, $existingPrintoutLabels ) ) {
+			if (!in_array($label, $existingPrintoutLabels)) {
 				$printRequests1[] = $p2;
 			}
 		}
@@ -229,20 +229,20 @@ 
 	 *
 	 * @return QueryResult
 	 */
-	protected static function getQueryResultFromQueryString( $querystring, array $params, $extraPrintouts, $context = QueryProcessor::INLINE_QUERY ) {
+	protected static function getQueryResultFromQueryString($querystring, array $params, $extraPrintouts, $context = QueryProcessor::INLINE_QUERY) {
 
-		if ( version_compare( SMW_VERSION, '1.6.1', '>' ) ) {
-			QueryProcessor::addThisPrintout( $extraPrintouts, $params );
-			$params = self::getProcessedParams( $params, $extraPrintouts, false );
+		if (version_compare(SMW_VERSION, '1.6.1', '>')) {
+			QueryProcessor::addThisPrintout($extraPrintouts, $params);
+			$params = self::getProcessedParams($params, $extraPrintouts, false);
 		}
 
-		$query = self::createQuery( $querystring, $params, $context, null, $extraPrintouts );
-		$queryResult = smwfGetStore()->getQueryResult( $query );
+		$query = self::createQuery($querystring, $params, $context, null, $extraPrintouts);
+		$queryResult = smwfGetStore()->getQueryResult($query);
 
 		$parameters = [];
 
-		if ( version_compare( SMW_VERSION, '1.7.2', '>' ) ) {
-			foreach ( $params as $param ) {
+		if (version_compare(SMW_VERSION, '1.7.2', '>')) {
+			foreach ($params as $param) {
 				$parameters[$param->getName()] = $param->getValue();
 			}
 		}
@@ -250,7 +250,7 @@ 
 			$parameters = $params;
 		}
 
-		foreach ( $queryResult->getResults() as $wikiPage ) {
+		foreach ($queryResult->getResults() as $wikiPage) {
 			$wikiPage->display_options = $parameters;
 		}
 
@@ -269,20 +269,20 @@ 
 	 *
 	 * @return string
 	 */
-	protected static function getResultFromQueryResult( CompoundQueryResult $res, array $params, $outputmode, $context = QueryProcessor::INLINE_QUERY, $format = '' ) {
+	protected static function getResultFromQueryResult(CompoundQueryResult $res, array $params, $outputmode, $context = QueryProcessor::INLINE_QUERY, $format = '') {
 
-		if ( version_compare( SMW_VERSION, '1.6.1', '>' ) ) {
+		if (version_compare(SMW_VERSION, '1.6.1', '>')) {
 			$format = $params['format'];
 
-			if ( version_compare( SMW_VERSION, '1.7.2', '>' ) ) {
+			if (version_compare(SMW_VERSION, '1.7.2', '>')) {
 				$format = $format->getValue();
 			}
 		} else {
-			$format = self::getResultFormat( $params );
+			$format = self::getResultFormat($params);
 		}
 
-		$printer = self::getResultPrinter( $format, $context );
-		$result = $printer->getResult( $res, $params, $outputmode );
+		$printer = self::getResultPrinter($format, $context);
+		$result = $printer->getResult($res, $params, $outputmode);
 
 		return $result;
 	}

src/CompoundQueryResult.php

Spacing +9 added lines, -9 removed lines

@@ -23,29 +23,29 @@
 	 *
 	 * @param QueryResult $newResult
 	 */
-	public function addResult( QueryResult $newResult ) {
+	public function addResult(QueryResult $newResult) {
 		$existingPageNames = [];
 
-		while ( $row = $this->getNext() ) {
-			if ( $row[0] instanceof ResultArray ) {
+		while ($row = $this->getNext()) {
+			if ($row[0] instanceof ResultArray) {
 				$content = $row[0]->getContent();
-				$existingPageNames[] = $content[0]->getLongText( SMW_OUTPUT_WIKI );
+				$existingPageNames[] = $content[0]->getLongText(SMW_OUTPUT_WIKI);
 			}
 		}
 
-		while ( ( $row = $newResult->getNext() ) !== false ) {
-			if ( property_exists( $newResult, 'display_options' ) ) {
+		while (($row = $newResult->getNext()) !== false) {
+			if (property_exists($newResult, 'display_options')) {
 				$row[0]->display_options = $newResult->display_options;
 			}
 			$content = $row[0]->getContent();
-			$pageName = $content[0]->getLongText( SMW_OUTPUT_WIKI );
+			$pageName = $content[0]->getLongText(SMW_OUTPUT_WIKI);
 
-			if ( !in_array( $pageName, $existingPageNames ) ) {
+			if (!in_array($pageName, $existingPageNames)) {
 				$this->m_content[] = $row;
 			}
 		}
 
-		reset( $this->m_content );
+		reset($this->m_content);
 	}
 
 }

src/Api/CompoundQuery.php

Spacing +7 added lines, -7 removed lines

@@ -21,18 +21,18 @@ 
 	 * @see ApiBase::execute
 	 */
 	public function execute() {
-		$parameterFormatter = new ApiRequestParameterFormatter( $this->extractRequestParams() );
+		$parameterFormatter = new ApiRequestParameterFormatter($this->extractRequestParams());
 		$parameters = $parameterFormatter->getAskApiParameters();
 
-		list( $queryParams, $otherParams ) = CompoundQueryProcessor::separateParams( $parameters );
-		list( $queryResult ) = CompoundQueryProcessor::queryAndMergeResults( $queryParams, $otherParams );
+		list($queryParams, $otherParams) = CompoundQueryProcessor::separateParams($parameters);
+		list($queryResult) = CompoundQueryProcessor::queryAndMergeResults($queryParams, $otherParams);
 
 		$outputFormat = 'json';
-		if ( $this->getMain()->getPrinter() instanceof \ApiFormatXml ) {
+		if ($this->getMain()->getPrinter() instanceof \ApiFormatXml) {
 			$outputFormat = 'xml';
 		}
 
-		$this->addQueryResult( $queryResult, $outputFormat );
+		$this->addQueryResult($queryResult, $outputFormat);
 	}
 
 	/**
@@ -82,8 +82,8 @@ 
 	 */
 	protected function getExamples() {
 		return [
-			'api.php?action=compoundquery&query=' . urlencode( '[[Has city::Vienna]]; ?Has coordinates|[[Has city::Graz]]; ?Has coordinates' ),
-			'api.php?action=compoundquery&query=' . urlencode( '|[[Has city::Vienna]]; ?Has coordinates|[[Has city::Graz]]; ?Has coordinates' ),
+			'api.php?action=compoundquery&query=' . urlencode('[[Has city::Vienna]]; ?Has coordinates|[[Has city::Graz]]; ?Has coordinates'),
+			'api.php?action=compoundquery&query=' . urlencode('|[[Has city::Vienna]]; ?Has coordinates|[[Has city::Graz]]; ?Has coordinates'),
 		];
 	}
 

i18n/SemanticCompoundQueries.i18n.magic.php

Spacing +15 added lines, -15 removed lines

@@ -7,75 +7,75 @@
 
 /** English (English) */
 $magicWords['en'] = [
-	'compound_query' => [ 0, 'compound_query' ],
+	'compound_query' => [0, 'compound_query'],
 ];
 
 /** Arabic (العربية) */
 $magicWords['ar'] = [
-	'compound_query' => [ 0, 'استعلام_مركب' ],
+	'compound_query' => [0, 'استعلام_مركب'],
 ];
 
 /** Egyptian Arabic (مصرى) */
 $magicWords['arz'] = [
-	'compound_query' => [ 0, 'استعلام_مركب' ],
+	'compound_query' => [0, 'استعلام_مركب'],
 ];
 
 /** Chuvash (Чӑвашла) */
 $magicWords['cv'] = [
-	'compound_query' => [ 0, 'compound_query' ],
+	'compound_query' => [0, 'compound_query'],
 ];
 
 /** German (Deutsch) */
 $magicWords['de'] = [
-	'compound_query' => [ 0, 'abfrage_zusammen', 'frage_zusammen' ],
+	'compound_query' => [0, 'abfrage_zusammen', 'frage_zusammen'],
 ];
 
 /** Japanese (日本語) */
 $magicWords['ja'] = [
-	'compound_query' => [ 0, '複合クエリ', '複合クエリー' ],
+	'compound_query' => [0, '複合クエリ', '複合クエリー'],
 ];
 
 /** Korean (한국어) */
 $magicWords['ko'] = [
-	'compound_query' => [ 0, '복합_쿼리' ],
+	'compound_query' => [0, '복합_쿼리'],
 ];
 
 /** Macedonian (македонски) */
 $magicWords['mk'] = [
-	'compound_query' => [ 0, 'мешовито_барање' ],
+	'compound_query' => [0, 'мешовито_барање'],
 ];
 
 /** Low Saxon (Netherlands) (Nedersaksies) */
 $magicWords['nds-nl'] = [
-	'compound_query' => [ 0, 'samenestelden_zeukopdrachte', 'samengestelde_zoekopdracht' ],
+	'compound_query' => [0, 'samenestelden_zeukopdrachte', 'samengestelde_zoekopdracht'],
 ];
 
 /** Dutch (Nederlands) */
 $magicWords['nl'] = [
-	'compound_query' => [ 0, 'samengestelde_zoekopdracht' ],
+	'compound_query' => [0, 'samengestelde_zoekopdracht'],
 ];
 
 /** Brazilian Portuguese (português do Brasil) */
 $magicWords['pt-br'] = [
-	'compound_query' => [ 0, 'consulta_composta' ],
+	'compound_query' => [0, 'consulta_composta'],
 ];
 
 /** Serbian (Cyrillic script) (српски (ћирилица)‎) */
 $magicWords['sr-ec'] = [
-	'compound_query' => [ 0, 'састави_упит' ],
+	'compound_query' => [0, 'састави_упит'],
 ];
 
 /** Serbian (Latin script) (srpski (latinica)‎) */
 $magicWords['sr-el'] = [
-	'compound_query' => [ 0, 'sastavi_upit' ],
+	'compound_query' => [0, 'sastavi_upit'],
 ];
 
 /** Simplified Chinese (中文（简体）‎) */
 $magicWords['zh-hans'] = [
-	'compound_query' => [ 0, '组合查询' ],
+	'compound_query' => [0, '组合查询'],
 ];
 
 /** Traditional Chinese (中文（繁體）‎) */
 $magicWords['zh-hant'] = [
-	'compound_query' => [ 0, '組合搜尋' ],
+	'compound_query' => [0, '組合搜尋'],
 ];

SemanticCompoundQueries.php

Spacing +8 added lines, -8 removed lines

@@ -24,7 +24,7 @@ 
 	 */
 	public static function load() {
 
-		if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
+		if (is_readable(__DIR__ . '/vendor/autoload.php')) {
 			include_once __DIR__ . '/vendor/autoload.php';
 		}
 	}
@@ -32,10 +32,10 @@ 
 	/**
 	 * @since 1.1
 	 */
-	public static function initExtension( $credits = [] ) {
+	public static function initExtension($credits = []) {
 
 		// See https://phabricator.wikimedia.org/T151136
-		define( 'SCQ_VERSION', isset( $credits['version'] ) ? $credits['version'] : 'UNKNOWN' );
+		define('SCQ_VERSION', isset($credits['version']) ? $credits['version'] : 'UNKNOWN');
 
 		// Register message files
 		$GLOBALS['wgMessagesDirs']['SemanticCompoundQueries'] = __DIR__ . '/i18n';
@@ -48,10 +48,10 @@ 
 	 */
 	public static function onExtensionFunction() {
 
-		if ( !defined( 'SMW_VERSION' ) ) {
+		if (!defined('SMW_VERSION')) {
 
-			if ( PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg' ) {
-				die( "\nThe 'Semantic Compound Queries' extension requires 'Semantic MediaWiki' to be installed and enabled.\n" );
+			if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
+				die("\nThe 'Semantic Compound Queries' extension requires 'Semantic MediaWiki' to be installed and enabled.\n");
 			} else {
 				die(
 					'<b>Error:</b> The <a href="https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Compound_Queries">Semantic Compound Queries</a> ' .
@@ -66,8 +66,8 @@ 
 
 		// wgHooks
 		$hookContainer = MediaWikiServices::getInstance()->getHookContainer();
-		$hookContainer->register( 'ParserFirstCallInit', function( Parser &$parser  ) {
-			$parser->setFunctionHook( 'compound_query', [ '\SCQ\CompoundQueryProcessor', 'doCompoundQuery' ] );
+		$hookContainer->register('ParserFirstCallInit', function(Parser&$parser) {
+			$parser->setFunctionHook('compound_query', ['\SCQ\CompoundQueryProcessor', 'doCompoundQuery']);
 
 			// always return true, in order not to stop MW's hook processing!
 			return true;