BibtexProcessorTest::doNotProcessParameterProvider() - Code Metrics - Inspection of "Localisation updates from https://translatewiki.ne..." - SemanticMediaWiki/SemanticCite - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0591cb...33c12c )

unknown

created 2018-06-25 06:19 UTC

doNotProcessParameterProvider() A

↳ Parent: BibtexProcessorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace SCI\Tests\Bibtex;

use SCI\Bibtex\BibtexProcessor;

/**
 * @covers \SCI\Bibtex\BibtexProcessor
 * @group semantic-cite
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class BibtexProcessorTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
			->disableOriginalConstructor()
			->getMock();

		$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
			->disableOriginalConstructor()
			->getMock();

		$this->assertInstanceOf(
			'\SCI\Bibtex\BibtexProcessor',
			new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser )
		);
	}

	public function testDoProcess() {

		$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
			->disableOriginalConstructor()
			->getMock();

		$bibtexParser->expects( $this->once() )
			->method( 'parse' )
			->will( $this->returnValue( [ 'Foo' => 'Bar' ] ) );

		$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
			->disableOriginalConstructor()
			->getMock();

		$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
			->disableOriginalConstructor()
			->getMock();

		$parserParameterProcessor->expects( $this->once() )
			->method( 'getParameterValuesFor' )
			->with(	$this->equalTo( 'bibtex' ) )
			->will( $this->returnValue( [] ) );

		$parserParameterProcessor->expects( $this->once() )
			->method( 'addParameter' )
			->with(
				$this->equalTo( 'Foo' ),
				$this->equalTo( 'Bar' ) );

		$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );

		$instance->doProcess(
			$parserParameterProcessor
		);
	}

	public function testProcessAuthors() {

		$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
			->disableOriginalConstructor()
			->getMock();

		$bibtexParser->expects( $this->once() )
			->method( 'parse' )
			->will( $this->returnValue( [ 'author' => 'Foo' ] ) );

		$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
			->disableOriginalConstructor()
			->getMock();

		$bibtexAuthorListParser->expects( $this->once() )
			->method( 'parse' )
			->will( $this->returnValue( [ 'Foo' ] ) );

		$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
			->disableOriginalConstructor()
			->getMock();

		$parserParameterProcessor->expects( $this->once() )
			->method( 'getParameterValuesFor' )
			->with(	$this->equalTo( 'bibtex' ) )
			->will( $this->returnValue( [ ] ) );

		$parserParameterProcessor->expects( $this->once() )
			->method( 'setParameter' )
			->with(
				$this->equalTo( 'author' ),
				$this->equalTo( [ 'Foo' ] ) );

		$parserParameterProcessor->expects( $this->once() )
			->method( 'addParameter' )
			->with(
				$this->equalTo( 'bibtex-author' ),
				$this->equalTo( 'Foo' ) );

		$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );

		$instance->doProcess(
			$parserParameterProcessor
		);
	}

	/**
	 * @dataProvider doNotProcessParameterProvider
	 */
	public function testDoNotProcess( $parameter ) {

		$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
			->disableOriginalConstructor()
			->getMock();

		$bibtexParser->expects( $this->once() )
			->method( 'parse' )
			->will( $this->returnValue( [ $parameter => 'Foo' ] ) );

		$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
			->disableOriginalConstructor()
			->getMock();

		$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
			->disableOriginalConstructor()
			->getMock();

		$parserParameterProcessor->expects( $this->any() )
			->method( 'getFirstParameter' )
			->will( $this->returnValue( '' ) );

		$parserParameterProcessor->expects( $this->once() )
			->method( 'hasParameter' )
			->with(	$this->equalTo( $parameter ) )
			->will( $this->returnValue( true ) );

		$parserParameterProcessor->expects( $this->once() )
			->method( 'getParameterValuesFor' )
			->with(	$this->equalTo( 'bibtex' ) )
			->will( $this->returnValue( [ ] ) );

		$parserParameterProcessor->expects( $this->never() )
			->method( 'addParameter' );

		$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );

		$instance->doProcess(
			$parserParameterProcessor
		);
	}

	public function doNotProcessParameterProvider() {

		$provider[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'reference'
		];

		$provider[] = [
			'type'
		];

		return $provider;
	}

}


1			<?php
2
3			namespace SCI\Tests\Bibtex;
4
5			use SCI\Bibtex\BibtexProcessor;
6
7			/**
8			* @covers \SCI\Bibtex\BibtexProcessor
9			* @group semantic-cite
10			*
11			* @license GNU GPL v2+
12			* @since 1.0
13			*
14			* @author mwjames
15			*/
16			class BibtexProcessorTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
21			->disableOriginalConstructor()
22			->getMock();
23
24			$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
25			->disableOriginalConstructor()
26			->getMock();
27
28			$this->assertInstanceOf(
29			'\SCI\Bibtex\BibtexProcessor',
30			new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser )
31			);
32			}
33
34			public function testDoProcess() {
35
36			$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
37			->disableOriginalConstructor()
38			->getMock();
39
40			$bibtexParser->expects( $this->once() )
41			->method( 'parse' )
42			->will( $this->returnValue( [ 'Foo' => 'Bar' ] ) );
43
44			$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
45			->disableOriginalConstructor()
46			->getMock();
47
48			$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
49			->disableOriginalConstructor()
50			->getMock();
51
52			$parserParameterProcessor->expects( $this->once() )
53			->method( 'getParameterValuesFor' )
54			->with( $this->equalTo( 'bibtex' ) )
55			->will( $this->returnValue( [] ) );
56
57			$parserParameterProcessor->expects( $this->once() )
58			->method( 'addParameter' )
59			->with(
60			$this->equalTo( 'Foo' ),
61			$this->equalTo( 'Bar' ) );
62
63			$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );
64
65			$instance->doProcess(
66			$parserParameterProcessor
67			);
68			}
69
70			public function testProcessAuthors() {
71
72			$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
73			->disableOriginalConstructor()
74			->getMock();
75
76			$bibtexParser->expects( $this->once() )
77			->method( 'parse' )
78			->will( $this->returnValue( [ 'author' => 'Foo' ] ) );
79
80			$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
81			->disableOriginalConstructor()
82			->getMock();
83
84			$bibtexAuthorListParser->expects( $this->once() )
85			->method( 'parse' )
86			->will( $this->returnValue( [ 'Foo' ] ) );
87
88			$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
89			->disableOriginalConstructor()
90			->getMock();
91
92			$parserParameterProcessor->expects( $this->once() )
93			->method( 'getParameterValuesFor' )
94			->with( $this->equalTo( 'bibtex' ) )
95			->will( $this->returnValue( [ ] ) );
96
97			$parserParameterProcessor->expects( $this->once() )
98			->method( 'setParameter' )
99			->with(
100			$this->equalTo( 'author' ),
101			$this->equalTo( [ 'Foo' ] ) );
102
103			$parserParameterProcessor->expects( $this->once() )
104			->method( 'addParameter' )
105			->with(
106			$this->equalTo( 'bibtex-author' ),
107			$this->equalTo( 'Foo' ) );
108
109			$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );
110
111			$instance->doProcess(
112			$parserParameterProcessor
113			);
114			}
115
116			/**
117			* @dataProvider doNotProcessParameterProvider
118			*/
119			public function testDoNotProcess( $parameter ) {
120
121			$bibtexParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexParser' )
122			->disableOriginalConstructor()
123			->getMock();
124
125			$bibtexParser->expects( $this->once() )
126			->method( 'parse' )
127			->will( $this->returnValue( [ $parameter => 'Foo' ] ) );
128
129			$bibtexAuthorListParser = $this->getMockBuilder( '\SCI\Bibtex\BibtexAuthorListParser' )
130			->disableOriginalConstructor()
131			->getMock();
132
133			$parserParameterProcessor = $this->getMockBuilder( '\SMW\ParserParameterProcessor' )
134			->disableOriginalConstructor()
135			->getMock();
136
137			$parserParameterProcessor->expects( $this->any() )
138			->method( 'getFirstParameter' )
139			->will( $this->returnValue( '' ) );
140
141			$parserParameterProcessor->expects( $this->once() )
142			->method( 'hasParameter' )
143			->with( $this->equalTo( $parameter ) )
144			->will( $this->returnValue( true ) );
145
146			$parserParameterProcessor->expects( $this->once() )
147			->method( 'getParameterValuesFor' )
148			->with( $this->equalTo( 'bibtex' ) )
149			->will( $this->returnValue( [ ] ) );
150
151			$parserParameterProcessor->expects( $this->never() )
152			->method( 'addParameter' );
153
154			$instance = new BibtexProcessor( $bibtexParser, $bibtexAuthorListParser );
155
156			$instance->doProcess(
157			$parserParameterProcessor
158			);
159			}
160
161			public function doNotProcessParameterProvider() {
162
163			$provider[] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-24 13:24 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
164			'reference'
165			];
166
167			$provider[] = [
168			'type'
169			];
170
171			return $provider;
172			}
173
174			}
175

SemanticMediaWiki / SemanticCite

Push — master ( 0591cb...33c12c )

doNotProcessParameterProvider() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like