SemanticMediaWiki / SemanticCite

DefaultSettings.php

Spacing +4 added lines, -4 removed lines

@@ -8,13 +8,13 @@
  *
  * @codeCoverageIgnore
  */
-if ( !defined( 'MEDIAWIKI' ) ) {
-	die( 'This file is part of the SemanticCite extension, it is not a valid entry point.' );
+if (!defined('MEDIAWIKI')) {
+	die('This file is part of the SemanticCite extension, it is not a valid entry point.');
 }
 
 // In-text citation reference format options
-define( 'SCI_CITEREF_NUM', 1 );
-define( 'SCI_CITEREF_KEY', 2 );
+define('SCI_CITEREF_NUM', 1);
+define('SCI_CITEREF_KEY', 2);
 
 /**
  * Specifies the caption format of the citation reference, either as a number

SemanticCite.php

Spacing +14 added lines, -14 removed lines

@@ -25,7 +25,7 @@ 
 	 */
 	public static function load() {
 
-		if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
+		if (is_readable(__DIR__ . '/vendor/autoload.php')) {
 			include_once __DIR__ . '/vendor/autoload.php';
 		}
 
@@ -36,14 +36,14 @@ 
 	/**
 	 * @since 1.1
 	 */
-	public static function initExtension( $credits = [] ) {
+	public static function initExtension($credits = []) {
 
 		// See https://phabricator.wikimedia.org/T151136
-		define( 'SCI_VERSION', isset( $credits['version'] ) ? $credits['version'] : 'UNKNOWN' );
+		define('SCI_VERSION', isset($credits['version']) ? $credits['version'] : 'UNKNOWN');
 
 		// Extend the upgrade key provided by SMW to ensure that an DB
 		// schema is updated accordingly before using the extension
-		if ( isset( $GLOBALS['smwgUpgradeKey'] ) ) {
+		if (isset($GLOBALS['smwgUpgradeKey'])) {
 		//	$GLOBALS['smwgUpgradeKey'] .= ':scite:2018-09';
 		}
 
@@ -61,7 +61,7 @@ 
 		// Register resource files
 		$GLOBALS['wgResourceModules']['ext.scite.styles'] = [
 			'styles'  => 'res/scite.styles.css',
-			'localBasePath' => __DIR__ ,
+			'localBasePath' => __DIR__,
 			'remoteExtPath' => 'SemanticCite',
 			'position' => 'top',
 			'group'    => 'ext.smw',
@@ -76,7 +76,7 @@ 
 				'res/scite.text.selector.js',
 				'res/scite.page.creator.js'
 			],
-			'localBasePath' => __DIR__ ,
+			'localBasePath' => __DIR__,
 			'remoteExtPath' => 'SemanticCite',
 			'position' => 'top',
 			'group'    => 'ext.smw',
@@ -91,7 +91,7 @@ 
 		];
 
 		// #71
-		if ( version_compare( $GLOBALS['wgVersion'], '1.32', '<' ) ) {
+		if (version_compare($GLOBALS['wgVersion'], '1.32', '<')) {
 			$dependencies = [
 				'onoi.qtip',
 				'onoi.blobstore',
@@ -111,7 +111,7 @@ 
 			'scripts' => [
 				'res/scite.tooltip.js'
 			],
-			'localBasePath' => __DIR__ ,
+			'localBasePath' => __DIR__,
 			'remoteExtPath' => 'SemanticCite',
 			'dependencies'  => $dependencies,
 			'messages' => [
@@ -134,11 +134,11 @@ 
 	 */
 	public static function onExtensionFunction() {
 
-		if ( !defined( 'SMW_VERSION' ) ) {
-			if ( PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg' ) {
-				die( "\nThe 'Semantic Cite' extension requires 'Semantic MediaWiki' to be installed and enabled.\n" );
+		if (!defined('SMW_VERSION')) {
+			if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
+				die("\nThe 'Semantic Cite' extension requires 'Semantic MediaWiki' to be installed and enabled.\n");
 			} else {
-				die( '<b>Error:</b> The <a href="https://github.com/SemanticMediaWiki/SemanticCite/">Semantic Cite</a> extension requires <a href="https://www.semantic-mediawiki.org/wiki/Semantic_MediaWiki">Semantic MediaWiki</a> to be installed and enabled.<br />' );
+				die('<b>Error:</b> The <a href="https://github.com/SemanticMediaWiki/SemanticCite/">Semantic Cite</a> extension requires <a href="https://www.semantic-mediawiki.org/wiki/Semantic_MediaWiki">Semantic MediaWiki</a> to be installed and enabled.<br />');
 			}
 		}
 
@@ -163,8 +163,8 @@ 
 
 		$hookRegistry = new HookRegistry(
 			$applicationFactory->getStore(),
-			$applicationFactory->newCacheFactory()->newMediaWikiCompositeCache( $GLOBALS['scigReferenceListCacheType'] ),
-			new Options( $configuration )
+			$applicationFactory->newCacheFactory()->newMediaWikiCompositeCache($GLOBALS['scigReferenceListCacheType']),
+			new Options($configuration)
 		);
 
 		$hookRegistry->register();

src/Bibtex/BibtexProcessor.php

Spacing +17 added lines, -17 removed lines

@@ -26,7 +26,7 @@ 
 	 * @param BibtexParser $bibtexParser
 	 * @param BibtexAuthorListParser $bibtexAuthorListParser
 	 */
-	public function __construct( BibtexParser $bibtexParser, BibtexAuthorListParser $bibtexAuthorListParser ) {
+	public function __construct(BibtexParser $bibtexParser, BibtexAuthorListParser $bibtexAuthorListParser) {
 		$this->bibtexParser = $bibtexParser;
 		$this->bibtexAuthorListParser = $bibtexAuthorListParser;
 	}
@@ -36,30 +36,30 @@ 
 	 *
 	 * @param ParserParameterProcessor $parserParameterProcessor
 	 */
-	public function doProcess( ParserParameterProcessor $parserParameterProcessor ) {
+	public function doProcess(ParserParameterProcessor $parserParameterProcessor) {
 
 		$bibtex = $this->doPreprocess(
-			$parserParameterProcessor->getParameterValuesFor( 'bibtex' )
+			$parserParameterProcessor->getParameterValuesFor('bibtex')
 		);
 
-		$parameters = $this->bibtexParser->parse( $bibtex );
+		$parameters = $this->bibtexParser->parse($bibtex);
 
-		foreach ( $parameters as $key => $value ) {
+		foreach ($parameters as $key => $value) {
 
 			// The explicit parameters precedes the one found in bibtex
-			if ( $key === 'reference' && ( $parserParameterProcessor->hasParameter( 'reference' ) || $parserParameterProcessor->getFirstParameter() !== '' ) ) {
+			if ($key === 'reference' && ($parserParameterProcessor->hasParameter('reference') || $parserParameterProcessor->getFirstParameter() !== '')) {
 				continue;
 			}
 
-			if ( $key === 'type' && $parserParameterProcessor->hasParameter( 'type' ) ) {
+			if ($key === 'type' && $parserParameterProcessor->hasParameter('type')) {
 				continue;
 			}
 
-			if ( $key === 'author' ) {
+			if ($key === 'author') {
 
 				$parserParameterProcessor->setParameter(
 					$key,
-					$this->bibtexAuthorListParser->parse( $value )
+					$this->bibtexAuthorListParser->parse($value)
 				);
 
 				// Add the original value for easier post-processing in a template
@@ -74,23 +74,23 @@ 
 		}
 	}
 
-	private function doPreprocess( array $bibtex ) {
+	private function doPreprocess(array $bibtex) {
 
-		$bibtex = end( $bibtex );
+		$bibtex = end($bibtex);
 
 		// Avoid things like {{Stable theories}}" which are not supported in MW
 		// since the parser replaces it with [[:Template:Stable theories]]
-		$this->replace( '{{', "{", $bibtex );
-		$this->replace( '}}', "}", $bibtex );
+		$this->replace('{{', "{", $bibtex);
+		$this->replace('}}', "}", $bibtex);
 
-		$this->replace( '{\textquotesingle}', "'", $bibtex );
-		$this->replace( '$\upgamma$', "γ", $bibtex );
+		$this->replace('{\textquotesingle}', "'", $bibtex);
+		$this->replace('$\upgamma$', "γ", $bibtex);
 
 		return $bibtex;
 	}
 
-	private function replace( $search, $with, &$on ) {
-		$on = strpos( $on, $search ) !== false ? str_replace( $search, $with, $on ) : $on;
+	private function replace($search, $with, &$on) {
+		$on = strpos($on, $search) !== false ? str_replace($search, $with, $on) : $on;
 	}
 
 }

src/Bibtex/BibtexAuthorListParser.php

Spacing +40 added lines, -40 removed lines

@@ -34,14 +34,14 @@ 
 	 *
 	 * @return array
 	 */
-	public function parse( $input ) {
+	public function parse($input) {
 
 		$authorList = [];
 
 		// split on ' and '
-		$authorArray = preg_split("/\s(and|&)\s/i", trim( $input ) );
+		$authorArray = preg_split("/\s(and|&)\s/i", trim($input));
 
-		foreach( $authorArray as $value ) {
+		foreach ($authorArray as $value) {
 			$appellation = '';
 			$prefix = '';
 
@@ -50,18 +50,18 @@ 
 
 			$this->prefix = [];
 
-			$author = explode( ",", preg_replace("/\s{2,}/", ' ', trim( $value ) ) );
-			$size = count( $author );
+			$author = explode(",", preg_replace("/\s{2,}/", ' ', trim($value)));
+			$size = count($author);
 
 			// No commas therefore something like Mark Grimshaw, Mark Nicholas Grimshaw, M N Grimshaw, Mark N. Grimshaw
-			if( $size == 1 ) {
+			if ($size == 1) {
 				// Is complete surname enclosed in {...}, unless the string starts with a backslash (\) because then it is
 				// probably a special latex-sign..
 				// 2006.02.11 DR: in the last case, any NESTED curly braces should also be taken into account! so second
 				// clause rules out things such as author="a{\"{o}}"
 				//
-				if( preg_match("/(.*){([^\\\].*)}/", $value, $matches) &&
-					!(preg_match("/(.*){\\\.{.*}.*}/", $value, $matches2 ) ) ) {
+				if (preg_match("/(.*){([^\\\].*)}/", $value, $matches) &&
+					!(preg_match("/(.*){\\\.{.*}.*}/", $value, $matches2))) {
 					$author = explode(" ", $matches[1]);
 					$surname = $matches[2];
 				} else {
@@ -69,50 +69,50 @@ 
 					// last of array is surname (no prefix if entered correctly)
 					$surname = array_pop($author);
 				}
-			} elseif( $size == 2 ) { // Something like Grimshaw, Mark or Grimshaw, Mark Nicholas  or Grimshaw, M N or Grimshaw, Mark N.
+			} elseif ($size == 2) { // Something like Grimshaw, Mark or Grimshaw, Mark Nicholas  or Grimshaw, M N or Grimshaw, Mark N.
 				// first of array is surname (perhaps with prefix)
-				list( $surname, $prefix ) = $this->grabSurname( array_shift( $author ) );
+				list($surname, $prefix) = $this->grabSurname(array_shift($author));
 			} else { // If $size is 3, we're looking at something like Bush, Jr. III, George W
 				// middle of array is 'Jr.', 'IV' etc.
-				$appellation = implode(' ', array_splice( $author, 1, 1 ) );
+				$appellation = implode(' ', array_splice($author, 1, 1));
 				// first of array is surname (perhaps with prefix)
-				list( $surname, $prefix ) = $this->grabSurname( array_shift( $author ) );
+				list($surname, $prefix) = $this->grabSurname(array_shift($author));
 			}
 
-			$remainder = implode( " ", $author );
+			$remainder = implode(" ", $author);
 
-			list( $firstname, $initials ) = $this->grabFirstnameInitials( $remainder );
+			list($firstname, $initials) = $this->grabFirstnameInitials($remainder);
 
-			if( $this->prefix !== [] ) {
-				$prefix = implode(' ', $this->prefix );
+			if ($this->prefix !== []) {
+				$prefix = implode(' ', $this->prefix);
 			}
 
-			$surname = $surname . ' ' . trim( $appellation );
+			$surname = $surname . ' ' . trim($appellation);
 
-			$authorList[] = $this->concatenate( $firstname, $initials, $surname, $prefix );
+			$authorList[] = $this->concatenate($firstname, $initials, $surname, $prefix);
 		}
 
 		return $authorList;
 	}
 
-	private function concatenate( $firstname, $initials, $surname, $prefix ) {
+	private function concatenate($firstname, $initials, $surname, $prefix) {
 
 		$author = [
-			trim( $firstname ),
-			trim( $initials ),
-			trim( $prefix ),
-			trim( $surname )
+			trim($firstname),
+			trim($initials),
+			trim($prefix),
+			trim($surname)
 		];
 
-		return implode( ' ', array_filter( $author ) );
+		return implode(' ', array_filter($author));
 	}
 
 	/**
 	 * @note firstname and initials which may be of form "A.B.C." or "A. B. C. " or " A B C " etc.
 	 */
-	private function grabFirstnameInitials( $remainder ) {
+	private function grabFirstnameInitials($remainder) {
 
-		$array = explode( " ", $remainder );
+		$array = explode(" ", $remainder);
 
 		$firstname = '';
 		$initials = '';
@@ -120,25 +120,25 @@ 
 		$initialsArray = [];
 		$firstnameArray = [];
 
-		foreach( $array as $value ) {
+		foreach ($array as $value) {
 			$firstChar = substr($value, 0, 1);
 
-			if( ( ord( $firstChar ) >= 97 ) && ( ord( $firstChar ) <= 122) ) {
+			if ((ord($firstChar) >= 97) && (ord($firstChar) <= 122)) {
 				$this->prefix[] = $value;
-			} elseif( preg_match("/[a-zA-Z]{2,}/", trim( $value ) ) ) {
+			} elseif (preg_match("/[a-zA-Z]{2,}/", trim($value))) {
 				$firstnameArray[] = trim($value);
 			} else {
-				$initialsArray[] = str_replace(".", " ", trim( $value ) );
+				$initialsArray[] = str_replace(".", " ", trim($value));
 			}
 		}
 
-		foreach( $initialsArray as $initial) {
-			$initials .= ' ' . trim ( $initial );
+		foreach ($initialsArray as $initial) {
+			$initials .= ' ' . trim($initial);
 		}
 
 		$firstname = implode(" ", $firstnameArray);
 
-		return [ $firstname, $initials ];
+		return [$firstname, $initials];
 	}
 
 	/**
@@ -146,17 +146,17 @@ 
 	 * characterised by first character lowercased.  Any uppercased part means
 	 * lowercased parts following are part of the surname (e.g. Van den Bussche)
 	 */
-	private function grabSurname( $input ) {
-		$surnameArray = explode(" ", $input );
+	private function grabSurname($input) {
+		$surnameArray = explode(" ", $input);
 
 		$noPrefix = false;
 		$surname = [];
 		$prefix = [];
 
-		foreach( $surnameArray as $value ) {
+		foreach ($surnameArray as $value) {
 			$firstChar = substr($value, 0, 1);
 
-			if( !$noPrefix && ( ord( $firstChar ) >= 97 ) && ( ord( $firstChar ) <= 122 ) ) {
+			if (!$noPrefix && (ord($firstChar) >= 97) && (ord($firstChar) <= 122)) {
 				$prefix[] = $value;
 			} else {
 				$surname[] = $value;
@@ -166,10 +166,10 @@ 
 
 		$surname = implode(" ", $surname);
 
-		if( $prefix !== [] ) {
-			return [ $surname, implode(" ", $prefix ) ];
+		if ($prefix !== []) {
+			return [$surname, implode(" ", $prefix)];
 		}
 
-		return [ $surname, false ];
+		return [$surname, false];
 	}
 }

src/Bibtex/BibtexParser.php

Spacing +35 added lines, -35 removed lines

@@ -41,107 +41,107 @@
 	 *
 	 * @return array
 	 */
-	public function parse( $bibtex ) {
+	public function parse($bibtex) {
 
-		if ( ( $matches = $this->findBibtexFormatMatches( $bibtex ) ) === [] ) {
+		if (($matches = $this->findBibtexFormatMatches($bibtex)) === []) {
 			return [];
 		}
 
 		$head = [
-			'type'      => strtolower( trim( $matches[1] ) ),
+			'type'      => strtolower(trim($matches[1])),
 			'reference' => $matches[2]
 		];
 
-		return $head + $this->parseFields( $matches[3] );
+		return $head + $this->parseFields($matches[3]);
 	}
 
-	private function findBibtexFormatMatches( $bibtex ) {
+	private function findBibtexFormatMatches($bibtex) {
 
-		$matches = preg_split("/@(.*)[{(](.*),/U", $bibtex, 2, PREG_SPLIT_DELIM_CAPTURE );
+		$matches = preg_split("/@(.*)[{(](.*),/U", $bibtex, 2, PREG_SPLIT_DELIM_CAPTURE);
 
 		// Silently retreat from processing
-		if ( !isset( $matches[2] ) ) {
+		if (!isset($matches[2])) {
 			return [];
 		}
 
-		if( preg_match("/=/", $matches[2] ) ) {
-			$matches = preg_split("/@(.*)\s*[{(](.*)/U", $bibtex, 2, PREG_SPLIT_DELIM_CAPTURE );
+		if (preg_match("/=/", $matches[2])) {
+			$matches = preg_split("/@(.*)\s*[{(](.*)/U", $bibtex, 2, PREG_SPLIT_DELIM_CAPTURE);
 		}
 
 		return $matches;
 	}
 
-	private function parseFields( $content ) {
+	private function parseFields($content) {
 		$elements = [];
 		$values = [];
 
-		$length = strlen( $content );
+		$length = strlen($content);
 
-		if( $content[$length - 1] == "}" ||  $content[$length - 1] == ")" ||  $content[$length - 1] == ",") {
-			$content = substr( $content,  0, $length - 1 );
+		if ($content[$length - 1] == "}" || $content[$length - 1] == ")" || $content[$length - 1] == ",") {
+			$content = substr($content, 0, $length - 1);
 		}
 
-		$split = preg_split("/=/",  $content, 2 );
+		$split = preg_split("/=/", $content, 2);
 		$string = $split[1];
 
-		while( $string ) {
-			list( $entry, $string ) = $this->splitField( $string );
+		while ($string) {
+			list($entry, $string) = $this->splitField($string);
 			$values[] = $entry;
 		}
 
-		foreach( $values as $value ) {
-			$pos = strpos( $content, $value);
-			$content = substr_replace( $content, '', $pos, strlen( $value ) );
+		foreach ($values as $value) {
+			$pos = strpos($content, $value);
+			$content = substr_replace($content, '', $pos, strlen($value));
 		}
 
-		$rev = strrev( trim( $content ) );
+		$rev = strrev(trim($content));
 
-		if( $rev[0] != ',') {
+		if ($rev[0] != ',') {
 			 $content .= ',';
 		}
 
-		$keys = preg_split("/=,/",  $content );
+		$keys = preg_split("/=,/", $content);
 		array_pop($keys);
 
-		foreach( $keys as $key ) {
-			$value = trim( array_shift( $values ) );
-			$rev = strrev( $value );
+		foreach ($keys as $key) {
+			$value = trim(array_shift($values));
+			$rev = strrev($value);
 
 			// remove any dangling ',' left on final field of entry
-			if( $rev[0] == ',') {
+			if ($rev[0] == ',') {
 				$value = rtrim($value, ",");
 			}
 
-			if(!$value) {
+			if (!$value) {
 				continue;
 			}
 
 			$key = strtolower(trim($key));
 			$value = trim($value);
-			$elements[$key] = $this->removeDelimiters( $value );
+			$elements[$key] = $this->removeDelimiters($value);
 		}
 
 		return $elements;
 	}
 
-	private function splitField( $seg ) {
+	private function splitField($seg) {
 
-		$array = preg_split("/,\s*([-_.:,a-zA-Z0-9]+)\s*={1}\s*/U", $seg, PREG_SPLIT_DELIM_CAPTURE );
+		$array = preg_split("/,\s*([-_.:,a-zA-Z0-9]+)\s*={1}\s*/U", $seg, PREG_SPLIT_DELIM_CAPTURE);
 
 	//	if(!array_key_exists( 1, $array ) ) {
 	//		return array( $array[0], FALSE);
 	//	}
 
-		return isset( $array[1] ) ? [ $array[0], $array[1] ] : [ $array[0], false ];
+		return isset($array[1]) ? [$array[0], $array[1]] : [$array[0], false];
 	}
 
-	private function removeDelimiters( $string ) {
+	private function removeDelimiters($string) {
 
-		if( $string  && ( $string[0] == "\"") ) {
+		if ($string && ($string[0] == "\"")) {
 			$string = substr($string, 1);
 			$string = substr($string, 0, -1);
-		} else if ( $string && ( $string[0] == "{") ) {
-			if( strlen( $string ) > 0 && $string[strlen($string)-1] == "}" ) {
+		} else if ($string && ($string[0] == "{")) {
+			if (strlen($string) > 0 && $string[strlen($string) - 1] == "}") {
 				$string = substr($string, 1);
 				$string = substr($string, 0, -1);
 			}

src/ReferenceListFactory.php

Spacing +8 added lines, -8 removed lines

@@ -38,7 +38,7 @@ 
 	 * @param NamespaceExaminer $namespaceExaminer
 	 * @param CitationReferencePositionJournal $citationReferencePositionJournal
 	 */
-	public function __construct( Store $store, NamespaceExaminer $namespaceExaminer, CitationReferencePositionJournal $citationReferencePositionJournal ) {
+	public function __construct(Store $store, NamespaceExaminer $namespaceExaminer, CitationReferencePositionJournal $citationReferencePositionJournal) {
 		$this->store = $store;
 		$this->namespaceExaminer = $namespaceExaminer;
 		$this->citationReferencePositionJournal = $citationReferencePositionJournal;
@@ -55,7 +55,7 @@ 
 		$htmlColumnListRenderer = $mwCollaboratorFactory->newHtmlColumnListRenderer();
 
 		$referenceListOutputRenderer = new ReferenceListOutputRenderer(
-			new CitationResourceMatchFinder( $this->store ),
+			new CitationResourceMatchFinder($this->store),
 			$this->citationReferencePositionJournal,
 			$htmlColumnListRenderer
 		);
@@ -73,28 +73,28 @@ 
 	 *
 	 * @return CachedReferenceListOutputRenderer
 	 */
-	public function newCachedReferenceListOutputRenderer( MediaWikiContextInteractor $contextInteractor, Cache $cache, CacheKeyProvider $cacheKeyProvider, Options $options ) {
+	public function newCachedReferenceListOutputRenderer(MediaWikiContextInteractor $contextInteractor, Cache $cache, CacheKeyProvider $cacheKeyProvider, Options $options) {
 
 		$referenceListOutputRenderer = $this->newReferenceListOutputRenderer();
 
 		$referenceListOutputRenderer->setNumberOfReferenceListColumns(
-			$options->get( 'numberOfReferenceListColumns' )
+			$options->get('numberOfReferenceListColumns')
 		);
 
 		$referenceListOutputRenderer->setResponsiveMonoColumnCharacterBoundLength(
-			$options->get( 'responsiveMonoColumnCharacterBoundLength' )
+			$options->get('responsiveMonoColumnCharacterBoundLength')
 		);
 
 		$referenceListOutputRenderer->setReferenceListType(
-			$options->get( 'referenceListType' )
+			$options->get('referenceListType')
 		);
 
 		$referenceListOutputRenderer->setBrowseLinkToCitationResourceVisibility(
-			$options->get( 'browseLinkToCitationResource' )
+			$options->get('browseLinkToCitationResource')
 		);
 
 		$referenceListOutputRenderer->setCitationReferenceCaptionFormat(
-			$options->get( 'citationReferenceCaptionFormat' )
+			$options->get('citationReferenceCaptionFormat')
 		);
 
 		$cachedReferenceListOutputRenderer = new CachedReferenceListOutputRenderer(

src/MediaWikiContextInteractor.php

Spacing +16 added lines, -16 removed lines

@@ -32,7 +32,7 @@ 
 	 *
 	 * @param IContextSource $context
 	 */
-	public function __construct( IContextSource $context ) {
+	public function __construct(IContextSource $context) {
 		$this->context = $context;
 		$this->revisionLookup = MediaWikiServices::getInstance()->getRevisionLookup();
 	}
@@ -45,17 +45,17 @@ 
 	 * @return int
 	 */
 	public function getOldId() {
-		$oldid = $this->context->getRequest()->getInt( 'oldid' );
+		$oldid = $this->context->getRequest()->getInt('oldid');
 		$title = $this->context->getTitle();
 
-		switch ( $this->context->getRequest()->getText( 'direction' ) ) {
+		switch ($this->context->getRequest()->getText('direction')) {
 			case 'next':
 				# output next revision, or nothing if there isn't one
 				$nextid = 0;
-				if ( $oldid ) {
-					$revision = $this->revisionLookup->getRevisionById( $oldid );
-					$nextRevision = $this->revisionLookup->getNextRevision( $revision );
-					if ( $nextRevision ) {
+				if ($oldid) {
+					$revision = $this->revisionLookup->getRevisionById($oldid);
+					$nextRevision = $this->revisionLookup->getNextRevision($revision);
+					if ($nextRevision) {
 						$nextid = $nextRevision->getId();
 					}
 				}
@@ -64,14 +64,14 @@ 
 			case 'prev':
 				# output previous revision, or nothing if there isn't one
 				$previd = 0;
-				if ( !$oldid ) {
+				if (!$oldid) {
 					# get the current revision so we can get the penultimate one
 					$oldid = $title->getLatestRevID();
 				}
-				if ( $oldid ) {
-					$revision = $this->revisionLookup->getRevisionById( $oldid );
-					$previousRevision = $this->revisionLookup->getPreviousRevision( $revision );
-					if ( $previousRevision ) {
+				if ($oldid) {
+					$revision = $this->revisionLookup->getRevisionById($oldid);
+					$previousRevision = $this->revisionLookup->getPreviousRevision($revision);
+					if ($previousRevision) {
 						$previd = $previousRevision->getId();
 					}
 				}
@@ -92,11 +92,11 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function hasMagicWord( $magicword ) {
+	public function hasMagicWord($magicword) {
 
 		$outputPage = $this->context->getOutput();
 
-		if ( isset( $outputPage->smwmagicwords ) && in_array( $magicword, $outputPage->smwmagicwords ) ) {
+		if (isset($outputPage->smwmagicwords) && in_array($magicword, $outputPage->smwmagicwords)) {
 			return true;
 		}
 
@@ -110,8 +110,8 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function hasAction( $action ) {
-		return \Action::getActionName( $this->context ) === $action;
+	public function hasAction($action) {
+		return \Action::getActionName($this->context) === $action;
 	}
 
 	/**

src/ReferenceBacklinksLookup.php

Spacing +27 added lines, -27 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @param Store $store
 	 */
-	public function __construct( Store $store ) {
+	public function __construct(Store $store) {
 		$this->store = $store;
 	}
 
@@ -48,7 +48,7 @@ 
 	 *
 	 * @param Store $store
 	 */
-	public function setStore( Store $store ) {
+	public function setStore(Store $store) {
 		$this->store = $store;
 	}
 
@@ -57,9 +57,9 @@ 
 	 *
 	 * @param mixed|null $requestOptions
 	 */
-	public function setRequestOptions( $requestOptions = null ) {
+	public function setRequestOptions($requestOptions = null) {
 
-		if ( $requestOptions === null ) {
+		if ($requestOptions === null) {
 			return;
 		}
 
@@ -74,21 +74,21 @@ 
 	 * @param DIWikiPage $subject
 	 * @param string &$html
 	 */
-	public function getSpecialPropertySearchFurtherLink( DIProperty $property, DIWikiPage $subject, &$html ) {
+	public function getSpecialPropertySearchFurtherLink(DIProperty $property, DIWikiPage $subject, &$html) {
 
-		if ( $property->getKey() !== PropertyRegistry::SCI_CITE_REFERENCE || ( $citationKey = $this->tryToFindCitationKeyFor( $subject ) ) === null ) {
+		if ($property->getKey() !== PropertyRegistry::SCI_CITE_REFERENCE || ($citationKey = $this->tryToFindCitationKeyFor($subject)) === null) {
 			return true;
 		}
 
 		$html .= \Html::element(
 			'a',
 			[
-				'href' => \SpecialPage::getSafeTitleFor( 'SearchByProperty' )->getLocalURL( [
+				'href' => \SpecialPage::getSafeTitleFor('SearchByProperty')->getLocalURL([
 					'property' => $property->getLabel(),
 					'value' => $citationKey->getString()
-				] )
+				])
 			],
-			wfMessage( 'smw_browse_more' )->text()
+			wfMessage('smw_browse_more')->text()
 		);
 
 		return false;
@@ -102,16 +102,16 @@ 
 	 *
 	 * @param SemanticData $semanticData
 	 */
-	public function addReferenceBacklinksTo( SemanticData $semanticData ) {
+	public function addReferenceBacklinksTo(SemanticData $semanticData) {
 
-		$key = $this->tryToFindCitationKeyFor( $semanticData->getSubject() );
+		$key = $this->tryToFindCitationKeyFor($semanticData->getSubject());
 
 		$property = new DIProperty(
 			PropertyRegistry::SCI_CITE_REFERENCE
 		);
 
-		foreach ( $this->findReferenceBacklinksFor( $key ) as $subject ) {
-			$semanticData->addPropertyObjectValue( $property, $subject );
+		foreach ($this->findReferenceBacklinksFor($key) as $subject) {
+			$semanticData->addPropertyObjectValue($property, $subject);
 		}
 	}
 
@@ -122,18 +122,18 @@ 
 	 *
 	 * @return DIBlob|null
 	 */
-	public function tryToFindCitationKeyFor( DIWikiPage $subject ) {
+	public function tryToFindCitationKeyFor(DIWikiPage $subject) {
 
-		$keys = $this->store->getSemanticData( $subject )->getPropertyValues(
-			new DIProperty( PropertyRegistry::SCI_CITE_KEY )
+		$keys = $this->store->getSemanticData($subject)->getPropertyValues(
+			new DIProperty(PropertyRegistry::SCI_CITE_KEY)
 		);
 
 		// Not a resource that contains a citation key
-		if ( $keys === null || $keys === [] ) {
+		if ($keys === null || $keys === []) {
 			return null;
 		}
 
-		return end( $keys );
+		return end($keys);
 	}
 
 	/**
@@ -143,13 +143,13 @@ 
 	 *
 	 * @return DIWikiPage[]
 	 */
-	public function findReferenceBacklinksFor( $key = null ) {
+	public function findReferenceBacklinksFor($key = null) {
 
-		if ( $key === null ) {
+		if ($key === null) {
 			return [];
 		}
 
-		$property = new DIProperty( PropertyRegistry::SCI_CITE_REFERENCE );
+		$property = new DIProperty(PropertyRegistry::SCI_CITE_REFERENCE);
 
 		$description = new ValueDescription(
 			$key,
@@ -161,15 +161,15 @@ 
 			$description
 		);
 
-		$query = new Query( $someProperty );
-		$query->setLimit( $this->limit );
-		$query->setOffset( $this->offset );
+		$query = new Query($someProperty);
+		$query->setLimit($this->limit);
+		$query->setOffset($this->offset);
 
-		if ( defined( 'SMWQuery::PROC_CONTEXT' ) ) {
-			$query->setOption( Query::PROC_CONTEXT, 'SCI.ReferenceBacklinksLookup' );
+		if (defined('SMWQuery::PROC_CONTEXT')) {
+			$query->setOption(Query::PROC_CONTEXT, 'SCI.ReferenceBacklinksLookup');
 		}
 
-		return $this->store->getQueryResult( $query )->getResults();
+		return $this->store->getQueryResult($query)->getResults();
 	}
 
 }

src/CitationResourceMatchFinder.php

Spacing +31 added lines, -31 removed lines

@@ -36,7 +36,7 @@ 
 	 *
 	 * @param Store $store
 	 */
-	public function __construct( Store $store ) {
+	public function __construct(Store $store) {
 		$this->store = $store;
 		$this->dataValueFactory = DataValueFactory::getInstance();
 	}
@@ -49,11 +49,11 @@ 
 	 *
 	 * @return array
 	 */
-	public function findCitationResourceLinks( array $subjects, $linkClass = '', $caption = '' ) {
+	public function findCitationResourceLinks(array $subjects, $linkClass = '', $caption = '') {
 
 		$citationResourceLinks = [];
 
-		foreach ( $subjects as $subject ) {
+		foreach ($subjects as $subject) {
 
 			$dataValue = $this->dataValueFactory->newDataItemValue(
 				$subject,
@@ -82,21 +82,21 @@ 
 	 *
 	 * @return array
 	 */
-	public function findMatchForResourceIdentifierTypeToValue( $type, $id = null ) {
+	public function findMatchForResourceIdentifierTypeToValue($type, $id = null) {
 
-		if ( $id === null || $id === '' ) {
+		if ($id === null || $id === '') {
 			return [];
 		}
 
 		$resourceIdentifierFactory = new ResourceIdentifierFactory();
 
-		$resourceIdentifierStringValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType( $type );
-		$resourceIdentifierStringValue->setUserValue( $id );
+		$resourceIdentifierStringValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType($type);
+		$resourceIdentifierStringValue->setUserValue($id);
 		$id = $resourceIdentifierStringValue->getWikiValue();
 
 		$description = new SomeProperty(
 			$resourceIdentifierStringValue->getProperty(),
-			new ValueDescription( new DIBlob( $id ) )
+			new ValueDescription(new DIBlob($id))
 		);
 
 		$query = new Query(
@@ -106,17 +106,17 @@ 
 		);
 
 		$query->querymode = Query::MODE_INSTANCES;
-		$query->setLimit( 10 );
+		$query->setLimit(10);
 
-		if ( defined( 'SMWQuery::NO_CACHE' ) ) {
-			$query->setOption( Query::NO_CACHE, true );
+		if (defined('SMWQuery::NO_CACHE')) {
+			$query->setOption(Query::NO_CACHE, true);
 		}
 
-		if ( defined( 'SMWQuery::PROC_CONTEXT' ) ) {
-			$query->setOption( Query::PROC_CONTEXT, 'SCI.CitationResourceMatchFinder' );
+		if (defined('SMWQuery::PROC_CONTEXT')) {
+			$query->setOption(Query::PROC_CONTEXT, 'SCI.CitationResourceMatchFinder');
 		}
 
-		return $this->store->getQueryResult( $query )->getResults();
+		return $this->store->getQueryResult($query)->getResults();
 	}
 
 	/**
@@ -126,7 +126,7 @@ 
 	 *
 	 * @return array
 	 */
-	public function findCitationTextFor( $citationReference ) {
+	public function findCitationTextFor($citationReference) {
 
 		$text = '';
 		$subjects = [];
@@ -135,12 +135,12 @@ 
 			$citationReference
 		);
 
-		if ( !$queryResult instanceof \SMWQueryResult ) {
-			return [ $subjects, $text ];
+		if (!$queryResult instanceof \SMWQueryResult) {
+			return [$subjects, $text];
 		}
 
-		while ( $resultArray = $queryResult->getNext() ) {
-			foreach ( $resultArray as $result ) {
+		while ($resultArray = $queryResult->getNext()) {
+			foreach ($resultArray as $result) {
 
 				// Collect all subjects for the same reference because it can happen
 				// that the same reference key is used for different citation
@@ -148,13 +148,13 @@ 
 				// text but return all subjects to make it easier to find them later
 				$subjects[] = $result->getResultSubject();
 
-				while ( ( $dataValue = $result->getNextDataValue() ) !== false ) {
+				while (($dataValue = $result->getNextDataValue()) !== false) {
 					$text = $dataValue->getShortWikiText();
 				}
 			}
 		}
 
-		return [ $subjects, $text ];
+		return [$subjects, $text];
 	}
 
 	/**
@@ -166,20 +166,20 @@ 
 	 *
 	 * @return QueryResult
 	 */
-	public function findMatchForCitationReference( $citationReference ) {
+	public function findMatchForCitationReference($citationReference) {
 
 		$description = new SomeProperty(
-			new DIProperty( PropertyRegistry::SCI_CITE_KEY ),
-			new ValueDescription( new DIBlob( $citationReference ) )
+			new DIProperty(PropertyRegistry::SCI_CITE_KEY),
+			new ValueDescription(new DIBlob($citationReference))
 		);
 
-		$propertyValue = $this->dataValueFactory->newDataValueByType( '__pro' );
+		$propertyValue = $this->dataValueFactory->newDataValueByType('__pro');
 		$propertyValue->setDataItem(
-			new DIProperty( PropertyRegistry::SCI_CITE_TEXT )
+			new DIProperty(PropertyRegistry::SCI_CITE_TEXT)
 		);
 
 		$description->addPrintRequest(
-			new PrintRequest( PrintRequest::PRINT_PROP, null, $propertyValue )
+			new PrintRequest(PrintRequest::PRINT_PROP, null, $propertyValue)
 		);
 
 		$query = new Query(
@@ -189,13 +189,13 @@ 
 		);
 
 		$query->querymode = Query::MODE_INSTANCES;
-		$query->setLimit( 10 );
+		$query->setLimit(10);
 
-		if ( defined( 'SMWQuery::PROC_CONTEXT' ) ) {
-			$query->setOption( Query::PROC_CONTEXT, 'SCI.CitationResourceMatchFinder' );
+		if (defined('SMWQuery::PROC_CONTEXT')) {
+			$query->setOption(Query::PROC_CONTEXT, 'SCI.CitationResourceMatchFinder');
 		}
 
-		return $this->store->getQueryResult( $query );
+		return $this->store->getQueryResult($query);
 	}
 
 }