SemanticMediaWiki / SemanticCite

src/FilteredMetadata/NcbiPubMedResponseParser.php

Spacing +15 added lines, -15 removed lines

@@ -24,7 +24,7 @@ 
 	 *
 	 * @param NcbiPubMedFilteredHttpResponseParser $ncbiPubMedFilteredHttpResponseParser
 	 */
-	public function __construct( NcbiPubMedFilteredHttpResponseParser $ncbiPubMedFilteredHttpResponseParser ) {
+	public function __construct(NcbiPubMedFilteredHttpResponseParser $ncbiPubMedFilteredHttpResponseParser) {
 		$this->ncbiPubMedFilteredHttpResponseParser = $ncbiPubMedFilteredHttpResponseParser;
 	}
 
@@ -60,8 +60,8 @@ 
 	 *
 	 * {@inheritDoc}
 	 */
-	public function getRawResponse( $id ) {
-		return $this->ncbiPubMedFilteredHttpResponseParser->getRawResponse( $id );
+	public function getRawResponse($id) {
+		return $this->ncbiPubMedFilteredHttpResponseParser->getRawResponse($id);
 	}
 
 	/**
@@ -69,7 +69,7 @@ 
 	 *
 	 * {@inheritDoc}
 	 */
-	public function doFilterResponseFor( $id ) {
+	public function doFilterResponseFor($id) {
 
 		$type = $this->ncbiPubMedFilteredHttpResponseParser->getFilteredRecord()->get(
 			'ncbi-dbtype'
@@ -77,31 +77,31 @@ 
 
 		$resourceIdentifierFactory = new ResourceIdentifierFactory();
 
-		$pubmedValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType( $type );
-		$pubmedValue->setUserValue( $id );
+		$pubmedValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType($type);
+		$pubmedValue->setUserValue($id);
 
-		if ( !$pubmedValue->isValid() ) {
-			return $this->ncbiPubMedFilteredHttpResponseParser->addMessage( $pubmedValue->getErrors() );
+		if (!$pubmedValue->isValid()) {
+			return $this->ncbiPubMedFilteredHttpResponseParser->addMessage($pubmedValue->getErrors());
 		}
 
 		// NCBI requires to work without any prefix
-		$id = str_replace( 'PMC', '', $pubmedValue->getWikiValue() );
+		$id = str_replace('PMC', '', $pubmedValue->getWikiValue());
 
 		// We expect this type of either being PMC or PMID as
 		// invoked by NcbiResponseContentParser
 		$prefix = $type === 'pmc' ? 'PMC' : 'PMID';
 
-		$this->ncbiPubMedFilteredHttpResponseParser->doFilterResponseFor( $id );
+		$this->ncbiPubMedFilteredHttpResponseParser->doFilterResponseFor($id);
 		$filteredRecord = $this->ncbiPubMedFilteredHttpResponseParser->getFilteredRecord();
 
-		$filteredRecord->setTitleForPageCreation( $prefix . ':' . $id );
+		$filteredRecord->setTitleForPageCreation($prefix . ':' . $id);
 		$filteredRecord->setSciteTransclusionHead(
 			$prefix . $id
 		);
 
 		$filteredRecord->addSearchMatchSet(
 			'doi',
-			$this->ncbiPubMedFilteredHttpResponseParser->getFilteredRecord()->get( 'doi' )
+			$this->ncbiPubMedFilteredHttpResponseParser->getFilteredRecord()->get('doi')
 		);
 
 		$filteredRecord->addSearchMatchSet(
@@ -109,10 +109,10 @@ 
 			$prefix . $id
 		);
 
-		$filteredRecord->delete( 'ncbi-dbtype' );
+		$filteredRecord->delete('ncbi-dbtype');
 
-		$dateTimeUtc = new \DateTime( 'now', new \DateTimeZone( 'UTC' ) );
-		$filteredRecord->set( 'retrieved-on', $dateTimeUtc->format( 'Y-m-d' ) );
+		$dateTimeUtc = new \DateTime('now', new \DateTimeZone('UTC'));
+		$filteredRecord->set('retrieved-on', $dateTimeUtc->format('Y-m-d'));
 	}
 
 }

src/FilteredMetadata/HttpResponseParserFactory.php

Spacing +3 added lines, -3 removed lines

@@ -23,7 +23,7 @@ 
 	 *
 	 * @param HttpRequest $httpRequest
 	 */
-	public function __construct( HttpRequest $httpRequest ) {
+	public function __construct(HttpRequest $httpRequest) {
 		$this->httpRequest = $httpRequest;
 	}
 
@@ -34,7 +34,7 @@ 
 	 *
 	 * @return ResponseParser
 	 */
-	public function newResponseParserForType( $type ) {
+	public function newResponseParserForType($type) {
 
 		$bibliographicFilteredRecord = new BibliographicFilteredRecord();
 
@@ -42,7 +42,7 @@ 
 			$this->httpRequest
 		);
 
-		switch ( strtolower( $type ) ) {
+		switch (strtolower($type)) {
 			case 'doi':
 				$responseParser = new CrossRefResponseParser(
 					$filteredHttpResponseParserFactory->newCrossRefFilteredHttpResponseParser(

src/FilteredMetadata/BibliographicFilteredRecord.php

Spacing +10 added lines, -10 removed lines

@@ -65,9 +65,9 @@ 
 	 *
 	 * @return string|null
 	 */
-	public function getSearchMatchSetValueFor( $key ) {
+	public function getSearchMatchSetValueFor($key) {
 
-		if ( isset( $this->searchMatchSet[$key] ) ) {
+		if (isset($this->searchMatchSet[$key])) {
 			return  $this->searchMatchSet[$key];
 		}
 
@@ -80,7 +80,7 @@ 
 	 * @param string $key
 	 * @param string $value
 	 */
-	public function addSearchMatchSet( $key, $value ) {
+	public function addSearchMatchSet($key, $value) {
 		$this->searchMatchSet[$key] = $value;
 	}
 
@@ -89,7 +89,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function setTitleForPageCreation( $titleForPageCreation ) {
+	public function setTitleForPageCreation($titleForPageCreation) {
 		$this->titleForPageCreation = 'CR:' . $titleForPageCreation;
 	}
 
@@ -107,7 +107,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function setSciteTransclusionHead( $sciteTransclusionHead ) {
+	public function setSciteTransclusionHead($sciteTransclusionHead) {
 		$this->sciteTransclusionHead = $sciteTransclusionHead;
 	}
 
@@ -120,13 +120,13 @@ 
 
 		$text = '';
 
-		foreach ( $this->recordFields as $key => $value ) {
+		foreach ($this->recordFields as $key => $value) {
 
-			if ( is_array( $value ) ) {
-				$value = implode( ';', $value ) . ( count( $value ) > 1 ? '|+sep=;' : '' );
+			if (is_array($value)) {
+				$value = implode(';', $value) . (count($value) > 1 ? '|+sep=;' : '');
 			}
 
-			if ( $value === '' || $value === null ) {
+			if ($value === '' || $value === null) {
 				continue;
 			}
 
@@ -142,7 +142,7 @@ 
 	 * @return string
 	 */
 	public function asSciteTransclusion() {
-		return '{{#scite:' . $this->sciteTransclusionHead ."\n" . $this .  "}}";;
+		return '{{#scite:' . $this->sciteTransclusionHead . "\n" . $this . "}}"; ;
 	}
 
 }

src/FilteredMetadata/CrossRefResponseParser.php

Spacing +13 added lines, -13 removed lines

@@ -24,7 +24,7 @@ 
 	 *
 	 * @param CrossRefFilteredHttpResponseParser $crossRefFilteredHttpResponseParser
 	 */
-	public function __construct( CrossRefFilteredHttpResponseParser $crossRefFilteredHttpResponseParser ) {
+	public function __construct(CrossRefFilteredHttpResponseParser $crossRefFilteredHttpResponseParser) {
 		$this->crossRefFilteredHttpResponseParser = $crossRefFilteredHttpResponseParser;
 	}
 
@@ -60,8 +60,8 @@ 
 	 *
 	 * {@inheritDoc}
 	 */
-	public function getRawResponse( $doi ) {
-		return $this->crossRefFilteredHttpResponseParser->getRawResponse( $doi );
+	public function getRawResponse($doi) {
+		return $this->crossRefFilteredHttpResponseParser->getRawResponse($doi);
 	}
 
 	/**
@@ -69,23 +69,23 @@ 
 	 *
 	 * {@inheritDoc}
 	 */
-	public function doFilterResponseFor( $doi ) {
+	public function doFilterResponseFor($doi) {
 
 		$resourceIdentifierFactory = new ResourceIdentifierFactory();
 
-		$doiValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType( 'doi' );
-		$doiValue->setUserValue( $doi );
+		$doiValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType('doi');
+		$doiValue->setUserValue($doi);
 
-		if ( !$doiValue->isValid() ) {
-			return $this->crossRefFilteredHttpResponseParser->addMessage( $doiValue->getErrors() );
+		if (!$doiValue->isValid()) {
+			return $this->crossRefFilteredHttpResponseParser->addMessage($doiValue->getErrors());
 		}
 
 		$doi = $doiValue->getWikiValue();
 
-		$this->crossRefFilteredHttpResponseParser->doFilterResponseFor( $doi );
+		$this->crossRefFilteredHttpResponseParser->doFilterResponseFor($doi);
 		$filteredRecord = $this->crossRefFilteredHttpResponseParser->getFilteredRecord();
 
-		$filteredRecord->setTitleForPageCreation( 'DOI:' . md5( $doi ) );
+		$filteredRecord->setTitleForPageCreation('DOI:' . md5($doi));
 
 		$filteredRecord->addSearchMatchSet(
 			'doi',
@@ -94,11 +94,11 @@ 
 
 		$filteredRecord->addSearchMatchSet(
 			'reference',
-			$this->crossRefFilteredHttpResponseParser->getFilteredRecord()->get( 'reference' )
+			$this->crossRefFilteredHttpResponseParser->getFilteredRecord()->get('reference')
 		);
 
-		$dateTimeUtc = new \DateTime( 'now', new \DateTimeZone( 'UTC' ) );
-		$filteredRecord->set( 'retrieved-on', $dateTimeUtc->format( 'Y-m-d' ) );
+		$dateTimeUtc = new \DateTime('now', new \DateTimeZone('UTC'));
+		$filteredRecord->set('retrieved-on', $dateTimeUtc->format('Y-m-d'));
 	}
 
 }

src/ReferenceListParserFunction.php

Spacing +21 added lines, -21 removed lines

@@ -26,7 +26,7 @@ 
 	 *
 	 * @param ParserData $parserData
 	 */
-	public function __construct( ParserData $parserData ) {
+	public function __construct(ParserData $parserData) {
 		$this->parserData = $parserData;
 		$this->dataValueFactory = DataValueFactory::getInstance();
 	}
@@ -42,9 +42,9 @@ 
 	 *
 	 * @param ParserParameterProcessor $parserParameterProcessor
 	 */
-	public function doProcess( ParserParameterProcessor $parserParameterProcessor ) {
+	public function doProcess(ParserParameterProcessor $parserParameterProcessor) {
 
-		list( $header, $headerElement, $attributes ) = $this->getElementsForHtml(
+		list($header, $headerElement, $attributes) = $this->getElementsForHtml(
 			$parserParameterProcessor->toArray()
 		);
 
@@ -71,9 +71,9 @@ 
 		return $html . "<!-- end marker -->\n";
 	}
 
-	private function getElementsForHtml( $parameters ) {
+	private function getElementsForHtml($parameters) {
 
-		$header = wfMessage( 'sci-referencelist-header' )->text();
+		$header = wfMessage('sci-referencelist-header')->text();
 
 		// The span placeholder will hide the header from the TOC by default
 		$headerElement = 'span';
@@ -82,51 +82,51 @@ 
 			'id' => 'scite-custom-referencelist'
 		];
 
-		foreach ( $parameters as $key => $values ) {
+		foreach ($parameters as $key => $values) {
 
-			if ( $key === 'references' ) {
-				$attributes['data-references'] = $this->doProcessReferenceValues( $values );
+			if ($key === 'references') {
+				$attributes['data-references'] = $this->doProcessReferenceValues($values);
 				continue;
 			}
 
-			foreach ( $values as $value ) {
+			foreach ($values as $value) {
 
-				if ( $key === 'header' ) {
+				if ($key === 'header') {
 					$header = $value;
 				}
 
-				if ( $key === 'toc' && filter_var( $value, FILTER_VALIDATE_BOOLEAN ) ) {
+				if ($key === 'toc' && filter_var($value, FILTER_VALIDATE_BOOLEAN)) {
 					$headerElement = 'h2';
 				}
 
-				$attributes['data-'. $key] = $value;
+				$attributes['data-' . $key] = $value;
 			}
 		}
 
-		return [ $header, $headerElement, $attributes ];
+		return [$header, $headerElement, $attributes];
 	}
 
-	private function doProcessReferenceValues( array $values ) {
+	private function doProcessReferenceValues(array $values) {
 
 		$subject = $this->parserData->getSubject();
 
-		foreach ( $values as $value ) {
+		foreach ($values as $value) {
 			$dataValue = $this->dataValueFactory->newPropertyValue(
-					new DIProperty( PropertyRegistry::SCI_CITE_REFERENCE ),
-					trim( $value ),
+					new DIProperty(PropertyRegistry::SCI_CITE_REFERENCE),
+					trim($value),
 					false,
 					$subject
 				);
 
-			$this->parserData->addDataValue( $dataValue );
+			$this->parserData->addDataValue($dataValue);
 		}
 
-		if ( !$this->parserData->getSemanticData()->isEmpty() ) {
-			$this->parserData->getSubject()->setContextReference( 'referencelistp:' . uniqid() );
+		if (!$this->parserData->getSemanticData()->isEmpty()) {
+			$this->parserData->getSubject()->setContextReference('referencelistp:' . uniqid());
 			$this->parserData->pushSemanticDataToParserOutput();
 		}
 
-		return json_encode( $values );
+		return json_encode($values);
 	}
 
 }

src/CitationTextTemplateRenderer.php

Spacing +14 added lines, -14 removed lines

@@ -34,7 +34,7 @@ 
 	 * @param WikitextTemplateRenderer $wikitextTemplateRenderer
 	 * @param Parser $parser
 	 */
-	public function __construct( WikitextTemplateRenderer $wikitextTemplateRenderer, Parser $parser ) {
+	public function __construct(WikitextTemplateRenderer $wikitextTemplateRenderer, Parser $parser) {
 		$this->wikitextTemplateRenderer = $wikitextTemplateRenderer;
 		$this->parser = $parser;
 	}
@@ -44,7 +44,7 @@ 
 	 *
 	 * @param string $templateName
 	 */
-	public function packFieldsForTemplate( $templateName ) {
+	public function packFieldsForTemplate($templateName) {
 		$this->templateName = $templateName;
 	}
 
@@ -55,36 +55,36 @@ 
 	 *
 	 * @return string
 	 */
-	public function renderFor( array $parameters ) {
+	public function renderFor(array $parameters) {
 
-		$wikiText = $this->doFormat( $parameters );
+		$wikiText = $this->doFormat($parameters);
 
-		if ( $wikiText === '' ) {
+		if ($wikiText === '') {
 			return '';
 		}
 
-		return $this->parser->recursivePreprocess( $wikiText );
+		return $this->parser->recursivePreprocess($wikiText);
 	}
 
-	private function doFormat( array $parameters ) {
+	private function doFormat(array $parameters) {
 
-		if ( $this->templateName === '' ) {
+		if ($this->templateName === '') {
 			return '';
 		}
 
-		foreach ( $parameters as $key => $values ) {
+		foreach ($parameters as $key => $values) {
 
-			$key = strtolower( trim( $key ) );
+			$key = strtolower(trim($key));
 			$pieces = [];
 
-			foreach ( $values as $value ) {
-				$pieces[] = trim( $value );
+			foreach ($values as $value) {
+				$pieces[] = trim($value);
 			}
 
-			$this->wikitextTemplateRenderer->addField( $key, implode( ', ', $pieces ) );
+			$this->wikitextTemplateRenderer->addField($key, implode(', ', $pieces));
 		}
 
-		$this->wikitextTemplateRenderer->packFieldsForTemplate( $this->templateName );
+		$this->wikitextTemplateRenderer->packFieldsForTemplate($this->templateName);
 
 		return $this->wikitextTemplateRenderer->render();
 	}

src/ReferenceListOutputRenderer.php

Spacing +52 added lines, -52 removed lines

@@ -72,7 +72,7 @@ 
 	 * @param CitationReferencePositionJournal $citationReferencePositionJournal
 	 * @param HtmlColumnListRenderer $htmlColumnListRenderer
 	 */
-	public function __construct( CitationResourceMatchFinder $citationResourceMatchFinder, CitationReferencePositionJournal $citationReferencePositionJournal, HtmlColumnListRenderer $htmlColumnListRenderer ) {
+	public function __construct(CitationResourceMatchFinder $citationResourceMatchFinder, CitationReferencePositionJournal $citationReferencePositionJournal, HtmlColumnListRenderer $htmlColumnListRenderer) {
 		$this->citationResourceMatchFinder = $citationResourceMatchFinder;
 		$this->citationReferencePositionJournal = $citationReferencePositionJournal;
 		$this->htmlColumnListRenderer = $htmlColumnListRenderer;
@@ -83,7 +83,7 @@ 
 	 *
 	 * @param integer $citationReferenceCaptionFormat
 	 */
-	public function setCitationReferenceCaptionFormat( $citationReferenceCaptionFormat ) {
+	public function setCitationReferenceCaptionFormat($citationReferenceCaptionFormat) {
 		$this->citationReferenceCaptionFormat = (int)$citationReferenceCaptionFormat;
 	}
 
@@ -92,7 +92,7 @@ 
 	 *
 	 * @param integer $responsiveMonoColumnCharacterBoundLength
 	 */
-	public function setResponsiveMonoColumnCharacterBoundLength( $responsiveMonoColumnCharacterBoundLength ) {
+	public function setResponsiveMonoColumnCharacterBoundLength($responsiveMonoColumnCharacterBoundLength) {
 		$this->responsiveMonoColumnCharacterBoundLength = (int)$responsiveMonoColumnCharacterBoundLength;
 	}
 
@@ -101,7 +101,7 @@ 
 	 *
 	 * @param integer $numberOfReferenceListColumns
 	 */
-	public function setNumberOfReferenceListColumns( $numberOfReferenceListColumns ) {
+	public function setNumberOfReferenceListColumns($numberOfReferenceListColumns) {
 		$this->numberOfReferenceListColumns = (int)$numberOfReferenceListColumns;
 	}
 
@@ -119,7 +119,7 @@ 
 	 *
 	 * @param string $referenceListType
 	 */
-	public function setReferenceListType( $referenceListType ) {
+	public function setReferenceListType($referenceListType) {
 		$this->referenceListType = $referenceListType;
 	}
 
@@ -137,7 +137,7 @@ 
 	 *
 	 * @param boolean $browseLinkToCitationResourceVisibility
 	 */
-	public function setBrowseLinkToCitationResourceVisibility( $browseLinkToCitationResourceVisibility ) {
+	public function setBrowseLinkToCitationResourceVisibility($browseLinkToCitationResourceVisibility) {
 		$this->browseLinkToCitationResourceVisibility = (bool)$browseLinkToCitationResourceVisibility;
 	}
 
@@ -155,7 +155,7 @@ 
 	 *
 	 * @param string $referenceListHeader
 	 */
-	public function setReferenceListHeader( $referenceListHeader ) {
+	public function setReferenceListHeader($referenceListHeader) {
 		$this->referenceListHeader = (string)$referenceListHeader;
 	}
 
@@ -164,7 +164,7 @@ 
 	 *
 	 * @param string $referenceListHeaderTocId
 	 */
-	public function setReferenceListHeaderTocId( $referenceListHeaderTocId ) {
+	public function setReferenceListHeaderTocId($referenceListHeaderTocId) {
 		$this->referenceListHeaderTocId = (string)$referenceListHeaderTocId;
 	}
 
@@ -176,9 +176,9 @@ 
 	 *
 	 * @return string
 	 */
-	public function doRenderReferenceListFor( DIWikiPage $subject, array $referenceList = null ) {
+	public function doRenderReferenceListFor(DIWikiPage $subject, array $referenceList = null) {
 
-		if ( $referenceList !== null ) {
+		if ($referenceList !== null) {
 			$journal = $this->citationReferencePositionJournal->buildJournalForUnboundReferenceList(
 				$referenceList
 			);
@@ -188,8 +188,8 @@ 
 			);
 		}
 
-		if ( $journal !== null ) {
-			return $this->createHtmlFromJournal( $journal );
+		if ($journal !== null) {
+			return $this->createHtmlFromJournal($journal);
 		}
 
 		return '';
@@ -202,24 +202,24 @@ 
 	 * 'reference-list' => array of hashes for references used
 	 * 'reference-pos'  => individual reference links (1-a, 1-b) assigned to a hash
 	 */
-	private function createHtmlFromJournal( array $journal ) {
+	private function createHtmlFromJournal(array $journal) {
 
 		$listOfFormattedReferences = [];
 		$targetList = [];
 		$length = 0;
 
-		foreach ( $journal['reference-pos'] as $hash => $linkList ) {
+		foreach ($journal['reference-pos'] as $hash => $linkList) {
 
 			$citationText = '';
 			// Get the "human" readable citation key/reference from the hashmap
 			// intead of trying to access the DB/Store
 			$reference = $journal['reference-list'][$hash];
 
-			list( $subjects, $citationText ) = $this->findCitationTextFor(
+			list($subjects, $citationText) = $this->findCitationTextFor(
 				$reference
 			);
 
-			$length += mb_strlen( $citationText );
+			$length += mb_strlen($citationText);
 
 			$flatHtmlReferenceLinks = $this->createFlatHtmlListForReferenceLinks(
 				$linkList,
@@ -232,13 +232,13 @@ 
 				$citationText
 			);
 
-			if ( method_exists( $this->htmlColumnListRenderer, 'setItemAttributes' ) ) {
+			if (method_exists($this->htmlColumnListRenderer, 'setItemAttributes')) {
 				$attribs = [
 					'class' => 'scite-referencelinks'
 				];
 			} else {
 				$attribs = [
-					'id' => 'scite-'. $hash,
+					'id' => 'scite-' . $hash,
 					'class' => 'scite-referencelinks'
 				];
 			}
@@ -248,54 +248,54 @@ 
 				$attribs,
 				$flatHtmlReferenceLinks
 			) .
-			( $flatHtmlReferenceLinks !== '' ? ' ' : '' )  .
+			($flatHtmlReferenceLinks !== '' ? ' ' : '') .
 			Html::rawElement(
 				'span',
 				[
 					'class' => 'scite-citation'
 				],
-				( $browseLinks !== '' ? $browseLinks . ' ' : '' ) . Html::rawElement(
+				($browseLinks !== '' ? $browseLinks . ' ' : '') . Html::rawElement(
 					'span',
-					[ 'class' => 'scite-citation-text' ],
+					['class' => 'scite-citation-text'],
 					$citationText
 				)
 			);
 
 			$listOfFormattedReferences[] = $ref;
-			$targetList[md5($ref)] = [ 'id' => 'scite-'. $hash ];
+			$targetList[md5($ref)] = ['id' => 'scite-' . $hash];
 		}
 
-		return $this->makeList( $listOfFormattedReferences, $targetList, $length );
+		return $this->makeList($listOfFormattedReferences, $targetList, $length);
 	}
 
-	private function makeList( $listOfFormattedReferences, $targetList, $length ) {
+	private function makeList($listOfFormattedReferences, $targetList, $length) {
 
-		$monoClass = ( $length > $this->responsiveMonoColumnCharacterBoundLength ? '' : '-mono' );
+		$monoClass = ($length > $this->responsiveMonoColumnCharacterBoundLength ? '' : '-mono');
 
 		// #33, #32
 		$this->htmlColumnListRenderer->setColumnListClass(
-			'scite-referencelist' . ( $this->numberOfReferenceListColumns == 0 ? ' responsive-list' . $monoClass : '' )
+			'scite-referencelist' . ($this->numberOfReferenceListColumns == 0 ? ' responsive-list' . $monoClass : '')
 		);
 
-		$this->htmlColumnListRenderer->setListType( $this->referenceListType );
-		$this->htmlColumnListRenderer->addContentsByNoIndex( $listOfFormattedReferences );
+		$this->htmlColumnListRenderer->setListType($this->referenceListType);
+		$this->htmlColumnListRenderer->addContentsByNoIndex($listOfFormattedReferences);
 
-		if ( method_exists( $this->htmlColumnListRenderer, 'setItemAttributes' ) ) {
-			$this->htmlColumnListRenderer->setItemAttributes( $targetList );
+		if (method_exists($this->htmlColumnListRenderer, 'setItemAttributes')) {
+			$this->htmlColumnListRenderer->setItemAttributes($targetList);
 		}
 
-		if ( $this->numberOfReferenceListColumns == 0 ) {
-			$this->htmlColumnListRenderer->setColumnClass( 'scite-referencelist-columns-responsive'. $monoClass );
+		if ($this->numberOfReferenceListColumns == 0) {
+			$this->htmlColumnListRenderer->setColumnClass('scite-referencelist-columns-responsive' . $monoClass);
 		} else {
-			$this->htmlColumnListRenderer->setNumberOfColumns( $this->numberOfReferenceListColumns );
-			$this->htmlColumnListRenderer->setColumnClass( 'scite-referencelist-columns-fixed' );
+			$this->htmlColumnListRenderer->setNumberOfColumns($this->numberOfReferenceListColumns);
+			$this->htmlColumnListRenderer->setColumnClass('scite-referencelist-columns-fixed');
 		}
 
-		if ( $this->referenceListHeader === '' ) {
-			$this->referenceListHeader = wfMessage( 'sci-referencelist-header' )->text();
+		if ($this->referenceListHeader === '') {
+			$this->referenceListHeader = wfMessage('sci-referencelist-header')->text();
 		}
 
-		if ( $this->referenceListHeaderTocId === '' ) {
+		if ($this->referenceListHeaderTocId === '') {
 			$this->referenceListHeaderTocId = $this->referenceListHeader;
 		}
 
@@ -314,9 +314,9 @@ 
 		);
 	}
 
-	private function findCitationTextFor( $reference ) {
+	private function findCitationTextFor($reference) {
 
-		list( $subjects, $text ) = $this->citationResourceMatchFinder->findCitationTextFor(
+		list($subjects, $text) = $this->citationResourceMatchFinder->findCitationTextFor(
 			$reference
 		);
 
@@ -324,32 +324,32 @@ 
 		// parsed and escaped which saves the trouble to deal with Parser stubobject
 		return [
 			$subjects,
-			wfMessage( 'sci-referencelist-text', $text )->parse()
+			wfMessage('sci-referencelist-text', $text)->parse()
 		];
 	}
 
-	private function createFlatHtmlListForReferenceLinks( array $linkList, $referenceHash ) {
+	private function createFlatHtmlListForReferenceLinks(array $linkList, $referenceHash) {
 
 		$referenceLinks = [];
 		$class = 'scite-backlinks';
 
-		foreach ( $linkList as $value ) {
+		foreach ($linkList as $value) {
 
-			$isOneLinkElement = count( $linkList ) == 1;
+			$isOneLinkElement = count($linkList) == 1;
 
 			// Split a value of 1-a, 1-b, 2-a into its parts
-			list( $major, $minor ) = explode( '-', $value );
+			list($major, $minor) = explode('-', $value);
 
 			// Show a simple link similar to what is done on en.wp
 			// for a one-link-reference
-			if ( $isOneLinkElement ) {
+			if ($isOneLinkElement) {
 				$minor = '^';
 				$class = 'scite-backlink';
 			}
 
 			// Only display the "full" number for the combination of UL/SCI_CITEREF_NUM
-			if ( $this->referenceListType === 'ul' && $this->citationReferenceCaptionFormat === SCI_CITEREF_NUM ) {
-				$minor = $isOneLinkElement ? $major : str_replace( '-', '.', $value );
+			if ($this->referenceListType === 'ul' && $this->citationReferenceCaptionFormat === SCI_CITEREF_NUM) {
+				$minor = $isOneLinkElement ? $major : str_replace('-', '.', $value);
 			}
 
 			$referenceLinks[] = Html::rawElement(
@@ -363,13 +363,13 @@ 
 			);
 		}
 
-		return implode( ' ', $referenceLinks );
+		return implode(' ', $referenceLinks);
 	}
 
-	private function createBrowseLinksWith( array $subjects, $reference, $citationText ) {
+	private function createBrowseLinksWith(array $subjects, $reference, $citationText) {
 
 		// If no text is available at least show the reference
-		if ( $citationText === '' ) {
+		if ($citationText === '') {
 			return Html::rawElement(
 				'span',
 				[
@@ -380,7 +380,7 @@ 
 		}
 
 		// No browse links means nothing will be displayed
-		if ( !$this->browseLinkToCitationResourceVisibility ) {
+		if (!$this->browseLinkToCitationResourceVisibility) {
 			return '';
 		}
 
@@ -392,7 +392,7 @@ 
 		// Normally we should have only one subject to host a citation resource
 		// for the reference in question but it might be that double assingments
 		// did occur and therefore show them all
-		return implode( ' | ', $citationResourceLinks );
+		return implode(' | ', $citationResourceLinks);
 	}
 
 }

src/CachedReferenceListOutputRenderer.php

Spacing +44 added lines, -44 removed lines

@@ -58,7 +58,7 @@ 
 	 * @param Cache $cache
 	 * @param CacheKeyProvider $cacheKeyProvider
 	 */
-	public function __construct( ReferenceListOutputRenderer $referenceListOutputRenderer, MediaWikiContextInteractor $contextInteractor, NamespaceExaminer $namespaceExaminer, Cache $cache, CacheKeyProvider $cacheKeyProvider ) {
+	public function __construct(ReferenceListOutputRenderer $referenceListOutputRenderer, MediaWikiContextInteractor $contextInteractor, NamespaceExaminer $namespaceExaminer, Cache $cache, CacheKeyProvider $cacheKeyProvider) {
 		$this->referenceListOutputRenderer = $referenceListOutputRenderer;
 		$this->contextInteractor = $contextInteractor;
 		$this->namespaceExaminer = $namespaceExaminer;
@@ -73,8 +73,8 @@ 
 	 */
 	public function getSubject() {
 
-		if (  $this->subject === null ) {
-			$this->subject = DIWikiPage::newFromTitle( $this->contextInteractor->getTitle() );
+		if ($this->subject === null) {
+			$this->subject = DIWikiPage::newFromTitle($this->contextInteractor->getTitle());
 		}
 
 		return $this->subject;
@@ -85,22 +85,22 @@ 
 	 *
 	 * @param string &$text
 	 */
-	public function addReferenceListToText( &$text ) {
+	public function addReferenceListToText(&$text) {
 
-		if ( $this->contextInteractor->hasMagicWord( 'SCI_NOREFERENCELIST' ) || !$this->contextInteractor->hasAction( 'view' ) ) {
-			return $this->removeReferenceListPlaceholder( $text );
+		if ($this->contextInteractor->hasMagicWord('SCI_NOREFERENCELIST') || !$this->contextInteractor->hasAction('view')) {
+			return $this->removeReferenceListPlaceholder($text);
 		}
 
-		if ( !$this->namespaceExaminer->isSemanticEnabled( $this->getSubject()->getNamespace() ) ) {
+		if (!$this->namespaceExaminer->isSemanticEnabled($this->getSubject()->getNamespace())) {
 			return '';
 		}
 
-		$this->addReferenceListToCorrectTextPosition( $text );
+		$this->addReferenceListToCorrectTextPosition($text);
 	}
 
-	private function removeReferenceListPlaceholder( &$text ) {
+	private function removeReferenceListPlaceholder(&$text) {
 
-		if ( strpos( $text, 'scite-custom-referencelist' ) === false ) {
+		if (strpos($text, 'scite-custom-referencelist') === false) {
 			return null;
 		}
 
@@ -111,7 +111,7 @@ 
 		);
 	}
 
-	private function addReferenceListToCorrectTextPosition( &$text ) {
+	private function addReferenceListToCorrectTextPosition(&$text) {
 
 		// Remember the default options before trying to replace all list
 		// placeholders to ensure to reset options to the default option
@@ -123,7 +123,7 @@ 
 		];
 
 		// Find out whether to place the list into a custom position or not
-		if ( strpos( $text, 'scite-custom-referencelist' ) !== false ) {
+		if (strpos($text, 'scite-custom-referencelist') !== false) {
 			return $text = preg_replace_callback(
 				"/" . "<div id=\"scite-custom-referencelist\"(.*)?>(<h2>|<span>)(.*)?<\/div>" . "/m",
 				'self::getCustomizedRenderedHtmlReferenceList',
@@ -133,67 +133,67 @@ 
 
 		// #27 auto-referencelist for the NS_FILE can not be managed accurately therefore
 		// disable such list
-		if ( $this->contextInteractor->getTitle()->getNamespace() !== NS_FILE ) {
+		if ($this->contextInteractor->getTitle()->getNamespace() !== NS_FILE) {
 			$text .= $this->getRenderedHtmlReferenceList();
 		}
 	}
 
-	private function getCustomizedRenderedHtmlReferenceList( $customOptions ) {
+	private function getCustomizedRenderedHtmlReferenceList($customOptions) {
 
-		$this->searchForReferenceListHeaderTocId( $customOptions );
+		$this->searchForReferenceListHeaderTocId($customOptions);
 
 		// Reset options
-		$this->referenceListOutputRenderer->setReferenceListHeader( '' );
-		$this->referenceListOutputRenderer->setReferenceListType( $this->defaultOptions['listtype'] );
-		$this->referenceListOutputRenderer->setNumberOfReferenceListColumns( $this->defaultOptions['columns'] );
-		$this->referenceListOutputRenderer->setBrowseLinkToCitationResourceVisibility( $this->defaultOptions['browse'] );
+		$this->referenceListOutputRenderer->setReferenceListHeader('');
+		$this->referenceListOutputRenderer->setReferenceListType($this->defaultOptions['listtype']);
+		$this->referenceListOutputRenderer->setNumberOfReferenceListColumns($this->defaultOptions['columns']);
+		$this->referenceListOutputRenderer->setBrowseLinkToCitationResourceVisibility($this->defaultOptions['browse']);
 
-		$customOptions = explode( 'data-', $customOptions[1] );
+		$customOptions = explode('data-', $customOptions[1]);
 
 		$references = '';
 		$fingerprint = '';
 
-		foreach ( $customOptions as $options ) {
+		foreach ($customOptions as $options) {
 
-			if ( strpos( $options, '=' ) === false ) {
+			if (strpos($options, '=') === false) {
 				continue;
 			}
 
-			$options = explode( '=', trim( str_replace( '"', '', $options ) ) );
-			$this->doFilterValidOption( $options, $references, $fingerprint );
+			$options = explode('=', trim(str_replace('"', '', $options)));
+			$this->doFilterValidOption($options, $references, $fingerprint);
 		}
 
-		return $this->getRenderedHtmlReferenceList( $references, $fingerprint );
+		return $this->getRenderedHtmlReferenceList($references, $fingerprint);
 	}
 
-	private function searchForReferenceListHeaderTocId( array $options ) {
+	private function searchForReferenceListHeaderTocId(array $options) {
 
 		$headerId = [];
-		$this->referenceListOutputRenderer->setReferenceListHeaderTocId( '' );
+		$this->referenceListOutputRenderer->setReferenceListHeaderTocId('');
 
 		// We know where to expect the index from preg_*
-		if ( isset( $options[3] ) ) {
-			preg_match("/id=\"(.*)\"/", $options[3], $headerId );
+		if (isset($options[3])) {
+			preg_match("/id=\"(.*)\"/", $options[3], $headerId);
 		}
 
-		if ( $headerId !== [] ) {
-			$this->referenceListOutputRenderer->setReferenceListHeaderTocId( $headerId[1] );
+		if ($headerId !== []) {
+			$this->referenceListOutputRenderer->setReferenceListHeaderTocId($headerId[1]);
 		}
 	}
 
-	private function doFilterValidOption( $options, &$references, &$fingerprint ) {
+	private function doFilterValidOption($options, &$references, &$fingerprint) {
 
 		$columns = '';
 		$header = '';
 
-		switch ( $options[0] ) {
+		switch ($options[0]) {
 			case 'browselinks':
 				$this->referenceListOutputRenderer->setBrowseLinkToCitationResourceVisibility(
-					filter_var( $options[1], FILTER_VALIDATE_BOOLEAN )
+					filter_var($options[1], FILTER_VALIDATE_BOOLEAN)
 				);
 				break;
 			case 'listtype':
-				$this->referenceListOutputRenderer->setReferenceListType( $options[1] );
+				$this->referenceListOutputRenderer->setReferenceListType($options[1]);
 				break;
 			case 'columns':
 				$columns = $options[1] < 0 ? 0 : $options[1];
@@ -203,7 +203,7 @@ 
 				break;
 			case 'header':
 				$header = $options[1];
-				$this->referenceListOutputRenderer->setReferenceListHeader( $header );
+				$this->referenceListOutputRenderer->setReferenceListHeader($header);
 				break;
 			case 'references':
 				$references = $options[1];
@@ -213,7 +213,7 @@ 
 		$fingerprint = $header . $columns;
 	}
 
-	private function getRenderedHtmlReferenceList( $references = '', $fingerprint = ''  ) {
+	private function getRenderedHtmlReferenceList($references = '', $fingerprint = '') {
 
 		$container = [];
 		$oldId = $this->contextInteractor->getOldId();
@@ -228,26 +228,26 @@ 
 		$revId = $oldId != 0 ? $oldId : $this->contextInteractor->getTitle()->getLatestRevID();
 
 		// Create an individual hash for when loose references are used
-		$renderedReferenceListHash = md5( $this->getSubject()->getHash() . $references . $fingerprint );
+		$renderedReferenceListHash = md5($this->getSubject()->getHash() . $references . $fingerprint);
 
-		if ( $this->cache->contains( $key ) ) {
-			$container = $this->cache->fetch( $key );
+		if ($this->cache->contains($key)) {
+			$container = $this->cache->fetch($key);
 
 			// Match against revision, languageCode, and hash
-			if ( isset( $container['revId'] ) &&
+			if (isset($container['revId']) &&
 				$container['revId'] == $revId &&
-				isset( $container['text'][$lang][$renderedReferenceListHash] ) ) {
+				isset($container['text'][$lang][$renderedReferenceListHash])) {
 				return $container['text'][$lang][$renderedReferenceListHash];
 			}
 		}
 
 		$renderedReferenceList = $this->referenceListOutputRenderer->doRenderReferenceListFor(
 			$this->getSubject(),
-			json_decode( html_entity_decode( $references ) )
+			json_decode(html_entity_decode($references))
 		);
 
 		// Don't cache a history/diff view
-		if ( $oldId != 0 ) {
+		if ($oldId != 0) {
 			return $renderedReferenceList;
 		}
 

src/Specials/SpecialFindCitableMetadata.php

Spacing +30 added lines, -30 removed lines

@@ -22,7 +22,7 @@ 
 	 * @codeCoverageIgnore
 	 */
 	public function __construct() {
-		parent::__construct( 'FindCitableMetadata', 'sci-metadatasearch' );
+		parent::__construct('FindCitableMetadata', 'sci-metadatasearch');
 	}
 
 	/**
@@ -35,18 +35,18 @@ 
 	/**
 	 * @see SpecialPage::execute
 	 */
-	public function execute( $query ) {
+	public function execute($query) {
 
-		if ( !$this->userCanExecute( $this->getUser() ) ) {
+		if (!$this->userCanExecute($this->getUser())) {
 			$this->displayRestrictionError();
 			return;
 		}
 
 		$output = $this->getOutput();
-		$output->setPageTitle( $this->msg( 'findmetadatabyid' )->text() );
+		$output->setPageTitle($this->msg('findmetadatabyid')->text());
 		$this->setHeaders();
 
-		$output->addModuleStyles( 'ext.scite.styles' );
+		$output->addModuleStyles('ext.scite.styles');
 
 		$output->addModules(
 			[
@@ -54,25 +54,25 @@ 
 			]
 		);
 
-		list( $type, $id, $format ) = $this->getRequestParameters(
+		list($type, $id, $format) = $this->getRequestParameters(
 			$query
 		);
 
-		if ( $type === 'pmid' ) {
+		if ($type === 'pmid') {
 			$type = 'pubmed';
 		}
 
-		$this->callPageBuilderFor( $type, $id, $format );
+		$this->callPageBuilderFor($type, $id, $format);
 	}
 
-	private function callPageBuilderFor( $type, $id, $format ) {
+	private function callPageBuilderFor($type, $id, $format) {
 
 		$pageBuilder = $this->newPageBuilder();
 
-		if ( $format === 'raw' ) {
+		if ($format === 'raw') {
 			$this->getOutput()->disable();
-			header( "Content-type: text/plain; charset=utf-8" );
-			header( 'Cache-Control: private, no-cache, must-revalidate' );
+			header("Content-type: text/plain; charset=utf-8");
+			header('Cache-Control: private, no-cache, must-revalidate');
 
 			$html = $pageBuilder->getRawResponseFor(
 				$type, $id
@@ -85,25 +85,25 @@ 
 			$type, $id
 		);
 
-		$this->getOutput()->addHTML( $html );
-		$this->addExternalHelpLinkFor( 'sci-specials-citablemetadata-helplink' );
+		$this->getOutput()->addHTML($html);
+		$this->addExternalHelpLinkFor('sci-specials-citablemetadata-helplink');
 	}
 
-	private function getRequestParameters( $query ) {
+	private function getRequestParameters($query) {
 
 		$request = $this->getRequest()->getValues();
 
-		if ( strpos( $query, '/' ) !== false ) {
-			list( $type, $id ) = explode( '/', $query, 2 );
+		if (strpos($query, '/') !== false) {
+			list($type, $id) = explode('/', $query, 2);
 			$request['type'] = $type;
 			$request['id'] = $id;
 		}
 
-		$id = isset( $request['id'] ) ? trim( $request['id'] ) : '';
-		$type = isset( $request['type'] ) ? strtolower( $request['type'] ) : '';
-		$format = isset( $request['format'] ) ? strtolower( $request['format'] ) : '';
+		$id = isset($request['id']) ? trim($request['id']) : '';
+		$type = isset($request['type']) ? strtolower($request['type']) : '';
+		$format = isset($request['format']) ? strtolower($request['format']) : '';
 
-		return [ $type, $id, $format ];
+		return [$type, $id, $format];
 	}
 
 	private function newPageBuilder() {
@@ -117,21 +117,21 @@ 
 		);
 
 		$httpRequestFactory = new HttpRequestFactory(
-			$applicationFactory->newCacheFactory()->newMediaWikiCompositeCache( $GLOBALS['scigMetadataResponseCacheType'] )
+			$applicationFactory->newCacheFactory()->newMediaWikiCompositeCache($GLOBALS['scigMetadataResponseCacheType'])
 		);
 
 		$httpRequest = $httpRequestFactory->newCachedCurlRequest();
-		$httpRequest->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_TTL, $GLOBALS['scigMetadataResponseCacheLifetime'] );
-		$httpRequest->setOption( ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX, $GLOBALS['scigCachePrefix'] . ':sci:meta:' );
+		$httpRequest->setOption(ONOI_HTTP_REQUEST_RESPONSECACHE_TTL, $GLOBALS['scigMetadataResponseCacheLifetime']);
+		$httpRequest->setOption(ONOI_HTTP_REQUEST_RESPONSECACHE_PREFIX, $GLOBALS['scigCachePrefix'] . ':sci:meta:');
 
 		$pageBuilder = new PageBuilder(
 			$htmlFormRenderer,
 			$mwCollaboratorFactory->newHtmlColumnListRenderer(),
-			new CitationResourceMatchFinder( $applicationFactory->getStore() ),
-			new HttpResponseParserFactory( $httpRequest )
+			new CitationResourceMatchFinder($applicationFactory->getStore()),
+			new HttpResponseParserFactory($httpRequest)
 		);
 
-		$pageBuilder->isReadOnly( MediaWikiServices::getInstance()->getReadOnlyMode()->isReadOnly() );
+		$pageBuilder->isReadOnly(MediaWikiServices::getInstance()->getReadOnlyMode()->isReadOnly());
 
 		return $pageBuilder;
 	}
@@ -139,13 +139,13 @@ 
 	/**
 	 * FIXME MW 1.25
 	 */
-	private function addExternalHelpLinkFor( $key ) {
+	private function addExternalHelpLinkFor($key) {
 
-		if ( !method_exists( $this, 'addHelpLink' ) ) {
+		if (!method_exists($this, 'addHelpLink')) {
 			return null;
 		}
 
-		$this->getOutput()->addHelpLink( wfMessage( $key )->escaped(), true );
+		$this->getOutput()->addHelpLink(wfMessage($key)->escaped(), true);
 	}
 
 }