PreTextFormatterTest - Code Metrics - Inspection of "Add test" - SemanticMediaWiki/SemanticCite - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36ba73...9ed582 )

by mw

created 2017-05-28 04:07 UTC

PreTextFormatterTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	5
lcom	1
cbo	1
dl	0
loc	72
rs	10
c	1
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	setUp()	7	1
A	testCanConstruct()	7	1
A	testFormat()	9	1
A	testGetFormattedSciteFuncFrom()	9	1
A	parametersProvider()	22	1

<?php

namespace SCI\Tests;

use SCI\PreTextFormatter;
use Title;
use Parser;
use ParserOptions;

/**
 * @covers \SCI\PreTextFormatter
 * @group semantic-cite
 *
 * @license GNU GPL v2+
 * @since 1.4
 *
 * @author mwjames
 */
class PreTextFormatterTest extends \PHPUnit_Framework_TestCase {

	const LF = "\n";

	private $parser;

	protected function setUp() {
		parent::setUp();

		$this->parser = new Parser();
		$this->parser->Options( new ParserOptions() );
		$this->parser->clearState();
	}

	public function testCanConstruct() {

		$this->assertInstanceOf(
			'\SCI\PreTextFormatter',
			new PreTextFormatter()
		);
	}

	/**
	 * @dataProvider parametersProvider
	 */
	public function testFormat( $params ) {

		$instance = new PreTextFormatter();

		$this->assertInternalType(
			'array',
			$instance->format( $params )
		);
	}

	/**
	 * @dataProvider parametersProvider
	 */
	public function testGetFormattedSciteFuncFrom( $params, $expected ) {

		$instance = new PreTextFormatter();

		$this->assertSame(
			$expected,
			$instance->getFormattedSciteFuncFrom( $params )
		);
	}

	public function parametersProvider() {

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			array(
				'Bar',
				'@Foobar'
			),
			"<pre>{{#scite:" . self::LF . " |Bar" . self::LF . "}}</pre>"
		);

		$provider[] = array(
			array(
				'Bar',
				'+sep=,',
				'@Foobar',
				'Foo'
			),
			"<pre>{{#scite:" . self::LF . " |Bar|+sep=," . self::LF . " |Foo" . self::LF . "}}</pre>"
		);

		return $provider;
	}

}


1			<?php
2
3			namespace SCI\Tests;
4
5			use SCI\PreTextFormatter;
6			use Title;
7			use Parser;
8			use ParserOptions;
9
10			/**
11			* @covers \SCI\PreTextFormatter
12			* @group semantic-cite
13			*
14			* @license GNU GPL v2+
15			* @since 1.4
16			*
17			* @author mwjames
18			*/
19			class PreTextFormatterTest extends \PHPUnit_Framework_TestCase {
20
21			const LF = "\n";
22
23			private $parser;
24
25			protected function setUp() {
26			parent::setUp();
27
28			$this->parser = new Parser();
29			$this->parser->Options( new ParserOptions() );
30			$this->parser->clearState();
31			}
32
33			public function testCanConstruct() {
34
35			$this->assertInstanceOf(
36			'\SCI\PreTextFormatter',
37			new PreTextFormatter()
38			);
39			}
40
41			/**
42			* @dataProvider parametersProvider
43			*/
44			public function testFormat( $params ) {
45
46			$instance = new PreTextFormatter();
47
48			$this->assertInternalType(
49			'array',
50			$instance->format( $params )
51			);
52			}
53
54			/**
55			* @dataProvider parametersProvider
56			*/
57			public function testGetFormattedSciteFuncFrom( $params, $expected ) {
58
59			$instance = new PreTextFormatter();
60
61			$this->assertSame(
62			$expected,
63			$instance->getFormattedSciteFuncFrom( $params )
64			);
65			}
66
67			public function parametersProvider() {
68
69			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2015-11-24 13:24 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
70			array(
71			'Bar',
72			'@Foobar'
73			),
74			"<pre>{{#scite:" . self::LF . " \|Bar" . self::LF . "}}</pre>"
75			);
76
77			$provider[] = array(
78			array(
79			'Bar',
80			'+sep=,',
81			'@Foobar',
82			'Foo'
83			),
84			"<pre>{{#scite:" . self::LF . " \|Bar\|+sep=," . self::LF . " \|Foo" . self::LF . "}}</pre>"
85			);
86
87			return $provider;
88			}
89
90			}
91

SemanticMediaWiki / SemanticCite

Push — master ( 36ba73...9ed582 )

PreTextFormatterTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like