SemanticMediaWiki /
SemanticCite
| 1 | <?php |
||
| 20 | class PreTextFormatterTest extends \PHPUnit_Framework_TestCase { |
||
| 21 | |||
| 22 | use PHPUnitCompat; |
||
| 23 | |||
| 24 | const LF = "\n"; |
||
| 25 | |||
| 26 | public function testCanConstruct() { |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @dataProvider parametersProvider |
||
| 36 | */ |
||
| 37 | public function testFormat( $params ) { |
||
| 46 | |||
| 47 | /** |
||
| 48 | * @dataProvider parametersProvider |
||
| 49 | */ |
||
| 50 | public function testGetFormattedSciteFuncFrom( $params, $expected ) { |
||
| 59 | |||
| 60 | public function parametersProvider() { |
||
| 82 | |||
| 83 | } |
||
| 84 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.