SemanticMediaWiki / SemanticCite

src/Specials/CitableMetadata/HtmlResponseParserRenderer.php

Spacing +12 added lines, -12 removed lines

@@ -28,7 +28,7 @@ 
 	 *
 	 * @param ResponseParser $responseParser
 	 */
-	public function __construct( ResponseParser $responseParser ) {
+	public function __construct(ResponseParser $responseParser) {
 		$this->responseParser = $responseParser;
 	}
 
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param boolean $isReadOnly
 	 */
-	public function isReadOnly( $isReadOnly ) {
+	public function isReadOnly($isReadOnly) {
 		$this->isReadOnly = (bool)$isReadOnly;
 	}
 
@@ -46,13 +46,13 @@ 
 	 *
 	 * @return string
 	 */
-	public function getRawResponse( $id ) {
+	public function getRawResponse($id) {
 
-		if ( $id === '' ) {
+		if ($id === '') {
 			return '';
 		}
 
-		return $this->responseParser->getRawResponse( $id );
+		return $this->responseParser->getRawResponse($id);
 	}
 
 	/**
@@ -60,11 +60,11 @@ 
 	 *
 	 * @return string
 	 */
-	public function renderTextFor( $id ) {
+	public function renderTextFor($id) {
 
 		$html = '';
 
-		$this->responseParser->doFilterResponseFor( $id );
+		$this->responseParser->doFilterResponseFor($id);
 
 		$html .= Html::rawElement(
 			'div',
@@ -74,7 +74,7 @@ 
 			''
 		);
 
-		if ( $this->responseParser->getMessages() !== [] ) {
+		if ($this->responseParser->getMessages() !== []) {
 			return '';
 		}
 
@@ -82,7 +82,7 @@ 
 
 		// Only display the create button for when the DB can be actually
 		// accessed
-		if ( $this->isReadOnly === false ) {
+		if ($this->isReadOnly === false) {
 			$create = Html::element(
 				'a',
 				[
@@ -91,7 +91,7 @@ 
 					'data-content-selector' => '#scite-record-content',
 					'data-title' => $this->responseParser->getFilteredRecord()->getTitleForPageCreation()
 				],
-				wfMessage( 'sci-metadata-search-action-create' )->text()
+				wfMessage('sci-metadata-search-action-create')->text()
 			);
 		}
 
@@ -107,12 +107,12 @@ 
 					'class' => 'scite-highlight scite-action-button',
 					'data-content-selector' => '#scite-record-content'
 				],
-				wfMessage( 'sci-metadata-search-action-highlight' )->text()
+				wfMessage('sci-metadata-search-action-highlight')->text()
 			) . ' ' . $create
 		);
 
 		// To display the #scite on the generated page
-		$this->responseParser->getFilteredRecord()->set( '@show', 'true' );
+		$this->responseParser->getFilteredRecord()->set('@show', 'true');
 
 		$html .= Html::rawElement(
 			'div',

src/ParserFunctionFactory.php

Spacing +10 added lines, -10 removed lines

@@ -27,9 +27,9 @@ 
 	 *
 	 * @return array
 	 */
-	public function newSciteParserFunctionDefinition( NamespaceExaminer $namespaceExaminer, Options $options ) {
+	public function newSciteParserFunctionDefinition(NamespaceExaminer $namespaceExaminer, Options $options) {
 
-		$sciteParserFunctionDefinition = function( $parser ) use( $namespaceExaminer, $options ) {
+		$sciteParserFunctionDefinition = function($parser) use($namespaceExaminer, $options) {
 
 			$parserData = ApplicationFactory::getInstance()->newParserData(
 				$parser->getTitle(),
@@ -52,20 +52,20 @@ 
 				$namespaceExaminer,
 				$citationTextTemplateRenderer,
 				$mediaWikiNsContentMapper,
-				new BibtexProcessor( new BibtexParser(), new BibtexAuthorListParser() )
+				new BibtexProcessor(new BibtexParser(), new BibtexAuthorListParser())
 			);
 
 			$sciteParserFunction->setStrictParserValidationState(
-				$options->get( 'enabledStrictParserValidation' )
+				$options->get('enabledStrictParserValidation')
 			);
 
 			return $sciteParserFunction->doProcess(
-				ParameterProcessorFactory::newFromArray( func_get_args() ),
+				ParameterProcessorFactory::newFromArray(func_get_args()),
 				new PreTextFormatter()
 			);
 		};
 
-		return [ 'scite', $sciteParserFunctionDefinition, 0 ];
+		return ['scite', $sciteParserFunctionDefinition, 0];
 	}
 
 	/**
@@ -77,21 +77,21 @@ 
 	 */
 	public function newReferenceListParserFunctionDefinition() {
 
-		$referenceListParserFunctionDefinition = function( $parser ) {
+		$referenceListParserFunctionDefinition = function($parser) {
 
 			$parserData = ApplicationFactory::getInstance()->newParserData(
 				$parser->getTitle(),
 				$parser->getOutput()
 			);
 
-			$referenceListParserFunction = new ReferenceListParserFunction( $parserData );
+			$referenceListParserFunction = new ReferenceListParserFunction($parserData);
 
 			return $referenceListParserFunction->doProcess(
-				ParameterProcessorFactory::newFromArray( func_get_args() )
+				ParameterProcessorFactory::newFromArray(func_get_args())
 			);
 		};
 
-		return [ 'referencelist', $referenceListParserFunctionDefinition, 0 ];
+		return ['referencelist', $referenceListParserFunctionDefinition, 0];
 	}
 
 }

src/CacheKeyProvider.php

Spacing +5 added lines, -5 removed lines

@@ -26,7 +26,7 @@ 
 	 *
 	 * @param string $cachePrefix
 	 */
-	public function setCachePrefix( $cachePrefix ) {
+	public function setCachePrefix($cachePrefix) {
 		$this->cachePrefix = $cachePrefix;
 	}
 
@@ -37,8 +37,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getCacheKeyForCitationReference( $hash ) {
-		return $this->cachePrefix . ':sci:ref:' . md5( $hash . self::VERSION );
+	public function getCacheKeyForCitationReference($hash) {
+		return $this->cachePrefix . ':sci:ref:' . md5($hash . self::VERSION);
 	}
 
 	/**
@@ -48,8 +48,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getCacheKeyForReferenceList( $hash ) {
-		return $this->cachePrefix . ':sci:reflist:' . md5( $hash . self::VERSION );
+	public function getCacheKeyForReferenceList($hash) {
+		return $this->cachePrefix . ':sci:reflist:' . md5($hash . self::VERSION);
 	}
 
 }

src/MediaWikiNsContentMapper.php

Spacing +22 added lines, -22 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @param MediaWikiNsContentReader $mediaWikiNsContentReader
 	 */
-	public function __construct( MediaWikiNsContentReader $mediaWikiNsContentReader ) {
+	public function __construct(MediaWikiNsContentReader $mediaWikiNsContentReader) {
 		$this->mediaWikiNsContentReader = $mediaWikiNsContentReader;
 	}
 
@@ -59,11 +59,11 @@ 
 	 *
 	 * @return string
 	 */
-	public function findPropertyForId( $id ) {
+	public function findPropertyForId($id) {
 
-		$id = strtolower( trim( $id ) );
+		$id = strtolower(trim($id));
 
-		if ( self::$identifierToPropertyMap === [] ) {
+		if (self::$identifierToPropertyMap === []) {
 
 			// Fixed by definition due to usage of
 			// pre-defined properties
@@ -77,10 +77,10 @@ 
 				'reference'     => SCI_PROP_CITE_KEY,
 				'citation text' => SCI_PROP_CITE_TEXT,
 				'sortkey'       => '_SKEY'
-			] + $this->parseContentFor( "sci-property-definition" );
+			] + $this->parseContentFor("sci-property-definition");
 		}
 
-		return isset( self::$identifierToPropertyMap[$id] ) ? self::$identifierToPropertyMap[$id] : null;
+		return isset(self::$identifierToPropertyMap[$id]) ? self::$identifierToPropertyMap[$id] : null;
 	}
 
 	/**
@@ -90,48 +90,48 @@ 
 	 *
 	 * @return string
 	 */
-	public function findTemplateForType( $type ) {
+	public function findTemplateForType($type) {
 
-		$type = strtolower( trim( $type ) );
+		$type = strtolower(trim($type));
 
-		if ( self::$typeToTemplateMap === [] ) {
-			self::$typeToTemplateMap = $this->parseContentFor( "sci-template-definition" );
+		if (self::$typeToTemplateMap === []) {
+			self::$typeToTemplateMap = $this->parseContentFor("sci-template-definition");
 		}
 
-		return isset( self::$typeToTemplateMap[$type] ) ? self::$typeToTemplateMap[$type] : null;
+		return isset(self::$typeToTemplateMap[$type]) ? self::$typeToTemplateMap[$type] : null;
 	}
 
 	/**
 	 * @param string $name
 	 */
-	private function parseContentFor( $name ) {
+	private function parseContentFor($name) {
 
-		if ( self::$skipMessageCache ) {
+		if (self::$skipMessageCache) {
 			$this->mediaWikiNsContentReader->skipMessageCache();
 		}
 
-		$contents = (string)$this->mediaWikiNsContentReader->read( $name );
+		$contents = (string)$this->mediaWikiNsContentReader->read($name);
 
-		if ( $contents === '' ) {
+		if ($contents === '') {
 			return [];
 		}
 
-		$contentMap = array_map( 'trim', preg_split( "([\n][\s]?)", $contents ) );
+		$contentMap = array_map('trim', preg_split("([\n][\s]?)", $contents));
 		$list = [];
 
 		// Check whether the first line is infact an explanation
-		if ( strpos( $contentMap[0], '|' ) === false ) {
-			array_shift( $contentMap );
+		if (strpos($contentMap[0], '|') === false) {
+			array_shift($contentMap);
 		}
 
-		foreach ( $contentMap as $map ) {
+		foreach ($contentMap as $map) {
 
-			if ( strpos( $map, '|' ) === false ) {
+			if (strpos($map, '|') === false) {
 				continue;
 			}
 
-			list( $id, $value ) = explode( '|', $map, 2 );
-			$list[str_replace( '_', ' ', strtolower( trim( $id ) ) )] = $value;
+			list($id, $value) = explode('|', $map, 2);
+			$list[str_replace('_', ' ', strtolower(trim($id)))] = $value;
 		}
 
 		return $list;

src/CitationTextChangeUpdateJobDispatcher.php

Spacing +21 added lines, -21 removed lines

@@ -41,7 +41,7 @@ 
 	 * @param Store $store
 	 * @param ReferenceBacklinksLookup $referenceBacklinksLookup
 	 */
-	public function __construct( Store $store, ReferenceBacklinksLookup $referenceBacklinksLookup ) {
+	public function __construct(Store $store, ReferenceBacklinksLookup $referenceBacklinksLookup) {
 		$this->store = $store;
 		$this->referenceBacklinksLookup = $referenceBacklinksLookup;
 	}
@@ -51,7 +51,7 @@ 
 	 *
 	 * @param boolean $enabledUpdateJobState
 	 */
-	public function setEnabledUpdateJobState( $enabledUpdateJobState ) {
+	public function setEnabledUpdateJobState($enabledUpdateJobState) {
 		$this->enabledUpdateJobState = $enabledUpdateJobState;
 	}
 
@@ -63,21 +63,21 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function dispatchUpdateJobFor( DIWikiPage $subject, CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator ) {
+	public function dispatchUpdateJobFor(DIWikiPage $subject, CompositePropertyTableDiffIterator $compositePropertyTableDiffIterator) {
 
-		if ( !$this->enabledUpdateJobState ) {
+		if (!$this->enabledUpdateJobState) {
 			return false;
 		}
 
 		$tableName = $this->store->getPropertyTableInfoFetcher()->findTableIdForProperty(
-			new DIProperty( PropertyRegistry::SCI_CITE_TEXT )
+			new DIProperty(PropertyRegistry::SCI_CITE_TEXT)
 		);
 
 		$subjectIdList = $this->getSubjectListFrom(
-			$compositePropertyTableDiffIterator->getOrderedDiffByTable( $tableName )
+			$compositePropertyTableDiffIterator->getOrderedDiffByTable($tableName)
 		);
 
-		if ( ( $jobList = $this->getDispatchableTargetList( $subjectIdList ) ) === [] ) {
+		if (($jobList = $this->getDispatchableTargetList($subjectIdList)) === []) {
 			return false;
 		}
 
@@ -93,30 +93,30 @@ 
 		return true;
 	}
 
-	private function getSubjectListFrom( array $orderedDiff ) {
+	private function getSubjectListFrom(array $orderedDiff) {
 
 		$subjectIdList = [];
 
 		// Find out whether a cite text object was altered
-		foreach ( $orderedDiff as $key => $value ) {
+		foreach ($orderedDiff as $key => $value) {
 
-			if ( strpos( $key, 'sci_cite_text' ) === false ) {
+			if (strpos($key, 'sci_cite_text') === false) {
 				continue;
 			}
 
-			if ( !isset( $value['delete'] ) ) {
+			if (!isset($value['delete'])) {
 				$value['delete'] = [];
 			}
 
-			foreach ( $value['delete'] as $delete ) {
+			foreach ($value['delete'] as $delete) {
 				$subjectIdList[] = $delete['s_id'];
 			}
 
-			if ( !isset( $value['insert'] ) ) {
+			if (!isset($value['insert'])) {
 				$value['insert'] = [];
 			}
 
-			foreach ( $value['insert'] as $insert ) {
+			foreach ($value['insert'] as $insert) {
 				$subjectIdList[] = $insert['s_id'];
 			}
 		}
@@ -124,25 +124,25 @@ 
 		return $subjectIdList;
 	}
 
-	private function getDispatchableTargetList( array $subjectIdList ) {
+	private function getDispatchableTargetList(array $subjectIdList) {
 
-		if ( $subjectIdList === [] ) {
+		if ($subjectIdList === []) {
 			return [];
 		}
 
-		$hashList = $this->store->getObjectIds()->getDataItemPoolHashListFor( $subjectIdList );
+		$hashList = $this->store->getObjectIds()->getDataItemPoolHashListFor($subjectIdList);
 		$referenceBacklinks = [];
 
-		foreach ( $hashList as $hash ) {
+		foreach ($hashList as $hash) {
 			$referenceBacklinks += $this->referenceBacklinksLookup->findReferenceBacklinksFor(
-				$this->referenceBacklinksLookup->tryToFindCitationKeyFor( DIWikiPage::doUnserialize( $hash ) )
+				$this->referenceBacklinksLookup->tryToFindCitationKeyFor(DIWikiPage::doUnserialize($hash))
 			);
 		}
 
 		$targetBatch = [];
 
-		foreach ( $referenceBacklinks as $referenceBacklink ) {
-			$targetBatch[HashBuilder::getHashIdForDiWikiPage( $referenceBacklink )] = true;
+		foreach ($referenceBacklinks as $referenceBacklink) {
+			$targetBatch[HashBuilder::getHashIdForDiWikiPage($referenceBacklink)] = true;
 		}
 
 		return $targetBatch;

src/SciteParserFunction.php

Spacing +53 added lines, -53 removed lines

@@ -74,7 +74,7 @@ 
 	 * @param MediaWikiNsContentMapper $mediaWikiNsContentMapper
 	 * @param BibtexProcessor $bibtexProcessor
 	 */
-	public function __construct( ParserData $parserData, NamespaceExaminer $namespaceExaminer, CitationTextTemplateRenderer $citationTextTemplateRenderer, MediaWikiNsContentMapper $mediaWikiNsContentMapper, BibtexProcessor $bibtexProcessor ) {
+	public function __construct(ParserData $parserData, NamespaceExaminer $namespaceExaminer, CitationTextTemplateRenderer $citationTextTemplateRenderer, MediaWikiNsContentMapper $mediaWikiNsContentMapper, BibtexProcessor $bibtexProcessor) {
 		$this->parserData = $parserData;
 		$this->namespaceExaminer = $namespaceExaminer;
 		$this->citationTextTemplateRenderer = $citationTextTemplateRenderer;
@@ -88,7 +88,7 @@ 
 	 *
 	 * @param boolean $strictParserValidationState
 	 */
-	public function setStrictParserValidationState ( $strictParserValidationState ) {
+	public function setStrictParserValidationState($strictParserValidationState) {
 		$this->strictParserValidationState = (bool)$strictParserValidationState;
 	}
 
@@ -143,28 +143,28 @@ 
 	 *
 	 * @param ParserParameterProcessor $parserParameterProcessor
 	 */
-	public function doProcess( ParserParameterProcessor $parserParameterProcessor, PreTextFormatter $preTextFormatter = null ) {
+	public function doProcess(ParserParameterProcessor $parserParameterProcessor, PreTextFormatter $preTextFormatter = null) {
 
-		if ( !$this->namespaceExaminer->isSemanticEnabled( $this->parserData->getTitle()->getNamespace() ) ) {
-			return $this->createErrorMessageFor( 'sci-scite-parser-not-enabled-namespace' );
+		if (!$this->namespaceExaminer->isSemanticEnabled($this->parserData->getTitle()->getNamespace())) {
+			return $this->createErrorMessageFor('sci-scite-parser-not-enabled-namespace');
 		}
 
 		// Hopefully the bibtex processor will add all required parameters and values
-		if ( $parserParameterProcessor->hasParameter( 'bibtex' ) ) {
-			$this->bibtexProcessor->doProcess( $parserParameterProcessor );
+		if ($parserParameterProcessor->hasParameter('bibtex')) {
+			$this->bibtexProcessor->doProcess($parserParameterProcessor);
 		}
 
-		$reference = str_replace( '_', ' ', (string)$parserParameterProcessor->getFirstParameter() );
+		$reference = str_replace('_', ' ', (string)$parserParameterProcessor->getFirstParameter());
 		$type = '';
 
 		// Explicit reference precedes
-		if ( $parserParameterProcessor->hasParameter( 'reference' ) ) {
-			$reference = $parserParameterProcessor->getParameterValuesFor( 'reference' );
-			$reference = end( $reference );
+		if ($parserParameterProcessor->hasParameter('reference')) {
+			$reference = $parserParameterProcessor->getParameterValuesFor('reference');
+			$reference = end($reference);
 		}
 
-		if ( $reference === '' ) {
-			return $this->createErrorMessageFor( 'sci-scite-parser-no-reference' );
+		if ($reference === '') {
+			return $this->createErrorMessageFor('sci-scite-parser-no-reference');
 		}
 
 		// Fixed identifier
@@ -173,10 +173,10 @@ 
 			$reference
 		);
 
-		if ( $parserParameterProcessor->hasParameter( 'type' ) ) {
-			$type = $parserParameterProcessor->getParameterValuesFor( 'type' );
-			sort( $type );
-			$type = end( $type );
+		if ($parserParameterProcessor->hasParameter('type')) {
+			$type = $parserParameterProcessor->getParameterValuesFor('type');
+			sort($type);
+			$type = end($type);
 		}
 
 		$returnText = $this->tryToMatchCitationTextByPrecept(
@@ -197,125 +197,125 @@ 
 		// placed next to each other, have the first occurrence to mark its
 		// existence explicitly by outputting an empty paragraph and so avoid a
 		// <br> element.
-		if ( $returnText === '' && $this->parserData->getOutput()->getExtensionData( 'sci-parserfunction' ) === null ) {
-			$this->parserData->getOutput()->setExtensionData( 'sci-parserfunction', true );
+		if ($returnText === '' && $this->parserData->getOutput()->getExtensionData('sci-parserfunction') === null) {
+			$this->parserData->getOutput()->setExtensionData('sci-parserfunction', true);
 			$returnText = '<p></p>';
 		}
 
-		if ( $parserParameterProcessor->hasParameter( '@show' ) && $preTextFormatter !== null ) {
-			$returnText = $preTextFormatter->getFormattedSciteFuncFrom( $parserParameterProcessor->getRaw() ) . $returnText;
+		if ($parserParameterProcessor->hasParameter('@show') && $preTextFormatter !== null) {
+			$returnText = $preTextFormatter->getFormattedSciteFuncFrom($parserParameterProcessor->getRaw()) . $returnText;
 		}
 
 		return $returnText; //array( '', 'noparse' => true, 'isHTML' => true );
 	}
 
-	private function tryToMatchCitationTextByPrecept( ParserParameterProcessor $parserParameterProcessor, $reference, $type = '' ) {
+	private function tryToMatchCitationTextByPrecept(ParserParameterProcessor $parserParameterProcessor, $reference, $type = '') {
 
 		$template = '';
 
-		if ( $this->strictParserValidationState && $type === '' ) {
+		if ($this->strictParserValidationState && $type === '') {
 
 			$parserParameterProcessor->addParameter(
 				DIProperty::TYPE_ERROR,
 				PropertyRegistry::SCI_CITE
 			);
 
-			return $this->createErrorMessageFor( 'sci-scite-parser-no-type', $reference );
+			return $this->createErrorMessageFor('sci-scite-parser-no-type', $reference);
 		}
 
 		// An injected text trumps a template
-		if ( $parserParameterProcessor->hasParameter( 'citation text' ) ) {
+		if ($parserParameterProcessor->hasParameter('citation text')) {
 			return '';
 		}
 
 		// An explicit template precedes the assignment found for the type
-		if ( $parserParameterProcessor->hasParameter( 'template' ) ) {
-			$template = $parserParameterProcessor->getParameterValuesFor( 'template' );
-			$template = trim( end( $template ) );
-		} elseif ( $this->mediaWikiNsContentMapper->findTemplateForType( $type ) !== null ) {
-			$template = $this->mediaWikiNsContentMapper->findTemplateForType( $type );
+		if ($parserParameterProcessor->hasParameter('template')) {
+			$template = $parserParameterProcessor->getParameterValuesFor('template');
+			$template = trim(end($template));
+		} elseif ($this->mediaWikiNsContentMapper->findTemplateForType($type) !== null) {
+			$template = $this->mediaWikiNsContentMapper->findTemplateForType($type);
 		}
 
-		if ( $template !== '' ) {
-			$this->citationTextTemplateRenderer->packFieldsForTemplate( $template );
+		if ($template !== '') {
+			$this->citationTextTemplateRenderer->packFieldsForTemplate($template);
 
 			// Fixed identifier
 			$parserParameterProcessor->addParameter(
 				'citation text',
-				$this->citationTextTemplateRenderer->renderFor( $parserParameterProcessor->toArray() )
+				$this->citationTextTemplateRenderer->renderFor($parserParameterProcessor->toArray())
 			);
-		} elseif ( $this->strictParserValidationState ) {
+		} elseif ($this->strictParserValidationState) {
 
 			$parserParameterProcessor->addParameter(
 				DIProperty::TYPE_ERROR,
 				PropertyRegistry::SCI_CITE_TEXT
 			);
 
-			return $this->createErrorMessageFor( 'sci-scite-parser-no-citation-text', $reference, $type );
+			return $this->createErrorMessageFor('sci-scite-parser-no-citation-text', $reference, $type);
 		}
 
 		return '';
 	}
 
-	private function addPropertyValuesFor( ParserParameterProcessor $parserParameterProcessor, $reference ) {
+	private function addPropertyValuesFor(ParserParameterProcessor $parserParameterProcessor, $reference) {
 
-		$subobject = new Subobject( $this->parserData->getTitle() );
-		$subobject->setEmptyContainerForId( '_SCITE' . md5( $reference ) );
+		$subobject = new Subobject($this->parserData->getTitle());
+		$subobject->setEmptyContainerForId('_SCITE' . md5($reference));
 
 		$subject = $this->parserData->getSemanticData()->getSubject();
 
-		foreach ( $parserParameterProcessor->toArray() as $key => $values ) {
+		foreach ($parserParameterProcessor->toArray() as $key => $values) {
 
-			if ( $key === DIProperty::TYPE_ERROR ) {
+			if ($key === DIProperty::TYPE_ERROR) {
 
-				$value = new DIProperty( end( $values ) );
+				$value = new DIProperty(end($values));
 
 				$subobject->getSemanticData()->addPropertyObjectValue(
-					new DIProperty( DIProperty::TYPE_ERROR ),
+					new DIProperty(DIProperty::TYPE_ERROR),
 					$value->getDiWikiPage()
 				);
 
 				continue;
 			}
 
-			$property = $this->mediaWikiNsContentMapper->findPropertyForId( $key );
+			$property = $this->mediaWikiNsContentMapper->findPropertyForId($key);
 
 			// No mapping, no annotation
-			if ( $property === null ) {
+			if ($property === null) {
 				continue;
 			}
 
-			foreach ( $values as $value ) {
+			foreach ($values as $value) {
 
 				$dataValue = $this->dataValueFactory->newPropertyValue(
 						$property,
-						trim( $value ),
+						trim($value),
 						false,
 						$subject
 					);
 
-				$subobject->addDataValue( $dataValue );
+				$subobject->addDataValue($dataValue);
 			}
 		}
 
-		if ( $subobject->getSemanticData()->isEmpty() ) {
+		if ($subobject->getSemanticData()->isEmpty()) {
 			return;
 		}
 
 		$this->parserData->getSemanticData()->addPropertyObjectValue(
-			new DIProperty( PropertyRegistry::SCI_CITE ),
+			new DIProperty(PropertyRegistry::SCI_CITE),
 			$subobject->getContainer()
 		);
 
-		$this->parserData->getSubject()->setContextReference( 'scitep:' . uniqid() );
+		$this->parserData->getSubject()->setContextReference('scitep:' . uniqid());
 		$this->parserData->pushSemanticDataToParserOutput();
 	}
 
-	private function createErrorMessageFor( $messageKey, $arg1 = '',  $arg2 = '' ) {
+	private function createErrorMessageFor($messageKey, $arg1 = '', $arg2 = '') {
 		return \Html::rawElement(
 			'div',
-			[ 'class' => 'smw-callout smw-callout-error' ],
-			wfMessage( $messageKey, $arg1, $arg2 )->inContentLanguage()->text()
+			['class' => 'smw-callout smw-callout-error'],
+			wfMessage($messageKey, $arg1, $arg2)->inContentLanguage()->text()
 		);
 	}
 

src/HookRegistry.php

Spacing +71 added lines, -71 removed lines

@@ -40,7 +40,7 @@ 
 	 * @param Cache $cache
 	 * @param Options $options
 	 */
-	public function __construct( Store $store, Cache $cache, Options $options ) {
+	public function __construct(Store $store, Cache $cache, Options $options) {
 		$this->options = $options;
 
 		$this->addCallbackHandlers(
@@ -58,8 +58,8 @@ 
 	 * @param string $key
 	 * @param mixed $value
 	 */
-	public function setOption( $key, $value ) {
-		$this->options->set( $key, $value );
+	public function setOption($key, $value) {
+		$this->options->set($key, $value);
 	}
 
 	/**
@@ -69,8 +69,8 @@ 
 	 *
 	 * @return boolean
 	 */
-	public function isRegistered( $name ) {
-		return Hooks::isRegistered( $name );
+	public function isRegistered($name) {
+		return Hooks::isRegistered($name);
 	}
 
 	/**
@@ -78,17 +78,17 @@ 
 	 */
 	public function clear() {
 
-		if ( !defined( 'MW_PHPUNIT_TEST' ) ) {
+		if (!defined('MW_PHPUNIT_TEST')) {
 			return;
 		}
 
-		foreach ( $this->handlers as $name => $callback ) {
+		foreach ($this->handlers as $name => $callback) {
 			if (
-				!class_exists( '\MediaWiki\MediaWikiServices' ) ||
-				!method_exists( \MediaWiki\MediaWikiServices::getInstance(), 'getHookContainer' ) ) {
-				\Hooks::clear( $name );
+				!class_exists('\MediaWiki\MediaWikiServices') ||
+				!method_exists(\MediaWiki\MediaWikiServices::getInstance(), 'getHookContainer') ) {
+				\Hooks::clear($name);
 			} else {
-				\MediaWiki\MediaWikiServices::getInstance()->getHookContainer()->clear( $name );
+				\MediaWiki\MediaWikiServices::getInstance()->getHookContainer()->clear($name);
 			}
 		}
 	}
@@ -100,8 +100,8 @@ 
 	 *
 	 * @return Callable|false
 	 */
-	public function getHandlerFor( $name ) {
-		return isset( $this->handlers[$name] ) ? $this->handlers[$name] : false;
+	public function getHandlerFor($name) {
+		return isset($this->handlers[$name]) ? $this->handlers[$name] : false;
 	}
 
 	/**
@@ -113,13 +113,13 @@ 
 		//	return;
 		//}
 
-		foreach ( $this->handlers as $name => $callback ) {
+		foreach ($this->handlers as $name => $callback) {
 			if (
-				!class_exists( '\MediaWiki\MediaWikiServices' ) ||
-				!method_exists( \MediaWiki\MediaWikiServices::getInstance(), 'getHookContainer' ) ) {
-				\Hooks::register( $name, $callback );
+				!class_exists('\MediaWiki\MediaWikiServices') ||
+				!method_exists(\MediaWiki\MediaWikiServices::getInstance(), 'getHookContainer') ) {
+				\Hooks::register($name, $callback);
 			} else {
-				\MediaWiki\MediaWikiServices::getInstance()->getHookContainer()->register( $name, $callback );
+				\MediaWiki\MediaWikiServices::getInstance()->getHookContainer()->register($name, $callback);
 			}
 		}
 	}
@@ -129,16 +129,16 @@ 
 	 *
 	 * @param array &$config
 	 */
-	public static function onBeforeConfigCompletion( &$config ) {
+	public static function onBeforeConfigCompletion(&$config) {
 
-		if ( !isset( $config['smwgFulltextSearchPropertyExemptionList'] ) ) {
+		if (!isset($config['smwgFulltextSearchPropertyExemptionList'])) {
 			return;
 		}
 
 		// Exclude those properties from indexing
 		$config['smwgFulltextSearchPropertyExemptionList'] = array_merge(
 			$config['smwgFulltextSearchPropertyExemptionList'],
-			[ PropertyRegistry::SCI_CITE ]
+			[PropertyRegistry::SCI_CITE]
 		);
 	}
 
@@ -147,14 +147,14 @@ 
 	 */
 	public static function initExtension() {
 
-		$GLOBALS['wgHooks']['SMW::Config::BeforeCompletion'][] = function( &$config ) {
+		$GLOBALS['wgHooks']['SMW::Config::BeforeCompletion'][] = function(&$config) {
 
 			$exemptionlist = [
 				PropertyRegistry::SCI_CITE
 			];
 
 			// Exclude listed properties from indexing
-			if ( isset( $config['smwgFulltextSearchPropertyExemptionList'] ) ) {
+			if (isset($config['smwgFulltextSearchPropertyExemptionList'])) {
 				$config['smwgFulltextSearchPropertyExemptionList'] = array_merge(
 					$config['smwgFulltextSearchPropertyExemptionList'],
 					$exemptionlist
@@ -165,7 +165,7 @@ 
 			// selected object would trigger an automatic change without the necessary
 			// human intervention and can therefore produce unwanted query updates
 
-			if ( isset( $config['smwgQueryDependencyPropertyExemptionList'] ) ) {
+			if (isset($config['smwgQueryDependencyPropertyExemptionList'])) {
 				$config['smwgQueryDependencyPropertyExemptionList'] = array_merge(
 					$config['smwgQueryDependencyPropertyExemptionList'],
 					$exemptionlist
@@ -194,7 +194,7 @@ 
 			'_sci_olid'
 		];
 
-		foreach ( $types as $type ) {
+		foreach ($types as $type) {
 			$dataTypeRegistry->registerDatatype(
 				$type,
 				'\SCI\DataValues\ResourceIdentifierStringValue',
@@ -207,8 +207,8 @@ 
 		};
 
 		// SMW 3.1+
-		if ( method_exists( $dataTypeRegistry, 'registerCallable' ) ) {
-			$dataTypeRegistry->registerCallable( '_sci_ref', 'sci.citationreferencepositionjournal', $callback );
+		if (method_exists($dataTypeRegistry, 'registerCallable')) {
+			$dataTypeRegistry->registerCallable('_sci_ref', 'sci.citationreferencepositionjournal', $callback);
 		} else {
 			$dataTypeRegistry->registerExtraneousFunction(
 				'\SCI\CitationReferencePositionJournal',
@@ -219,40 +219,40 @@ 
 		return true;
 	}
 
-	private function addCallbackHandlers( $store, $cache, $options ) {
+	private function addCallbackHandlers($store, $cache, $options) {
 
 		$propertyRegistry = new PropertyRegistry();
 		$namespaceExaminer = ApplicationFactory::getInstance()->getNamespaceExaminer();
 
 		$cacheKeyProvider = new CacheKeyProvider();
-		$cacheKeyProvider->setCachePrefix( $options->get( 'cachePrefix' ) );
+		$cacheKeyProvider->setCachePrefix($options->get('cachePrefix'));
 
 		$this->citationReferencePositionJournal = new CitationReferencePositionJournal(
 			$cache,
 			$cacheKeyProvider
 		);
 
-		$referenceBacklinksLookup = new ReferenceBacklinksLookup( $store );
+		$referenceBacklinksLookup = new ReferenceBacklinksLookup($store);
 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks/SMW::Property::initProperties
 		 */
-		$this->handlers['SMW::Property::initProperties'] = function ( $corePropertyRegistry ) use ( $propertyRegistry ) {
-			return $propertyRegistry->registerTo( $corePropertyRegistry );
+		$this->handlers['SMW::Property::initProperties'] = function($corePropertyRegistry) use ($propertyRegistry) {
+			return $propertyRegistry->registerTo($corePropertyRegistry);
 		};
 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks/SMW::DataType::initTypes
 		 */
-		$this->handlers['SMW::DataType::initTypes'] = [ $this, 'onDataTypeInit' ];
+		$this->handlers['SMW::DataType::initTypes'] = [$this, 'onDataTypeInit'];
 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks/SMW::Browse::AfterIncomingPropertiesLookupComplete
 		 */
-		$this->handlers['SMW::Browse::AfterIncomingPropertiesLookupComplete'] = function ( $store, $semanticData, $requestOptions ) use ( $referenceBacklinksLookup ) {
+		$this->handlers['SMW::Browse::AfterIncomingPropertiesLookupComplete'] = function($store, $semanticData, $requestOptions) use ($referenceBacklinksLookup) {
 
-			$referenceBacklinksLookup->setRequestOptions( $requestOptions );
-			$referenceBacklinksLookup->setStore( $store );
+			$referenceBacklinksLookup->setRequestOptions($requestOptions);
+			$referenceBacklinksLookup->setStore($store);
 
 			$referenceBacklinksLookup->addReferenceBacklinksTo(
 				$semanticData
@@ -261,22 +261,22 @@ 
 			return true;
 		};
 
-		$this->handlers['SMW::Browse::BeforeIncomingPropertyValuesFurtherLinkCreate'] = function ( $property, $subject, &$html ) use ( $referenceBacklinksLookup ) {
-			return $referenceBacklinksLookup->getSpecialPropertySearchFurtherLink( $property, $subject, $html );
+		$this->handlers['SMW::Browse::BeforeIncomingPropertyValuesFurtherLinkCreate'] = function($property, $subject, &$html) use ($referenceBacklinksLookup) {
+			return $referenceBacklinksLookup->getSpecialPropertySearchFurtherLink($property, $subject, $html);
 		};
 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks/SMW::Parser::BeforeMagicWordsFinder
 		 */
-		$this->handlers['SMW::Parser::BeforeMagicWordsFinder'] = function( array &$magicWords ) {
-			$magicWords = array_merge( $magicWords, [ 'SCI_NOREFERENCELIST' ] );
+		$this->handlers['SMW::Parser::BeforeMagicWordsFinder'] = function(array &$magicWords) {
+			$magicWords = array_merge($magicWords, ['SCI_NOREFERENCELIST']);
 			return true;
 		};
 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks/SMW::SQLStore::AddCustomFixedPropertyTables
 		 */
-		$this->handlers['SMW::SQLStore::AddCustomFixedPropertyTables'] = function( array &$customFixedProperties ) use( $propertyRegistry ) {
+		$this->handlers['SMW::SQLStore::AddCustomFixedPropertyTables'] = function(array &$customFixedProperties) use($propertyRegistry) {
 
 			$properties = [
 				$propertyRegistry::SCI_CITE_KEY,
@@ -291,8 +291,8 @@ 
 				$propertyRegistry::SCI_OLID
 			];
 
-			foreach ( $properties as $property ) {
-				$customFixedProperties[$property] = str_replace( '__', '_', $property );
+			foreach ($properties as $property) {
+				$customFixedProperties[$property] = str_replace('__', '_', $property);
 			}
 
 			return true;
@@ -301,13 +301,13 @@ 
 		/**
 		 * @see https://www.mediawiki.org/wiki/Manual:Hooks/BeforePageDisplay
 		 */
-		$this->handlers['BeforePageDisplay'] = function ( &$outputPage, &$skin ) use( $namespaceExaminer ) {
+		$this->handlers['BeforePageDisplay'] = function(&$outputPage, &$skin) use($namespaceExaminer) {
 
-			if ( !$namespaceExaminer->isSemanticEnabled( $outputPage->getTitle()->getNamespace() ) ) {
+			if (!$namespaceExaminer->isSemanticEnabled($outputPage->getTitle()->getNamespace())) {
 				return true;
 			}
 
-			$outputPage->addModuleStyles( 'ext.scite.styles' );
+			$outputPage->addModuleStyles('ext.scite.styles');
 
 			$outputPage->addModules(
 				[
@@ -325,15 +325,15 @@ 
 		 *
 		 * @see https://www.mediawiki.org/wiki/Manual:Hooks/OutputPageParserOutput
 		 */
-		$this->handlers['OutputPageParserOutput'] = function( &$outputPage, $parserOutput ) {
-			$outputPage->smwmagicwords = $parserOutput->getExtensionData( 'smwmagicwords' );
+		$this->handlers['OutputPageParserOutput'] = function(&$outputPage, $parserOutput) {
+			$outputPage->smwmagicwords = $parserOutput->getExtensionData('smwmagicwords');
 			return true;
 		};
 
 		/**
 		 * @see https://www.mediawiki.org/wiki/Manual:Hooks/OutputPageBeforeHTML
 		 */
-		$this->handlers['OutputPageBeforeHTML'] = function( &$outputPage, &$text ) use ( $store, $namespaceExaminer, $cache, $cacheKeyProvider, $options ) {
+		$this->handlers['OutputPageBeforeHTML'] = function(&$outputPage, &$text) use ($store, $namespaceExaminer, $cache, $cacheKeyProvider, $options) {
 
 			$referenceListFactory = new ReferenceListFactory(
 				$store,
@@ -342,13 +342,13 @@ 
 			);
 
 			$cachedReferenceListOutputRenderer = $referenceListFactory->newCachedReferenceListOutputRenderer(
-				new MediaWikiContextInteractor( $outputPage->getContext() ),
+				new MediaWikiContextInteractor($outputPage->getContext()),
 				$cache,
 				$cacheKeyProvider,
 				$options
 			);
 
-			$cachedReferenceListOutputRenderer->addReferenceListToText( $text );
+			$cachedReferenceListOutputRenderer->addReferenceListToText($text);
 
 			return true;
 		};
@@ -356,7 +356,7 @@ 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks#SMWStore::updateDataBefore
 		 */
-		$this->handlers['SMWStore::updateDataBefore'] = function ( $store, $semanticData ) use ( $cache, $cacheKeyProvider ) {
+		$this->handlers['SMWStore::updateDataBefore'] = function($store, $semanticData) use ($cache, $cacheKeyProvider) {
 
 			$hash = $semanticData->getSubject()->getHash();
 
@@ -364,14 +364,14 @@ 
 			// more because as long as a CiteRef exists, CitationReferencePositionJournal
 			// is able recompute and update the entries but with no CiteRef left
 			// the last entry will remain and needs to be purged at this point
-			if ( !$this->citationReferencePositionJournal->hasCitationReference( $semanticData ) ) {
+			if (!$this->citationReferencePositionJournal->hasCitationReference($semanticData)) {
 				$cache->delete(
-					$cacheKeyProvider->getCacheKeyForCitationReference( $hash )
+					$cacheKeyProvider->getCacheKeyForCitationReference($hash)
 				);
 			}
 
 			$cache->delete(
-				$cacheKeyProvider->getCacheKeyForReferenceList( $hash )
+				$cacheKeyProvider->getCacheKeyForReferenceList($hash)
 			);
 
 			return true;
@@ -380,16 +380,16 @@ 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks#SMW::SQLStore::AfterDeleteSubjectComplete
 		 */
-		$this->handlers['SMW::SQLStore::AfterDeleteSubjectComplete'] = function ( $store, $title ) use ( $cache, $cacheKeyProvider ) {
+		$this->handlers['SMW::SQLStore::AfterDeleteSubjectComplete'] = function($store, $title) use ($cache, $cacheKeyProvider) {
 
-			$hash = DIWikiPage::newFromTitle( $title )->getHash();
+			$hash = DIWikiPage::newFromTitle($title)->getHash();
 
 			$cache->delete(
-				$cacheKeyProvider->getCacheKeyForCitationReference( $hash )
+				$cacheKeyProvider->getCacheKeyForCitationReference($hash)
 			);
 
 			$cache->delete(
-				$cacheKeyProvider->getCacheKeyForReferenceList( $hash )
+				$cacheKeyProvider->getCacheKeyForReferenceList($hash)
 			);
 
 			return true;
@@ -398,9 +398,9 @@ 
 		/**
 		 * @see https://www.semantic-mediawiki.org/wiki/Hooks#SMW::SQLStore::AfterDataUpdateComplete
 		 */
-		$this->handlers['SMW::SQLStore::AfterDataUpdateComplete'] = function ( $store, $semanticData, $compositePropertyTableDiffIterator ) use ( $referenceBacklinksLookup, $options ) {
+		$this->handlers['SMW::SQLStore::AfterDataUpdateComplete'] = function($store, $semanticData, $compositePropertyTableDiffIterator) use ($referenceBacklinksLookup, $options) {
 
-			$referenceBacklinksLookup->setStore( $store );
+			$referenceBacklinksLookup->setStore($store);
 
 			$citationTextChangeUpdateJobDispatcher = new CitationTextChangeUpdateJobDispatcher(
 				$store,
@@ -408,7 +408,7 @@ 
 			);
 
 			$citationTextChangeUpdateJobDispatcher->setEnabledUpdateJobState(
-				$options->get( 'enabledCitationTextChangeUpdateJob' )
+				$options->get('enabledCitationTextChangeUpdateJob')
 			);
 
 			$citationTextChangeUpdateJobDispatcher->dispatchUpdateJobFor(
@@ -422,12 +422,12 @@ 
 		/**
 		 * @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderGetConfigVars
 		 */
-		$this->handlers['ResourceLoaderGetConfigVars'] = function ( &$vars ) use ( $options ) {
+		$this->handlers['ResourceLoaderGetConfigVars'] = function(&$vars) use ($options) {
 
 			$vars['ext.scite.config'] = [
-				'showTooltipForCitationReference' => $options->get( 'showTooltipForCitationReference' ),
-				'tooltipRequestCacheTTL' => $options->get( 'tooltipRequestCacheTTL' ),
-				'cachePrefix' => $options->get( 'cachePrefix' )
+				'showTooltipForCitationReference' => $options->get('showTooltipForCitationReference'),
+				'tooltipRequestCacheTTL' => $options->get('tooltipRequestCacheTTL'),
+				'cachePrefix' => $options->get('cachePrefix')
 			];
 
 			return true;
@@ -436,20 +436,20 @@ 
 		/**
 		 * @see https://www.mediawiki.org/wiki/Manual:Hooks/ParserFirstCallInit
 		 */
-		$this->handlers['ParserFirstCallInit'] = function ( &$parser ) use ( $namespaceExaminer, $options ) {
+		$this->handlers['ParserFirstCallInit'] = function(&$parser) use ($namespaceExaminer, $options) {
 
 			$parserFunctionFactory = new ParserFunctionFactory();
 
-			list( $name, $definition, $flag ) = $parserFunctionFactory->newSciteParserFunctionDefinition(
+			list($name, $definition, $flag) = $parserFunctionFactory->newSciteParserFunctionDefinition(
 				$namespaceExaminer,
 				$options
 			);
 
-			$parser->setFunctionHook( $name, $definition, $flag );
+			$parser->setFunctionHook($name, $definition, $flag);
 
-			list( $name, $definition, $flag ) = $parserFunctionFactory->newReferenceListParserFunctionDefinition();
+			list($name, $definition, $flag) = $parserFunctionFactory->newReferenceListParserFunctionDefinition();
 
-			$parser->setFunctionHook( $name, $definition, $flag );
+			$parser->setFunctionHook($name, $definition, $flag);
 
 			return true;
 		};

i18n/SemanticCite.alias.php

Spacing +2 added lines, -2 removed lines

@@ -11,10 +11,10 @@
 
 /** English (English) */
 $specialPageAliases['en'] = [
-	'FindCitableMetadata' => [ 'FindCitableMetadata', 'FindMetadataById' ]
+	'FindCitableMetadata' => ['FindCitableMetadata', 'FindMetadataById']
 ];
 
 /** German (Deutsch) */
 $specialPageAliases['de'] = [
-	'FindCitableMetadata' => [ 'Metadatensuche_nach_Identifizierungskennung' ]
+	'FindCitableMetadata' => ['Metadatensuche_nach_Identifizierungskennung']
 ];

i18n/SemanticCite.magic.php

Spacing +5 added lines, -5 removed lines

@@ -9,15 +9,15 @@
  * English (English)
  */
 $magicWords['en'] = [
-	'scite' => [ 0, 'scite' ],
-	'referencelist' => [ 0, 'referencelist' ],
-	'SCI_NOREFERENCELIST' => [ 0, '__NOREFERENCELIST__' ]
+	'scite' => [0, 'scite'],
+	'referencelist' => [0, 'referencelist'],
+	'SCI_NOREFERENCELIST' => [0, '__NOREFERENCELIST__']
 ];
 
 /**
  * German (Deutsch)
  */
 $magicWords['de'] = [
-	'referencelist' => [ 0, 'referenzierungen' ],
-	'SCI_NOREFERENCELIST' => [ 0, '__KEINE_REFERENZIERUNGEN__', '__KEINEREFERENZIERUNGEN__' ]
+	'referencelist' => [0, 'referenzierungen'],
+	'SCI_NOREFERENCELIST' => [0, '__KEINE_REFERENZIERUNGEN__', '__KEINEREFERENZIERUNGEN__']
 ];