BibtexParserTest::bibtextProvider() - Code Metrics - Inspection of "Add CI for MW 1.41" - SemanticMediaWiki/SemanticCite - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#136)

by None

created 2024-12-31 15:06 UTC

BibtexParserTest::bibtextProvider() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines

109

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	109
rs	8
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace SCI\Tests\Bibtex;

use SCI\Bibtex\BibtexParser;

/**
 * @covers \SCI\Bibtex\BibtexParser
 * @group semantic-cite
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class BibtexParserTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$this->assertInstanceOf(
			'\SCI\Bibtex\BibtexParser',
			new BibtexParser()
		);
	}

	/**
	 * @dataProvider bibtextProvider
	 */
	public function testParse( $bibtex, $expected ) {

		$instance = new BibtexParser();

		$this->assertEquals(
			$expected,
			$instance->parse( $bibtex )
		);
	}

	public function bibtextProvider() {

		$provider[] = [
			"@article{einstein1935can,
			  title={Can quantum-mechanical description of physical reality be considered complete?},
			  author={Einstein, Albert and Podolsky, Boris and Rosen, Nathan},
			  journal={Physical review},
			  volume={47},
			  number={10},
			  pages={777},
			  year={1935},
			  publisher={APS}
			}",
			[
				'type'      => 'article',
				'reference' => 'einstein1935can',
				'title'     => 'Can quantum-mechanical description of physical reality be considered complete?',
				'author'    => 'Einstein, Albert and Podolsky, Boris and Rosen, Nathan',
				'journal'   => 'Physical review',
				'volume'    => '47',
				'number'    => '10',
				'pages'     => '777',
				'year'      => '1935',
				'publisher' => 'APS'
			]
		];

		$provider[] = [
			"@book{marx2004capital,
			  title={Capital (Volume 1: A Critique of Political Economy): A Critique of Political Economy},
			  author={Marx, Karl},
			  year={2004},
			  publisher={Digireads. com Publishing}
			}",
			[
				'type'      => 'book',
				'reference' => 'marx2004capital',
				'title'     => 'Capital (Volume 1: A Critique of Political Economy): A Critique of Political Economy',
				'author'    => 'Marx, Karl',
				'year'      => '2004',
				'publisher' => 'Digireads. com Publishing'
			]
		];

		#2 No reference
		$provider[] = [
			"@article{,
			  title={Vascular endothelial growth factor is a secreted angiogenic mitogen},
			  author={Leung, David W and Cachianes, George and Kuang, Wun-Jing and Goeddel, David V and Ferrara, Napoleone},
			  journal={Science},
			  volume={246},
			  number={4935},
			  pages={1306--1309},
			  year={1989},
			  publisher={American Association for the Advancement of Science}
			}",
			[
				'type'      => 'article',
				'reference' => '',
				'title'     => 'Vascular endothelial growth factor is a secreted angiogenic mitogen',
				'author'    => 'Leung, David W and Cachianes, George and Kuang, Wun-Jing and Goeddel, David V and Ferrara, Napoleone',
				'journal'   => 'Science',
				'volume'    => '246',
				'number'    => '4935',
				'pages'     => '1306--1309',
				'year'      => '1989',
				'publisher' => 'American Association for the Advancement of Science'
			]
		];

		#3 No reference
		$provider[] = [
			"@inproceedings{clean,
			  author = {First Author and Author, Second},
			  title = {Pr{\"a}diktive Teilbandcodierung mit Vektorquantisierung f{\"u}r hochqualitative Audiosignale},
			  booktitle = {8. ITG-Fachtagung H{\"o}rrundfunk},
			  year = {1988},
			  month = nov,
			  pages = {252--256},
			  abstract = {Some Abstract, across
			two lines},
			}",
			[
				'type'      => 'inproceedings',
				'reference' => 'clean',
				'author'    => 'First Author and Author, Second',
				'title'     => 'Pr{"a}diktive Teilbandcodierung mit Vektorquantisierung f{"u}r hochqualitative Audiosignale',
				'booktitle' => '8. ITG-Fachtagung H{"o}rrundfunk',
				'year'      => '1988',
				'month'     => 'nov',
				'pages'     => '252--256',
				'abstract'  => "Some Abstract, across
			two lines"
			]
		];

		#4 invalid/unprocessable content format
		$provider[] = [
			"foo",
			[]
		];

		$provider[] = [
			"@article{}",
			[]
		];

		return $provider;
	}

}


1			<?php
2
3			namespace SCI\Tests\Bibtex;
4
5			use SCI\Bibtex\BibtexParser;
6
7			/**
8			* @covers \SCI\Bibtex\BibtexParser
9			* @group semantic-cite
10			*
11			* @license GNU GPL v2+
12			* @since 1.0
13			*
14			* @author mwjames
15			*/
16			class BibtexParserTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$this->assertInstanceOf(
21			'\SCI\Bibtex\BibtexParser',
22			new BibtexParser()
23			);
24			}
25
26			/**
27			* @dataProvider bibtextProvider
28			*/
29			public function testParse( $bibtex, $expected ) {
30
31			$instance = new BibtexParser();
32
33			$this->assertEquals(
34			$expected,
35			$instance->parse( $bibtex )
36			);
37			}
38
39			public function bibtextProvider() {
40
41			$provider[] = [
42			"@article{einstein1935can,
43			title={Can quantum-mechanical description of physical reality be considered complete?},
44			author={Einstein, Albert and Podolsky, Boris and Rosen, Nathan},
45			journal={Physical review},
46			volume={47},
47			number={10},
48			pages={777},
49			year={1935},
50			publisher={APS}
51			}",
52			[
53			'type' => 'article',
54			'reference' => 'einstein1935can',
55			'title' => 'Can quantum-mechanical description of physical reality be considered complete?',
56			'author' => 'Einstein, Albert and Podolsky, Boris and Rosen, Nathan',
57			'journal' => 'Physical review',
58			'volume' => '47',
59			'number' => '10',
60			'pages' => '777',
61			'year' => '1935',
62			'publisher' => 'APS'
63			]
64			];
65
66			$provider[] = [
67			"@book{marx2004capital,
68			title={Capital (Volume 1: A Critique of Political Economy): A Critique of Political Economy},
69			author={Marx, Karl},
70			year={2004},
71			publisher={Digireads. com Publishing}
72			}",
73			[
74			'type' => 'book',
75			'reference' => 'marx2004capital',
76			'title' => 'Capital (Volume 1: A Critique of Political Economy): A Critique of Political Economy',
77			'author' => 'Marx, Karl',
78			'year' => '2004',
79			'publisher' => 'Digireads. com Publishing'
80			]
81			];
82
83			#2 No reference
84			$provider[] = [
85			"@article{,
86			title={Vascular endothelial growth factor is a secreted angiogenic mitogen},
87			author={Leung, David W and Cachianes, George and Kuang, Wun-Jing and Goeddel, David V and Ferrara, Napoleone},
88			journal={Science},
89			volume={246},
90			number={4935},
91			pages={1306--1309},
92			year={1989},
93			publisher={American Association for the Advancement of Science}
94			}",
95			[
96			'type' => 'article',
97			'reference' => '',
98			'title' => 'Vascular endothelial growth factor is a secreted angiogenic mitogen',
99			'author' => 'Leung, David W and Cachianes, George and Kuang, Wun-Jing and Goeddel, David V and Ferrara, Napoleone',
100			'journal' => 'Science',
101			'volume' => '246',
102			'number' => '4935',
103			'pages' => '1306--1309',
104			'year' => '1989',
105			'publisher' => 'American Association for the Advancement of Science'
106			]
107			];
108
109			#3 No reference
110			$provider[] = [
111			"@inproceedings{clean,
112			author = {First Author and Author, Second},
113			title = {Pr{\"a}diktive Teilbandcodierung mit Vektorquantisierung f{\"u}r hochqualitative Audiosignale},
114			booktitle = {8. ITG-Fachtagung H{\"o}rrundfunk},
115			year = {1988},
116			month = nov,
117			pages = {252--256},
118			abstract = {Some Abstract, across
119			two lines},
120			}",
121			[
122			'type' => 'inproceedings',
123			'reference' => 'clean',
124			'author' => 'First Author and Author, Second',
125			'title' => 'Pr{"a}diktive Teilbandcodierung mit Vektorquantisierung f{"u}r hochqualitative Audiosignale',
126			'booktitle' => '8. ITG-Fachtagung H{"o}rrundfunk',
127			'year' => '1988',
128			'month' => 'nov',
129			'pages' => '252--256',
130			'abstract' => "Some Abstract, across
131			two lines"
132			]
133			];
134
135			#4 invalid/unprocessable content format
136			$provider[] = [
137			"foo",
138			[]
139			];
140
141			$provider[] = [
142			"@article{}",
143			[]
144			];
145
146			return $provider;
147			}
148
149			}
150

SemanticMediaWiki / SemanticCite

Pull Request — master (#136)

BibtexParserTest::bibtextProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like