SCI\FilteredMetadata\CrossRefResponseParser

Complexity

Total Complexity

7

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getRawResponse()	0	2	1
A	usesCache()	0	2	1
A	__construct()	0	2	1
A	doFilterResponseFor()	0	30	2
A	getFilteredRecord()	0	2	1
A	getMessages()	0	2	1

<?php

namespace SCI\FilteredMetadata;

use Onoi\Remi\CrossRef\CrossRefFilteredHttpResponseParser;
use Onoi\Remi\ResponseParser;
use SCI\DataValues\ResourceIdentifierFactory;

/**
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class CrossRefResponseParser implements ResponseParser {

	/**
	 * @var CrossRefFilteredHttpResponseParser
	 */
	private $crossRefFilteredHttpResponseParser;

	/**
	 * @since 1.0
	 *
	 * @param CrossRefFilteredHttpResponseParser $crossRefFilteredHttpResponseParser
	 */
	public function __construct( CrossRefFilteredHttpResponseParser $crossRefFilteredHttpResponseParser ) {
		$this->crossRefFilteredHttpResponseParser = $crossRefFilteredHttpResponseParser;
	}

	/**
	 * @since 1.0
	 *
	 * {@inheritDoc}
	 */
	public function usesCache() {
		return $this->crossRefFilteredHttpResponseParser->usesCache();
	}

	/**
	 * @since 1.0
	 *
	 * {@inheritDoc}
	 */
	public function getMessages() {
		return $this->crossRefFilteredHttpResponseParser->getMessages();
	}

	/**
	 * @since 1.0
	 *
	 * {@inheritDoc}
	 */
	public function getFilteredRecord() {
		return $this->crossRefFilteredHttpResponseParser->getFilteredRecord();
	}

	/**
	 * @since 1.0
	 *
	 * {@inheritDoc}
	 */
	public function getRawResponse( $doi ) {
		return $this->crossRefFilteredHttpResponseParser->getRawResponse( $doi );
	}

	/**
	 * @since 1.0
	 *
	 * {@inheritDoc}
	 */
	public function doFilterResponseFor( $doi ) {

		$resourceIdentifierFactory = new ResourceIdentifierFactory();

		$doiValue = $resourceIdentifierFactory->newResourceIdentifierStringValueForType( 'doi' );
		$doiValue->setUserValue( $doi );

		if ( !$doiValue->isValid() ) {
			return $this->crossRefFilteredHttpResponseParser->addMessage( $doiValue->getErrors() );

Are you sure the usage of $this->crossRefFilteredHttpResponseParser->addMessage($doiValue->getErrors()) targeting Onoi\Remi\FilteredHttpResponseParser::addMessage() seems to always return null.

		}

		$doi = $doiValue->getWikiValue();

		$this->crossRefFilteredHttpResponseParser->doFilterResponseFor( $doi );
		$filteredRecord = $this->crossRefFilteredHttpResponseParser->getFilteredRecord();

		$filteredRecord->setTitleForPageCreation( 'DOI:' . md5( $doi ) );

The method setTitleForPageCreation() does not exist on Onoi\Remi\FilteredRecord. Are you sure you never get this type here, but always one of the subclasses?

		$filteredRecord->addSearchMatchSet(

The method addSearchMatchSet() does not exist on Onoi\Remi\FilteredRecord. Are you sure you never get this type here, but always one of the subclasses?

			'doi',
			$doi
		);

		$filteredRecord->addSearchMatchSet(
			'reference',
			$this->crossRefFilteredHttpResponseParser->getFilteredRecord()->get( 'reference' )
		);

		$dateTimeUtc = new \DateTime( 'now', new \DateTimeZone( 'UTC' ) );
		$filteredRecord->set( 'retrieved-on', $dateTimeUtc->format( 'Y-m-d' ) );
	}

}