Issues in SubpageParentAnnotator.php (master) - Issues in master - SemanticMediaWiki/SemanticBreadcrumbLinks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/SubpageParentAnnotator.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SBL;

use SMW\DIWikiPage;
use SMW\ParserData;
use SMW\DIProperty;
use Title;

/**
 * @license GNU GPL v2+
 * @since 1.3
 *
 * @author mwjames
 */
class SubpageParentAnnotator {

	/**
	 * @var ParserData
	 */
	private $parserData;

	/**
	 * @var boolean
	 */
	private $enableSubpageParentAnnotation = true;

	/**
	 * @var boolean
	 */
	private $disableTranslationSubpageAnnotation = false;

	/**
	 * @since 1.3
	 *
	 * @param ParserData $parserData
	 */
	public function __construct( ParserData $parserData ) {
		$this->parserData = $parserData;
	}

	/**
	 * @since 1.3
	 *
	 * @param boolean $enableSubpageParentAnnotation
	 */
	public function enableSubpageParentAnnotation( $enableSubpageParentAnnotation ) {
		$this->enableSubpageParentAnnotation = (bool)$enableSubpageParentAnnotation;
	}

	/**
	 * @since 1.3
	 *
	 * @param boolean $enableSubpageParentAnnotation
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 */
	public function disableTranslationSubpageAnnotation( $disableTranslationSubpageAnnotation ) {
		$this->disableTranslationSubpageAnnotation = (bool)$disableTranslationSubpageAnnotation;
	}

	/**
	 * @since  1.3
	 */
	public function addAnnotation() {

		$title = $this->parserData->getTitle();

		if ( !$this->enableSubpageParentAnnotation || strpos( $title->getText(), '/' ) === false ) {
			return;
		}

		// Is a ranslation page? bail-out!
		// @see https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/3293
		if ( $this->disableTranslationSubpageAnnotation && $this->parserData->getOutput()->getExtensionData( 'translate-translation-page' ) ) {
			return;
		}

		$property = DIProperty::newFromUserLabel( SBL_PROP_PARENTPAGE );

		// Don't override any "man"-made annotation
		if ( $this->parserData->getSemanticData()->getPropertyValues( $property ) !== [] ) {
			return;
		}

		$base = $this->getBaseText( $title );

		// #23
		if ( substr( $base, -1 ) === ' ' ) {
			return;
		}

		$this->parserData->getSemanticData()->addPropertyObjectValue(
			$property,
			DIWikiPage::newFromText( $base, $title->getNamespace() )
		);

		$this->parserData->pushSemanticDataToParserOutput();

	}

	// Don't rely on Title::getBaseText as it depends on the wgNamespacesWithSubpages
	// setting and if set false will return the normal text including its subparts
	private function getBaseText( $title ) {

		$parts = explode( '/', $title->getText() );
		# Don't discard the real title if there's no subpage involved
		if ( count( $parts ) > 1 ) {
			unset( $parts[count( $parts ) - 1] );
		}

		return implode( '/', $parts );
	}

}


1		<?php
2
3		namespace SBL;
4
5		use SMW\DIWikiPage;
6		use SMW\ParserData;
7		use SMW\DIProperty;
8		use Title;
9
10		/**
11		* @license GNU GPL v2+
12		* @since 1.3
13		*
14		* @author mwjames
15		*/
16		class SubpageParentAnnotator {
17
18		/**
19		* @var ParserData
20		*/
21		private $parserData;
22
23		/**
24		* @var boolean
25		*/
26		private $enableSubpageParentAnnotation = true;
27
28		/**
29		* @var boolean
30		*/
31		private $disableTranslationSubpageAnnotation = false;
32
33		/**
34		* @since 1.3
35		*
36		* @param ParserData $parserData
37		*/
38	6	public function __construct( ParserData $parserData ) {
39	6	$this->parserData = $parserData;
40	6	}
41
42		/**
43		* @since 1.3
44		*
45		* @param boolean $enableSubpageParentAnnotation
46		*/
47	3	public function enableSubpageParentAnnotation( $enableSubpageParentAnnotation ) {
48	3	$this->enableSubpageParentAnnotation = (bool)$enableSubpageParentAnnotation;
49	3	}
50
51		/**
52		* @since 1.3
53		*
54		* @param boolean $enableSubpageParentAnnotation
		0 ignored issues – show Bug introduced 2018-09-15 02:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$enableSubpageParentAnnotation`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
55		*/
56	1	public function disableTranslationSubpageAnnotation( $disableTranslationSubpageAnnotation ) {
57	1	$this->disableTranslationSubpageAnnotation = (bool)$disableTranslationSubpageAnnotation;
58	1	}
59
60		/**
61		* @since 1.3
62		*/
63	5	public function addAnnotation() {
64
65	5	$title = $this->parserData->getTitle();
66
67	5	if ( !$this->enableSubpageParentAnnotation \|\| strpos( $title->getText(), '/' ) === false ) {
68	1	return;
69		}
70
71		// Is a ranslation page? bail-out!
72		// @see https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/3293
73	4	if ( $this->disableTranslationSubpageAnnotation && $this->parserData->getOutput()->getExtensionData( 'translate-translation-page' ) ) {
74	1	return;
75		}
76
77	3	$property = DIProperty::newFromUserLabel( SBL_PROP_PARENTPAGE );
78
79		// Don't override any "man"-made annotation
80	3	if ( $this->parserData->getSemanticData()->getPropertyValues( $property ) !== [] ) {
81	1	return;
82		}
83
84	2	$base = $this->getBaseText( $title );
85
86		// #23
87	2	if ( substr( $base, -1 ) === ' ' ) {
88	1	return;
89		}
90
91	1	$this->parserData->getSemanticData()->addPropertyObjectValue(
92	1	$property,
93	1	DIWikiPage::newFromText( $base, $title->getNamespace() )
94	1	);
95
96	1	$this->parserData->pushSemanticDataToParserOutput();
		0 ignored issues – show Deprecated Code introduced 2018-04-17 21:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `SMW\ParserData::pushSemanticDataToParserOutput()` has been deprecated with message: since 3.0, use copyToParserOutput This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
97	1	}
98
99		// Don't rely on Title::getBaseText as it depends on the wgNamespacesWithSubpages
100		// setting and if set false will return the normal text including its subparts
101	2	private function getBaseText( $title ) {
102
103	2	$parts = explode( '/', $title->getText() );
104		# Don't discard the real title if there's no subpage involved
105	2	if ( count( $parts ) > 1 ) {
106	2	unset( $parts[count( $parts ) - 1] );
107	2	}
108
109	2	return implode( '/', $parts );
110		}
111
112		}
113

SemanticMediaWiki / SemanticBreadcrumbLinks

Issues (10)

Security Analysis no request data

src/SubpageParentAnnotator.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like