BySubpageLinksFinderTest::titleProvider() - Code Metrics - SemanticMediaWiki/SemanticBreadcrumbLinks - Measure and Improve Code Quality continuously with Scrutinizer

BySubpageLinksFinderTest::titleProvider() B
last analyzed 2021-02-22 16:01 UTC

↳ Parent: BySubpageLinksFinderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	91
rs	8.1963
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace SBL\Tests;

use SBL\BySubpageLinksFinder;
use SMW\DIWikiPage;
use Title;

/**
 * @covers \SBL\BySubpageLinksFinder
 * @group semantic-breadcrumb-links
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class BySubpageLinksFinderTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$this->assertInstanceOf(
			'\SBL\BySubpageLinksFinder',
			new BySubpageLinksFinder()
		);
	}

	public function testDisabledFinder() {

		$instance = new BySubpageLinksFinder();
		$instance->setSubpageDiscoveryFallback( false );

		$this->assertFalse(
			$instance->isDiscoveryFallback()
		);
	}

	/**
	 * @dataProvider titleProvider
	 */
	public function testFindParentBreadcrumbs( $title, $count, $expected ) {

		$subject = DIWikiPage::newFromTitle( Title::newFromText( $title ) );

		$instance = new BySubpageLinksFinder();
		$instance->setSubpageDiscoveryFallback( true );

		$this->assertEmpty(
			$instance->getParents()
		);

		$instance->findLinksBySubject( $subject );

		$this->assertCount(
			$count,
			$instance->getParents()
		);

		$this->assertEquals(
			$expected,
			$instance->getParents()
		);
	}

	public function titleProvider() {

		#0
		$provider[] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'Foo',
			0,
			[]
		];

		#1
		$provider[] = [
			'Foo/',
			1,
			[
				new DIWikiPage( 'Foo', NS_MAIN )
			]
		];

		#2
		$provider[] = [
			'Foo/Bar/Baz',
			2,
			[
				new DIWikiPage( 'Foo', NS_MAIN ),
				new DIWikiPage( 'Foo/Bar', NS_MAIN )
			]
		];

		#3
		$provider[] = [
			'Foo/Bar/Baz/Yin/Yan',
			4,
			[
				new DIWikiPage( 'Foo', NS_MAIN ),
				new DIWikiPage( 'Foo/Bar', NS_MAIN ),
				new DIWikiPage( 'Foo/Bar/Baz', NS_MAIN ),
				new DIWikiPage( 'Foo/Bar/Baz/Yin', NS_MAIN )
			]
		];

		#4 /a/b
		$provider[] = [
			'/a/b',
			1,
			[
				new DIWikiPage( '/a', NS_MAIN )
			]
		];

		#5 /a//b/c
		$provider[] = [
			'/a//b/c',
			2,
			[
				new DIWikiPage( '/a', NS_MAIN ),
				new DIWikiPage( '/a//b', NS_MAIN )
			]
		];

		#6 (#23 issue)
		$provider[] = [
			'Foo / Bar',
			0,
			[]
		];

		#7 (#23 issue)
		$provider[] = [
			'Foo /Bar',
			0,
			[]
		];

		#8 (#23 issue)
		$provider[] = [
			'Foo /Bar /Foobar',
			0,
			[]
		];

		#9
		$provider[] = [
			'Help:Foo/Foobar',
			1,
			[
				new DIWikiPage( 'Foo', NS_HELP ),
			]
		];

		return $provider;
	}

}


1			<?php
2
3			namespace SBL\Tests;
4
5			use SBL\BySubpageLinksFinder;
6			use SMW\DIWikiPage;
7			use Title;
8
9			/**
10			* @covers \SBL\BySubpageLinksFinder
11			* @group semantic-breadcrumb-links
12			*
13			* @license GNU GPL v2+
14			* @since 1.0
15			*
16			* @author mwjames
17			*/
18			class BySubpageLinksFinderTest extends \PHPUnit_Framework_TestCase {
19
20			public function testCanConstruct() {
21
22			$this->assertInstanceOf(
23			'\SBL\BySubpageLinksFinder',
24			new BySubpageLinksFinder()
25			);
26			}
27
28			public function testDisabledFinder() {
29
30			$instance = new BySubpageLinksFinder();
31			$instance->setSubpageDiscoveryFallback( false );
32
33			$this->assertFalse(
34			$instance->isDiscoveryFallback()
35			);
36			}
37
38			/**
39			* @dataProvider titleProvider
40			*/
41			public function testFindParentBreadcrumbs( $title, $count, $expected ) {
42
43			$subject = DIWikiPage::newFromTitle( Title::newFromText( $title ) );
44
45			$instance = new BySubpageLinksFinder();
46			$instance->setSubpageDiscoveryFallback( true );
47
48			$this->assertEmpty(
49			$instance->getParents()
50			);
51
52			$instance->findLinksBySubject( $subject );
53
54			$this->assertCount(
55			$count,
56			$instance->getParents()
57			);
58
59			$this->assertEquals(
60			$expected,
61			$instance->getParents()
62			);
63			}
64
65			public function titleProvider() {
66
67			#0
68			$provider[] = [
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-07-31 13:09 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
69			'Foo',
70			0,
71			[]
72			];
73
74			#1
75			$provider[] = [
76			'Foo/',
77			1,
78			[
79			new DIWikiPage( 'Foo', NS_MAIN )
80			]
81			];
82
83			#2
84			$provider[] = [
85			'Foo/Bar/Baz',
86			2,
87			[
88			new DIWikiPage( 'Foo', NS_MAIN ),
89			new DIWikiPage( 'Foo/Bar', NS_MAIN )
90			]
91			];
92
93			#3
94			$provider[] = [
95			'Foo/Bar/Baz/Yin/Yan',
96			4,
97			[
98			new DIWikiPage( 'Foo', NS_MAIN ),
99			new DIWikiPage( 'Foo/Bar', NS_MAIN ),
100			new DIWikiPage( 'Foo/Bar/Baz', NS_MAIN ),
101			new DIWikiPage( 'Foo/Bar/Baz/Yin', NS_MAIN )
102			]
103			];
104
105			#4 /a/b
106			$provider[] = [
107			'/a/b',
108			1,
109			[
110			new DIWikiPage( '/a', NS_MAIN )
111			]
112			];
113
114			#5 /a//b/c
115			$provider[] = [
116			'/a//b/c',
117			2,
118			[
119			new DIWikiPage( '/a', NS_MAIN ),
120			new DIWikiPage( '/a//b', NS_MAIN )
121			]
122			];
123
124			#6 (#23 issue)
125			$provider[] = [
126			'Foo / Bar',
127			0,
128			[]
129			];
130
131			#7 (#23 issue)
132			$provider[] = [
133			'Foo /Bar',
134			0,
135			[]
136			];
137
138			#8 (#23 issue)
139			$provider[] = [
140			'Foo /Bar /Foobar',
141			0,
142			[]
143			];
144
145			#9
146			$provider[] = [
147			'Help:Foo/Foobar',
148			1,
149			[
150			new DIWikiPage( 'Foo', NS_HELP ),
151			]
152			];
153
154			return $provider;
155			}
156
157			}
158

SemanticMediaWiki / SemanticBreadcrumbLinks

BySubpageLinksFinderTest::titleProvider() B last analyzed 2021-02-22 16:01 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

BySubpageLinksFinderTest::titleProvider() B
last analyzed 2021-02-22 16:01 UTC