ApprovedRevsHandler::doChangeRevision() - Code Metrics - Inspection of "Add tests" - SemanticMediaWiki/SemanticApprovedRevs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bc2207...6c16a9 )

by mw

created 2019-03-02 17:45 UTC

ApprovedRevsHandler::doChangeRevision() A

↳ Parent: ApprovedRevsHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php

namespace SMW\ApprovedRevs;

use Title;
use Revision;

/**
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class ApprovedRevsHandler {

	/**
	 * @var ApprovedRevsFacade
	 */
	private $approvedRevsFacade;

	/**
	 * @since 1.0
	 *
	 * @param ApprovedRevsFacade $approvedRevsFacade
	 */
	public function __construct( ApprovedRevsFacade $approvedRevsFacade ) {
		$this->approvedRevsFacade = $approvedRevsFacade;
	}

	/**
	 * @since  1.0
	 *
	 * @param Title $title
	 * @param integer $latestRevID
	 *
	 * @return boolean
	 */
	public function isApprovedUpdate( Title $title, $latestRevID ) {

		if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
			return $approvedRevID == $latestRevID;
		}

		return true;
	}

	/**
	 * @since  1.0
	 *
	 * @param Title $title
	 * @param Revision|null &$revision
	 */
	public function doChangeRevision( Title $title, &$revision ) {

		// Forcibly change the revision to match what ApprovedRevs sees as
		// approved
		if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
			$revision = Revision::newFromId( $approvedRevID );
		}
	}

	/**
	 * @since  1.0
	 *
	 * @param Title $title
	 * @param integer &$revisionID
	 */
	public function doChangeRevisionID( Title $title, &$revisionID ) {

		if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
			$revisionID = $approvedRevID;
		}
	}

}


1		<?php
2
3		namespace SMW\ApprovedRevs;
4
5		use Title;
6		use Revision;
7
8		/**
9		* @license GNU GPL v2+
10		* @since 1.0
11		*
12		* @author mwjames
13		*/
14		class ApprovedRevsHandler {
15
16		/**
17		* @var ApprovedRevsFacade
18		*/
19		private $approvedRevsFacade;
20
21		/**
22		* @since 1.0
23		*
24		* @param ApprovedRevsFacade $approvedRevsFacade
25		*/
26	5	public function __construct( ApprovedRevsFacade $approvedRevsFacade ) {
27	5	$this->approvedRevsFacade = $approvedRevsFacade;
28	5	}
29
30		/**
31		* @since 1.0
32		*
33		* @param Title $title
34		* @param integer $latestRevID
35		*
36		* @return boolean
37		*/
38	2	public function isApprovedUpdate( Title $title, $latestRevID ) {
39
40	2	if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
41	2	return $approvedRevID == $latestRevID;
42		}
43
44		return true;
45		}
46
47		/**
48		* @since 1.0
49		*
50		* @param Title $title
51		* @param Revision\|null &$revision
52		*/
53	1	public function doChangeRevision( Title $title, &$revision ) {
54
55		// Forcibly change the revision to match what ApprovedRevs sees as
56		// approved
57	1	if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
58	1	$revision = Revision::newFromId( $approvedRevID );
59		}
60	1	}
61
62		/**
63		* @since 1.0
64		*
65		* @param Title $title
66		* @param integer &$revisionID
67		*/
68	1	public function doChangeRevisionID( Title $title, &$revisionID ) {
69
70	1	if ( ( $approvedRevID = $this->approvedRevsFacade->getApprovedRevID( $title ) ) !== null ) {
71	1	$revisionID = $approvedRevID;
72		}
73	1	}
74
75		}
76

SemanticMediaWiki / SemanticApprovedRevs

Push — master ( bc2207...6c16a9 )

ApprovedRevsHandler::doChangeRevision() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like