Issues in ApprovedDatePropertyAnnotatorTest.php - New Issues - Inspection of "Copy SESP (ApprovedRevs) properties (#1)" - SemanticMediaWiki/SemanticApprovedRevs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 946aec...bc2207 )

by mw

created 2019-03-02 17:24 UTC

ApprovedDatePropertyAnnotatorTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;

use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
use SMW\DIProperty;
use MWTimestamp;
use SMWDITime as DITime;

/**
 * @covers \SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator
 * @group semantic-approved-revs
 *
 * @license GNU GPL v2+
 * @since 1.0
 */
class ApprovedDatePropertyAnnotatorTest extends \PHPUnit_Framework_TestCase {

	private $databaseLogReader;

	protected function setUp() {
		parent::setUp();

		$this->databaseLogReader = $this->getMockBuilder( '\SMW\ApprovedRevs\DatabaseLogReader' )
			->disableOriginalConstructor()
			->getMock();
	}

	public function testCanConstruct() {

		$this->assertInstanceOf(
			ApprovedDatePropertyAnnotator::class,
			new ApprovedDatePropertyAnnotator( $this->databaseLogReader )
		);
	}

	protected static function getDITime( MWTimestamp $time ) {
		return new DITime(
				DITime::CM_GREGORIAN,
				$time->format( 'Y' ),
				$time->format( 'm' ),
				$time->format( 'd' ),
				$time->format( 'H' ),
				$time->format( 'i' )
		);
	}

	public function testAddAnnotation() {

		$now = new MWTimestamp( wfTimestampNow() );
		$time = self::getDITime( $now );

		$semanticData = $this->getMockBuilder( '\SMW\SemanticData' )
			->disableOriginalConstructor()
			->getMock();

		$semanticData->expects( $this->once() )
			->method( 'addPropertyObjectValue' )
			->with(
				$this->anyThing(),
				$this->equalTo( $time )
			);

		$annotator = new ApprovedDatePropertyAnnotator(
			$this->databaseLogReader
		);

		$annotator->setApprovedDate( $now );
		$annotator->addAnnotation( $semanticData );
	}

	public function testRemoval() {
		$semanticData = $this->getMockBuilder( '\SMW\SemanticData' )
			->disableOriginalConstructor()
			->getMock();

		$semanticData->expects( $this->once() )
			->method( 'removeProperty' );

		$annotator = new ApprovedDatePropertyAnnotator(
			$this->databaseLogReader
		);

		$annotator->setApprovedDate( false );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$annotator->addAnnotation( $semanticData );
	}

}


1			<?php
2
3			namespace SMW\ApprovedRevs\Tests\PropertyAnnotators;
4
5			use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
6			use SMW\DIProperty;
7			use MWTimestamp;
8			use SMWDITime as DITime;
9
10			/**
11			* @covers \SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator
12			* @group semantic-approved-revs
13			*
14			* @license GNU GPL v2+
15			* @since 1.0
16			*/
17			class ApprovedDatePropertyAnnotatorTest extends \PHPUnit_Framework_TestCase {
18
19			private $databaseLogReader;
20
21			protected function setUp() {
22			parent::setUp();
23
24			$this->databaseLogReader = $this->getMockBuilder( '\SMW\ApprovedRevs\DatabaseLogReader' )
25			->disableOriginalConstructor()
26			->getMock();
27			}
28
29			public function testCanConstruct() {
30
31			$this->assertInstanceOf(
32			ApprovedDatePropertyAnnotator::class,
33			new ApprovedDatePropertyAnnotator( $this->databaseLogReader )
34			);
35			}
36
37			protected static function getDITime( MWTimestamp $time ) {
38			return new DITime(
39			DITime::CM_GREGORIAN,
40			$time->format( 'Y' ),
41			$time->format( 'm' ),
42			$time->format( 'd' ),
43			$time->format( 'H' ),
44			$time->format( 'i' )
45			);
46			}
47
48			public function testAddAnnotation() {
49
50			$now = new MWTimestamp( wfTimestampNow() );
51			$time = self::getDITime( $now );
52
53			$semanticData = $this->getMockBuilder( '\SMW\SemanticData' )
54			->disableOriginalConstructor()
55			->getMock();
56
57			$semanticData->expects( $this->once() )
58			->method( 'addPropertyObjectValue' )
59			->with(
60			$this->anyThing(),
61			$this->equalTo( $time )
62			);
63
64			$annotator = new ApprovedDatePropertyAnnotator(
65			$this->databaseLogReader
66			);
67
68			$annotator->setApprovedDate( $now );
69			$annotator->addAnnotation( $semanticData );
70			}
71
72			public function testRemoval() {
73			$semanticData = $this->getMockBuilder( '\SMW\SemanticData' )
74			->disableOriginalConstructor()
75			->getMock();
76
77			$semanticData->expects( $this->once() )
78			->method( 'removeProperty' );
79
80			$annotator = new ApprovedDatePropertyAnnotator(
81			$this->databaseLogReader
82			);
83
84			$annotator->setApprovedDate( false );
			0 ignored issues – show Documentation introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `false` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85			$annotator->addAnnotation( $semanticData );
86			}
87
88			}
89

SemanticMediaWiki / SemanticApprovedRevs

Push — master ( 946aec...bc2207 )

ApprovedDatePropertyAnnotatorTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like