Issues in ApprovedDatePropertyAnnotator.php - New Issues - Inspection of "Copy SESP (ApprovedRevs) properties (#1)" - SemanticMediaWiki/SemanticApprovedRevs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 946aec...bc2207 )

by mw

created 2019-03-02 17:24 UTC

ApprovedDatePropertyAnnotator.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php


namespace SMW\ApprovedRevs\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMWDITime as DITime;;
use SMW\ApprovedRevs\DatabaseLogReader;
use SMW\ApprovedRevs\PropertyRegistry;
use User;

/**
 * @private
 *
 * @license GNU GPL v2+
 */
class ApprovedDatePropertyAnnotator {

	/**
	 * @var DatabaseLogReader
	 */
	private $databaseLogReader;

	/**
	 * @var Integer|null
	 */
	private $approvedDate;

	/**
	 * @param DatabaseLogReader $databaseLogReader
	 */
	public function __construct( DatabaseLogReader $databaseLogReader ) {
		$this->databaseLogReader = $databaseLogReader;
	}

	/**
	 * @since 1.0
	 *
	 * @param integer $approvedDate
	 */
	public function setApprovedDate( $approvedDate ) {
		$this->approvedDate = $approvedDate;
	}

	/**
	 * @since 1.0
	 *
	 * @return DIProperty
	 */
	public function newDIProperty() {
		return new DIProperty( PropertyRegistry::SAR_PROP_APPROVED_DATE );
	}

	/**
	 * @since 1.0
	 *
	 * @param SemanticData $semanticData
	 */
	public function addAnnotation( SemanticData $semanticData ) {

		if ( $this->approvedDate === null ) {
			$this->approvedDate = $this->databaseLogReader->getDateOfLogEntry(
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
				$semanticData->getSubject()->getTitle(),
				'approval'
			);
		}

		$property = $this->newDIProperty();
		$dataItem = $this->newDITime();
		$semanticData->removeProperty( $property );

		if ( $dataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

	private function newDITime() {

		if ( $this->approvedDate === null || is_bool( $this->approvedDate ) ) {
			return;
		}

		$date = $this->approvedDate;

		return new DITime(
			DITime::CM_GREGORIAN,
			$date->format( 'Y' ),

			$date->format( 'm' ),

			$date->format( 'd' ),

			$date->format( 'H' ),

			$date->format( 'i' )

		);
	}

}


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 7. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		namespace SMW\ApprovedRevs\PropertyAnnotators;
4
5		use SMW\DIProperty;
6		use SMW\SemanticData;
7		use SMWDITime as DITime;;
8		use SMW\ApprovedRevs\DatabaseLogReader;
9		use SMW\ApprovedRevs\PropertyRegistry;
10		use User;
11
12		/**
13		* @private
14		*
15		* @license GNU GPL v2+
16		*/
17		class ApprovedDatePropertyAnnotator {
18
19		/**
20		* @var DatabaseLogReader
21		*/
22		private $databaseLogReader;
23
24		/**
25		* @var Integer\|null
26		*/
27		private $approvedDate;
28
29		/**
30		* @param DatabaseLogReader $databaseLogReader
31		*/
32	3	public function __construct( DatabaseLogReader $databaseLogReader ) {
33	3	$this->databaseLogReader = $databaseLogReader;
34	3	}
35
36		/**
37		* @since 1.0
38		*
39		* @param integer $approvedDate
40		*/
41	2	public function setApprovedDate( $approvedDate ) {
42	2	$this->approvedDate = $approvedDate;
43	2	}
44
45		/**
46		* @since 1.0
47		*
48		* @return DIProperty
49		*/
50	2	public function newDIProperty() {
51	2	return new DIProperty( PropertyRegistry::SAR_PROP_APPROVED_DATE );
52		}
53
54		/**
55		* @since 1.0
56		*
57		* @param SemanticData $semanticData
58		*/
59	2	public function addAnnotation( SemanticData $semanticData ) {
60
61	2	if ( $this->approvedDate === null ) {
62		$this->approvedDate = $this->databaseLogReader->getDateOfLogEntry(
		0 ignored issues – show Documentation Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->databaseLogReader...getTitle(), 'approval')` can also be of type `object<MWTimestamp>`. However, the property `$approvedDate` is declared as type `integer\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
63		$semanticData->getSubject()->getTitle(),
64		'approval'
65		);
66		}
67
68	2	$property = $this->newDIProperty();
69	2	$dataItem = $this->newDITime();
70	2	$semanticData->removeProperty( $property );
71
72	2	if ( $dataItem ) {
73	1	$semanticData->addPropertyObjectValue( $property, $dataItem );
74		}
75	2	}
76
77	2	private function newDITime() {
78
79	2	if ( $this->approvedDate === null \|\| is_bool( $this->approvedDate ) ) {
80	1	return;
81		}
82
83	1	$date = $this->approvedDate;
84
85	1	return new DITime(
86	1	DITime::CM_GREGORIAN,
87	1	$date->format( 'Y' ),
		0 ignored issues – show Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `format` cannot be called on `$date` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
88	1	$date->format( 'm' ),
		0 ignored issues – show Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `format` cannot be called on `$date` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
89	1	$date->format( 'd' ),
		0 ignored issues – show Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `format` cannot be called on `$date` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
90	1	$date->format( 'H' ),
		0 ignored issues – show Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `format` cannot be called on `$date` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
91	1	$date->format( 'i' )
		0 ignored issues – show Bug introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `format` cannot be called on `$date` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
92		);
93		}
94
95		}
96

SemanticMediaWiki / SemanticApprovedRevs

Push — master ( 946aec...bc2207 )

ApprovedDatePropertyAnnotator.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like