Issues in PropertyAnnotator.php - New Issues - Inspection of "Copy SESP (ApprovedRevs) properties (#1)" - SemanticMediaWiki/SemanticApprovedRevs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 946aec...bc2207 )

by mw

created 2019-03-02 17:24 UTC

src/PropertyAnnotator.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SMW\ApprovedRevs;

use Psr\Log\LoggerAwareTrait;
use SMW\DIProperty;
use SMW\SemanticData;
use SMW\ApprovedRevs\PropertyAnnotators\ApprovedStatusPropertyAnnotator;
use SMW\ApprovedRevs\PropertyAnnotators\ApprovedByPropertyAnnotator;
use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
use SMW\ApprovedRevs\PropertyAnnotators\ApprovedRevPropertyAnnotator;

/**
 * @private
 *
 * @license GNU GPL v2+
 * @since 1.0
 *
 * @author mwjames
 */
class PropertyAnnotator {

	use LoggerAwareTrait;

	/**
	 * @var ServicesFactory
	 */
	private $servicesFactory;

	/**
	 * @var PropertyAnnotator[]
	 */
	private $propertyAnnotators = [];

	/**
	 * @since 1.0
	 *
	 * @param ServicesFactory $servicesFactory
	 */
	public function __construct( ServicesFactory $servicesFactory ) {
		$this->servicesFactory = $servicesFactory;
	}

	/**
	 * @since 1.0
	 *
	 * @param SemanticData $semanticData
	 */
	public function addAnnotation( SemanticData $semanticData ) {

		$time = microtime( true );

		if ( !$this->canAnnotate( $semanticData->getSubject() ) ) {
			return;
		}

		if ( $this->propertyAnnotators === [] ) {
			$this->initPropertyAnnotators();
		}

		foreach ( $this->propertyAnnotators as $propertyAnnotator ) {
			$propertyAnnotator->addAnnotation( $semanticData );
		}

		$this->logger->info(
			[ 'SemanticApprovedRevs', 'procTime:{procTime}' ],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			[ 'procTime' => round( ( microtime( true ) - $time ), 5 ) ]
		);
	}

	private function canAnnotate( $subject ) {

		if ( $subject === null || $subject->getTitle() === null || $subject->getTitle()->isSpecialPage() ) {
			return false;
		}

		return true;
	}

	private function initPropertyAnnotators() {
		$this->propertyAnnotators[] = $this->servicesFactory->newApprovedByPropertyAnnotator();
		$this->propertyAnnotators[] = $this->servicesFactory->newApprovedStatusPropertyAnnotator();
		$this->propertyAnnotators[] = $this->servicesFactory->newApprovedDatePropertyAnnotator();
		$this->propertyAnnotators[] = $this->servicesFactory->newApprovedRevPropertyAnnotator();
	}

}


1		<?php
2
3		namespace SMW\ApprovedRevs;
4
5		use Psr\Log\LoggerAwareTrait;
6		use SMW\DIProperty;
7		use SMW\SemanticData;
8		use SMW\ApprovedRevs\PropertyAnnotators\ApprovedStatusPropertyAnnotator;
9		use SMW\ApprovedRevs\PropertyAnnotators\ApprovedByPropertyAnnotator;
10		use SMW\ApprovedRevs\PropertyAnnotators\ApprovedDatePropertyAnnotator;
11		use SMW\ApprovedRevs\PropertyAnnotators\ApprovedRevPropertyAnnotator;
12
13		/**
14		* @private
15		*
16		* @license GNU GPL v2+
17		* @since 1.0
18		*
19		* @author mwjames
20		*/
21		class PropertyAnnotator {
22
23		use LoggerAwareTrait;
24
25		/**
26		* @var ServicesFactory
27		*/
28		private $servicesFactory;
29
30		/**
31		* @var PropertyAnnotator[]
32		*/
33		private $propertyAnnotators = [];
34
35		/**
36		* @since 1.0
37		*
38		* @param ServicesFactory $servicesFactory
39		*/
40	2	public function __construct( ServicesFactory $servicesFactory ) {
41	2	$this->servicesFactory = $servicesFactory;
42	2	}
43
44		/**
45		* @since 1.0
46		*
47		* @param SemanticData $semanticData
48		*/
49	1	public function addAnnotation( SemanticData $semanticData ) {
50
51	1	$time = microtime( true );
52
53	1	if ( !$this->canAnnotate( $semanticData->getSubject() ) ) {
54		return;
55		}
56
57	1	if ( $this->propertyAnnotators === [] ) {
58	1	$this->initPropertyAnnotators();
59		}
60
61	1	foreach ( $this->propertyAnnotators as $propertyAnnotator ) {
62	1	$propertyAnnotator->addAnnotation( $semanticData );
63		}
64
65	1	$this->logger->info(
66	1	[ 'SemanticApprovedRevs', 'procTime:{procTime}' ],
		0 ignored issues – show Documentation introduced 2019-03-02 17:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('SemanticApprovedR... 'procTime:{procTime}')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67	1	[ 'procTime' => round( ( microtime( true ) - $time ), 5 ) ]
68		);
69	1	}
70
71	1	private function canAnnotate( $subject ) {
72
73	1	if ( $subject === null \|\| $subject->getTitle() === null \|\| $subject->getTitle()->isSpecialPage() ) {
74		return false;
75		}
76
77	1	return true;
78		}
79
80	1	private function initPropertyAnnotators() {
81	1	$this->propertyAnnotators[] = $this->servicesFactory->newApprovedByPropertyAnnotator();
82	1	$this->propertyAnnotators[] = $this->servicesFactory->newApprovedStatusPropertyAnnotator();
83	1	$this->propertyAnnotators[] = $this->servicesFactory->newApprovedDatePropertyAnnotator();
84	1	$this->propertyAnnotators[] = $this->servicesFactory->newApprovedRevPropertyAnnotator();
85	1	}
86
87		}
88

SemanticMediaWiki / SemanticApprovedRevs

Push — master ( 946aec...bc2207 )

src/PropertyAnnotator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like