SMW\ApprovedRevs\PropertyAnnotators\ApprovedByPropertyAnnotator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Test Coverage

Coverage

88%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	2	1
A	addAnnotation()	0	15	3
A	newDIWikiPage()	0	10	3
A	newDIProperty()	0	2	1
A	setApprovedBy()	0	2	1

<?php

namespace SMW\ApprovedRevs\PropertyAnnotators;

use SMW\DIProperty;
use SMW\SemanticData;
use SMW\DIWikiPage;
use SMW\ApprovedRevs\DatabaseLogReader;
use SMW\ApprovedRevs\PropertyRegistry;
use User;

The type User was not found. Maybe you did not declare it correctly or list all dependencies?

use Title;

The type Title was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * @private
 *
 * @license GNU GPL v2+
 */
class ApprovedByPropertyAnnotator {

	/**
	 * @var DatabaseLogReader
	 */
	private $databaseLogReader;

	/**
	 * @var Integer|null
	 */
	private $approvedBy;

	/**
	 * @param DatabaseLogReader $databaseLogReader
	 */
	public function __construct( DatabaseLogReader $databaseLogReader ) {
		$this->databaseLogReader = $databaseLogReader;
	}

	/**
	 * @since 1.0
	 *
	 * @param string $approvedBy
	 */
	public function setApprovedBy( $approvedBy ) {
		$this->approvedBy = $approvedBy;

It seems like $approvedBy of type string is incompatible with the declared type integer|null of property $approvedBy.

	}

	/**
	 * @since 1.0
	 *
	 * @return DIProperty
	 */
	public function newDIProperty() {
		return new DIProperty( PropertyRegistry::SAR_PROP_APPROVED_BY );
	}

	/**
	 * @since 1.0
	 *
	 * @param SemanticData $semanticData
	 */
	public function addAnnotation( SemanticData $semanticData ) {

		if ( $this->approvedBy === null ) {
			$this->approvedBy = $this->databaseLogReader->getUserForLogEntry(

It seems like $this->databaseLogReader->getUserForLogEntry($semanticData->getSubject()->getTitle(), 'approval') of type User is incompatible with the declared type integer|null of property $approvedBy.

				$semanticData->getSubject()->getTitle(),
				'approval'
			);
		}

		$property = $this->newDIProperty();
		$dataItem = $this->newDIWikiPage();
		$semanticData->removeProperty( $property );

		if ( $dataItem ) {
			$semanticData->addPropertyObjectValue( $property, $dataItem );
		}
	}

	private function newDIWikiPage() {

		if ( !$this->approvedBy instanceof User ) {
			return;
		}

		$userPage = $this->approvedBy->getUserPage();

		if ( $userPage instanceof Title ) {
			return DIWikiPage::newFromTitle( $userPage );
		}
	}

}