View GitHub Repository django-localized-fields

Schedule Inspection
Subscribe
Passed
Pull Request — master (#15)
by
unknown
01:58
created

LocalizedTextField   A

↳ Parent: Project

Complexity

Total Complexity 1

Size/Duplication

Total Lines 10
Duplicated Lines 0 %

Test Coverage

Coverage 40%

Importance

Changes 1
Bugs 0 Features 1
Metric Value
c 1
b 0
f 1
dl 0
loc 10
ccs 2
cts 5
cp 0.4
rs 10
wmc 1

1 Method

Rating   Name   Duplication   Size   Complexity  
A formfield() 0 9 1
1 1 
from ..forms import LocalizedTextFieldForm
0 ignored issues
– show
Bug introduced by
There seems to be a cyclic import (localized_fields.fields -> localized_fields.fields.localized_file_field).

Cyclic imports may cause partly loaded modules to be returned. This might lead to unexpected runtime behavior which is hard to debug.

Loading history...
2 1 
from .localized_char_field import LocalizedCharField
3 

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    5
                

                                    
                             1                         
                
                
                
class LocalizedTextField(LocalizedCharField):

            


            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                             1                         
                
                
                
    def formfield(self, **kwargs):

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
        """Gets the form field associated with this field."""

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
        defaults = {

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
            'form_class': LocalizedTextFieldForm

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
        }

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
        defaults.update(kwargs)

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
        return super().formfield(**defaults)

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Usage of * or ** arguments should usually be done with care.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Generally, there is nothing wrong with usage of * or ** arguments.
For readability of the code base, we suggest to not over-use these language
constructs though.


For more information, we can recommend this
blog post from Ned Batchelder
including its comments which also touches this aspect.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    15