LocalizedModel.save() - Code Metrics - Inspection of "Added tests for custom db-backend" - SectorLabs/django-localized-fields - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5ba9be...1ef026 )

by Swen

created 2017-02-02 12:36 UTC

LocalizedModel.save() B

↳ Parent:

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6.1666

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
dl	0
loc	21
rs	7.8867
c	1
b	0
f	0
ccs	10
cts	12
cp	0.8333
crap	6.1666

from django.db import models, transaction
from django.db.utils import IntegrityError

from .fields import LocalizedField
from .localized_value import LocalizedValue


class LocalizedModel(models.Model):
    """A model that contains localized fields."""

    class Meta:
        abstract = True

    def __init__(self, *args, **kwargs):
        """Initializes a new instance of :see:LocalizedModel.

        Here we set all the fields that are of :see:LocalizedField
        to an instance of :see:LocalizedValue in case they are none
        so that the user doesn't explicitely have to do so."""

        super(LocalizedModel, self).__init__(*args, **kwargs)

        for field in self._meta.get_fields():
            if not isinstance(field, LocalizedField):
                continue

            value = getattr(self, field.name, None)

            if not isinstance(value, LocalizedValue):
                if isinstance(value, dict):
                    value = LocalizedValue(value)
                else:
                    value = LocalizedValue()

            setattr(self, field.name, value)

    def save(self, *args, **kwargs):
        """Saves this model instance to the database."""

        if not hasattr(self, 'retries'):
            self.retries = 0
class Foo:
    def __init__(self, x=None):
        self.x = x

        with transaction.atomic():
            try:
                return super(LocalizedModel, self).save(*args, **kwargs)
            except IntegrityError as ex:
                # this is as retarded as it looks, there's no
                # way we can put the retry logic inside the slug
                # field class... we can also not only catch exceptions
                # that apply to slug fields... so yea.. this is as
                # retarded as it gets... i am sorry :(
                if 'slug' not in str(ex):
                    if self.retries >= 100:
                        raise ex

        self.retries += 1
        return self.save()


1	1	from django.db import models, transaction
2	1	from django.db.utils import IntegrityError
3
4	1	from .fields import LocalizedField
5	1	from .localized_value import LocalizedValue
6
7
8	1	class LocalizedModel(models.Model):
9		"""A model that contains localized fields."""
10
11	1	class Meta:
12	1	abstract = True
13
14	1	def __init__(self, args, *kwargs):
15		"""Initializes a new instance of :see:LocalizedModel.
16
17		Here we set all the fields that are of :see:LocalizedField
18		to an instance of :see:LocalizedValue in case they are none
19		so that the user doesn't explicitely have to do so."""
20
21	1	super(LocalizedModel, self).__init__(args, *kwargs)
22
23	1	for field in self._meta.get_fields():
24	1	if not isinstance(field, LocalizedField):
25	1	continue
26
27	1	value = getattr(self, field.name, None)
28
29	1	if not isinstance(value, LocalizedValue):
30	1	if isinstance(value, dict):
31	1	value = LocalizedValue(value)
32		else:
33	1	value = LocalizedValue()
34
35	1	setattr(self, field.name, value)
36
37	1	def save(self, args, *kwargs):
38		"""Saves this model instance to the database."""
39
40	1	if not hasattr(self, 'retries'):
41	1	self.retries = 0
		0 ignored issues – show Coding Style introduced 2017-02-02 09:00 UTC by Report Bug Copy Issue Report The attribute `retries` was defined outside `__init__`. It is generally a good practice to initialize all attributes to default values in the `__init__` method: class Foo: def __init__(self, x=None): self.x = x Loading history...
42
43	1	with transaction.atomic():
44	1	try:
45	1	return super(LocalizedModel, self).save(args, *kwargs)
46	1	except IntegrityError as ex:
47		# this is as retarded as it looks, there's no
48		# way we can put the retry logic inside the slug
49		# field class... we can also not only catch exceptions
50		# that apply to slug fields... so yea.. this is as
51		# retarded as it gets... i am sorry :(
52	1	if 'slug' not in str(ex):
53		if self.retries >= 100:
54		raise ex
55
56	1	self.retries += 1
57		return self.save()
58

SectorLabs / django-localized-fields

Push — master ( 5ba9be...1ef026 )

LocalizedModel.save() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like