Issues in meta-boxes.php (master) - Issues in master - Section214/PrintCenter - Measure and Improve Code Quality continuously with Scrutinizer

Issues (130)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/admin/ssi-products/meta-boxes.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Meta boxes
 *
 * @package     PrintCenter\Admin\SSI_Products\MetaBoxes
 * @since       1.0.0
 */


// Exit if accessed directly
if( ! defined( 'ABSPATH' ) ) {
	exit;
}


/**
 * Register meta boxes
 *
 * @since       1.0.0
 * @return      void
 */
function printcenter_add_ssi_product_meta_boxes() {
	add_meta_box( 'ssi-product-details', __( 'Details', 'printcenter' ), 'printcenter_render_ssi_product_details_meta_box', 'ssi_product', 'side', 'default' );
}
add_action( 'add_meta_boxes', 'printcenter_add_ssi_product_meta_boxes' );


/**
 * Render details meta box
 *
 * @since       1.0.0
 * @global      object $post The post we are editing
 * @return      void
 */
function printcenter_render_ssi_product_details_meta_box() {
	global $post;
function myFunction($a, $b) {
    // Do something
}

	$ssi_sku = get_post_meta( $post->ID, '_ssi_sku', true );
	?>
	<p>
		<label for="_ssi_sku"><?php _e( 'SSI SKU:', 'printcenter' ); ?></label>
		<input type="text" class="widefat" id="_ssi_sku" name="_ssi_sku" value="<?php echo esc_attr( stripslashes( $ssi_sku ) ); ?>" />
	</p>
	<?php
	// Allow extension of the meta box
	do_action( 'printcenter_ssi_product_details_meta_box_fields', $post->ID );

	wp_nonce_field( basename( __FILE__ ), 'printcenter_ssi_product_details_meta_box_nonce' );
}


/**
 * Save post meta when the save_post action is called
 *
 * @since       1.0.0
 * @param       int $post_id The ID of the post we are saving
 * @global      object $post The post we are saving
 * @return      void
 */
function printcenter_ssi_product_meta_box_save( $post_id ) {
	global $post;
function myFunction($a, $b) {
    // Do something
}

	// Don't process if nonce can't be validated
	if( ! isset( $_POST['printcenter_ssi_product_details_meta_box_nonce'] ) || ! wp_verify_nonce( $_POST['printcenter_ssi_product_details_meta_box_nonce'], basename( __FILE__ ) ) ) return $post_id;

	// Don't process if this is an autosave
	if( ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) || ( defined( 'DOING_AJAX' ) && DOING_AJAX ) || isset( $_REQUEST['bulk_edit'] ) ) return $post_id;

	// Don't process if this is a revision
	if( isset( $post->post_type ) && $post->post_type == 'revision' ) return $post_id;

	// The default fields that get saved
	$fields = apply_filters( 'printcenter_ssi_product_meta_box_fields_save', array(
		'_ssi_sku'
	) );

	foreach( $fields as $field ) {
		if( isset( $_POST[ $field ] ) ) {
			if( is_string( $_POST[ $field ] ) ) {
				$new = esc_attr( $_POST[ $field ] );
			} else {
				$new = $_POST[ $field ];
			}

			$new = apply_filters( 'printcenter_ssi_product_meta_box_save_' . $field, $new );

			update_post_meta( $post_id, $field, $new );
		} else {
			delete_post_meta( $post_id, $field );
		}
	}
}
add_action( 'save_post', 'printcenter_ssi_product_meta_box_save' );


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-07-13 13:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 22 and the first side effect is on line 12. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Meta boxes
4			*
5			* @package PrintCenter\Admin\SSI_Products\MetaBoxes
6			* @since 1.0.0
7			*/
8
9
10			// Exit if accessed directly
11			if( ! defined( 'ABSPATH' ) ) {
12			exit;
13			}
14
15
16			/**
17			* Register meta boxes
18			*
19			* @since 1.0.0
20			* @return void
21			*/
22			function printcenter_add_ssi_product_meta_boxes() {
23			add_meta_box( 'ssi-product-details', __( 'Details', 'printcenter' ), 'printcenter_render_ssi_product_details_meta_box', 'ssi_product', 'side', 'default' );
24			}
25			add_action( 'add_meta_boxes', 'printcenter_add_ssi_product_meta_boxes' );
26
27
28			/**
29			* Render details meta box
30			*
31			* @since 1.0.0
32			* @global object $post The post we are editing
33			* @return void
34			*/
35			function printcenter_render_ssi_product_details_meta_box() {
36			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2015-12-10 04:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
37
38			$ssi_sku = get_post_meta( $post->ID, '_ssi_sku', true );
39			?>
40			<p>
41			<label for="_ssi_sku"><?php _e( 'SSI SKU:', 'printcenter' ); ?></label>
42			<input type="text" class="widefat" id="_ssi_sku" name="_ssi_sku" value="<?php echo esc_attr( stripslashes( $ssi_sku ) ); ?>" />
43			</p>
44			<?php
45			// Allow extension of the meta box
46			do_action( 'printcenter_ssi_product_details_meta_box_fields', $post->ID );
47
48			wp_nonce_field( basename( __FILE__ ), 'printcenter_ssi_product_details_meta_box_nonce' );
49			}
50
51
52			/**
53			* Save post meta when the save_post action is called
54			*
55			* @since 1.0.0
56			* @param int $post_id The ID of the post we are saving
57			* @global object $post The post we are saving
58			* @return void
59			*/
60			function printcenter_ssi_product_meta_box_save( $post_id ) {
61			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2015-12-10 04:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
62
63			// Don't process if nonce can't be validated
64			if( ! isset( $_POST['printcenter_ssi_product_details_meta_box_nonce'] ) \|\| ! wp_verify_nonce( $_POST['printcenter_ssi_product_details_meta_box_nonce'], basename( __FILE__ ) ) ) return $post_id;
65
66			// Don't process if this is an autosave
67			if( ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) \|\| ( defined( 'DOING_AJAX' ) && DOING_AJAX ) \|\| isset( $_REQUEST['bulk_edit'] ) ) return $post_id;
68
69			// Don't process if this is a revision
70			if( isset( $post->post_type ) && $post->post_type == 'revision' ) return $post_id;
71
72			// The default fields that get saved
73			$fields = apply_filters( 'printcenter_ssi_product_meta_box_fields_save', array(
74			'_ssi_sku'
75			) );
76
77			foreach( $fields as $field ) {
78			if( isset( $_POST[ $field ] ) ) {
79			if( is_string( $_POST[ $field ] ) ) {
80			$new = esc_attr( $_POST[ $field ] );
81			} else {
82			$new = $_POST[ $field ];
83			}
84
85			$new = apply_filters( 'printcenter_ssi_product_meta_box_save_' . $field, $new );
86
87			update_post_meta( $post_id, $field, $new );
88			} else {
89			delete_post_meta( $post_id, $field );
90			}
91			}
92			}
93			add_action( 'save_post', 'printcenter_ssi_product_meta_box_save' );
94

Section214 / PrintCenter

Issues (130)

Security Analysis not enabled

includes/admin/ssi-products/meta-boxes.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like