UserController - Code Metrics - Inspection of "change Seed class" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b11988...18b0fe )

by wen

created 2017-05-23 09:21 UTC

UserController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	19.61 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
wmc	8
lcom	0
cbo	7
dl	10
loc	51
rs	10
c	4
b	2
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getList()	0	5	1
A	save()	0	17	3
A	delete()	10	10	2
A	saveRole()	0	7	1
A	getAllRole()	0	5	1

How to fix Duplicated Code

<?php


namespace Sco\Admin\Http\Controllers\Manager;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Admin\Http\Requests\ManagerRequest;
use Sco\Admin\Models\Manager;
use Sco\Admin\Models\Role;

class UserController extends Controller
{
    public function getList()
    {
        $users = Manager::with('roles')->paginate();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        return response()->json($users);
    }

    public function save(ManagerRequest $request)
    {
        if (empty($request->input('id'))) {
            $model = new Manager();
        } else {
            $model = Manager::findOrFail($request->input('id'));
        }
        $model->name = $request->input('name');
        $model->email = $request->input('email');
        if (!empty($request->input('password'))) {
            $model->password = $request->input('password');
        }

        $model->save();

        return response()->json(['message' => 'ok']);
    }

    public function delete($id)

    {
        if ($id == 1) {
            throw new AdminHttpException('超级管理员不能删除');
        }

        $model = Manager::findOrFail($id);
        $model->delete();
        return response()->json(['message' => 'ok']);
    }

    public function saveRole(Request $request)
    {
        $user = Manager::findOrFail($request->input('id'));
        $user->roles()->sync($request->input('roles'));

        return response()->json(['message' => 'ok']);
    }

    public function getAllRole()
    {
        $roles = Role::all();
        return response()->json($roles);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1		<?php
2
3
4		namespace Sco\Admin\Http\Controllers\Manager;
5
6		use Illuminate\Http\Request;
7		use Illuminate\Routing\Controller;
8		use Sco\Admin\Exceptions\AdminHttpException;
9		use Sco\Admin\Http\Requests\ManagerRequest;
10		use Sco\Admin\Models\Manager;
11		use Sco\Admin\Models\Role;
12
13		class UserController extends Controller
14		{
15		public function getList()
16		{
17		$users = Manager::with('roles')->paginate();
		0 ignored issues – show Bug introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report The method `paginate` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18		return response()->json($users);
19		}
20
21		public function save(ManagerRequest $request)
22		{
23		if (empty($request->input('id'))) {
24		$model = new Manager();
25		} else {
26		$model = Manager::findOrFail($request->input('id'));
27		}
28		$model->name = $request->input('name');
29		$model->email = $request->input('email');
30		if (!empty($request->input('password'))) {
31		$model->password = $request->input('password');
32		}
33
34		$model->save();
35
36		return response()->json(['message' => 'ok']);
37		}
38
39	View Code Duplication	public function delete($id)
		0 ignored issues – show Duplication introduced 2017-04-24 07:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		{
41		if ($id == 1) {
42		throw new AdminHttpException('超级管理员不能删除');
43		}
44
45		$model = Manager::findOrFail($id);
46		$model->delete();
47		return response()->json(['message' => 'ok']);
48		}
49
50		public function saveRole(Request $request)
51		{
52		$user = Manager::findOrFail($request->input('id'));
53		$user->roles()->sync($request->input('roles'));
54
55		return response()->json(['message' => 'ok']);
56		}
57
58		public function getAllRole()
59		{
60		$roles = Role::all();
61		return response()->json($roles);
		0 ignored issues – show Bug introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report It seems like `$roles` defined by `\Sco\Admin\Models\Role::all()` on line `60` can also be of type `object<Illuminate\Database\Eloquent\Collection>`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
62		}
63		}
64

ScoLib / admin

Push — master ( b11988...18b0fe )

UserController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like