Sco\Admin\Display\Table

Complexity

Total Complexity

13

Size/Duplication

Total Lines	87
Duplicated Lines	10.34 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	orderByFromRequest()	0	9	3
A	setColumns()	0	8	2
A	getColumns()	0	4	1
A	get()	9	10	2
A	toArray()	0	6	1
A	parseRows()	0	20	3

<?php

namespace Sco\Admin\Display;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;
use Sco\Admin\Contracts\Display\ColumnInterface;
use Sco\Admin\Display\Concerns\WithPagination;

class Table extends Display
{
    use WithPagination;

    protected $columns;

    protected $type = 'table';

    public function __construct()
    {
        parent::__construct();

        $this->columns = new Collection();
        $this->orderByFromRequest();
    }

    protected function orderByFromRequest()
    {
        $orderBy = request()->query('orderBy', '');
        $sortedBy = request()->query('sortedBy', '');

        if (! empty($orderBy) && ! empty($sortedBy)) {
            $this->orderBy($orderBy, $sortedBy);
        }
    }

    /**
     * @param array $columns
     *
     * @return $this
     */
    public function setColumns(array $columns)
    {
        foreach ($columns as $column) {
            $this->columns->push($column);
        }

        return $this;
    }

    /**
     * @return \Illuminate\Support\Collection
     */
    public function getColumns()
    {
        return $this->columns;
    }

    public function get()

This method seems to be duplicated in your project.

    {
        if ($this->isPagination()) {
            $data = $this->paginate();

            return $data->setCollection($this->parseRows($data->getCollection()));
        }

        return $this->parseRows($this->getQuery()->get());

It seems like $this->getQuery()->get() targeting Illuminate\Database\Eloquent\Builder::get() can also be of type array<integer,object<Illuminate\Database\Eloquent\Builder>>; however, Sco\Admin\Display\Table::parseRows() does only seem to accept object<Illuminate\Support\Collection>, maybe add an additional type check?

    }

    public function toArray()
    {
        return parent::toArray() + [
                'columns' => $this->getColumns(),
            ];
    }

    protected function parseRows(Collection $rows)
    {
        return $rows->map(function (Model $row) {
            $newRow = $this->getColumns()->mapWithKeys(function (
                ColumnInterface $column
            ) use ($row) {
                return [
                    $column->getName() => $column->setModel($row)->getValue(),
                ];
            });

            // whether this row has been soft deleted
            if ($this->getRepository()->isRestorable()) {
                $newRow->put('_deleted', $row->trashed() ? 1 : 0);
            }
            $newRow->put('_primary', $row->getKey());

            return $newRow;
        });
    }
}