Sco\Admin\Http\Controllers\System\MenuController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	111
Duplicated Lines	21.62 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getAdd()	0	9	2
A	postAdd()	12	12	1
A	getEdit()	0	7	1
A	postEdit()	12	12	1
A	getDelete()	0	3	1
A	getPermissionModel()	0	8	2
A	getList()	0	6	1

<?php

namespace Sco\Admin\Http\Controllers\System;

use Sco\Admin\Http\Controllers\BaseController;
use Illuminate\Http\Request;
use Sco\Admin\Models\Permission;

/**
 * 菜单管理
 *
 */
class MenuController extends BaseController
{
    private $permissionModel;

    /**
     * 菜单列表
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function getList()
    {
        $menus = $this->getPermissionModel()->getMenuTreeList();

        return response()->json($menus);
    }

    /**
     * 新增菜单
     *
     * @param int $pid
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function getAdd($pid = 0)
    {
        if ($pid) {

This if statement is empty and can be removed.

        }

        $menus = $this->getPermissionModel()->getMenuTreeList();
        //return response()->json($menus);
        return $this->render('system.menu.add', compact('menus'));
    }

    /**
     * 保存菜单信息
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function postAdd(Request $request)

This method seems to be duplicated in your project.

    {
        $this->validate($request, [
            'pid'          => 'integer',
            'display_name' => 'required',
            'name'         => ['bail', 'required', 'regex:/^[\w\.]+$/'],
            //'' => '',

67% of this comment could be valid code. Did you maybe forget this after debugging?

        ]);

        $this->getPermissionModel()->saveMenu($request);
        return response()->json(success('新增菜单完成', ['url' => route('admin.system.menu')]));
    }

    /**
     * 编辑菜单
     *
     * @param integer $id 菜单ID
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function getEdit($id)
    {
        $menu  = Permission::find($id);
        $menus = $this->getPermissionModel()->getMenuTreeList();
        return response()->json(success('ok', compact('menu', 'menus')));
        //return $this->render('system.menu.edit', compact('menu', 'menus'));

73% of this comment could be valid code. Did you maybe forget this after debugging?

    }

    /**
     * 保存菜单信息
     *
     * @param \Illuminate\Http\Request $request 提交数据
     * @param integer                  $id      菜单ID
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function postEdit(Request $request, $id)

This method seems to be duplicated in your project.

    {
        $this->validate($request, [
            'pid'          => 'integer',
            'display_name' => 'required',
            'name'         => ['bail', 'required', 'regex:/^[\w\.]+$/'],
            //'' => '',

67% of this comment could be valid code. Did you maybe forget this after debugging?

        ]);

        $this->getPermissionModel()->saveMenu($request, $id);
        return response()->json(success('编辑菜单完成', ['url' => route('admin.system.menu')]));
    }

    /**
     * 删除菜单
     *
     * @param integer $id
     */
    public function getDelete($id)
    {
    }


    /**
     * @return \Sco\Admin\Models\Permission
     */
    private function getPermissionModel()
    {
        if ($this->permissionModel) {
            return $this->permissionModel;
        }

        return $this->permissionModel = new Permission();
    }
}