Column::getValue() - Code Metrics - Inspection of "view column getValue" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1408f3...b929a0 )

by wen

created 2017-10-16 09:42 UTC

Column::getValue() A

↳ Parent: Column

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	5
nc	2
nop	0

<?php


namespace Sco\Admin\View\Columns;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Collection;
use Sco\Admin\Contracts\View\ColumnInterface;

abstract class Column implements ColumnInterface
{
    protected $name;

    protected $label;

    protected $width = 0;

    protected $minWidth = 80;

    protected $sortable = false;

    protected $fixed = false;

    /**
     * @var Model
     */
    protected $model;

    protected $defaultValue = '';

    protected $template = '<span>{{value}}</span>';

    public function __construct($name, $label)
    {
        $this->name  = $name;
        $this->label = $label;
    }

    public function getName()
    {
        return $this->name;
    }

    public function setWidth($width)
    {
        $this->width = $width;

        return $this;
    }

    public function setMinWidth($width)
    {
        $this->minWidth = $width;

        return $this;
    }

    public function isSortable()
    {
        $this->sortable = true;

        return $this;
    }

    public function isCustomSortable()
    {
        $this->sortable = 'custom';
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        // TODO
        // register sort route

        return $this;
    }

    public function isFixed()
    {
        $this->fixed = true;

        return $this;
    }

    public function getModel()
    {
        return $this->model;
    }

    public function setModel(Model $model)
    {
        $this->model = $model;

        return $this;
    }

    public function getTemplate()
    {
        return $this->template;
    }

    public function setTemplate($template)
    {
        $this->template = $template;

        return $this;
    }

    public function toArray()
    {
        return [
            'name'     => $this->getName(),
            'label'    => $this->label,
            'width'    => $this->width,
            'fixed'    => $this->fixed,
            'minWidth' => $this->minWidth,
            'sortable' => $this->sortable,
            'template' => $this->getTemplate(),
        ];
    }

    public function setDefaultValue($value)
    {
        $this->defaultValue = $value;

        return $this;
    }

    public function getDefaultValue()
    {
        return $this->defaultValue;
    }

    public function getValue()
    {
        $value = $this->getModelValue();
        if (is_null($value)) {
            $value = $this->getDefaultValue();
        }
        return $value;
    }

    protected function getModelValue()
    {
        return $this->getValueFromObject($this->getModel(), $this->getName());
    }

    protected function getValueFromObject($instance, $name)
    {
        $parts = explode('.', $name);
        $part = array_shift($parts);

        if ($instance instanceof Collection) {
            $instance = $instance->pluck($part);
        } elseif (!is_null($instance)) {
            $instance = $instance->getAttribute($part);
        }

        if (!empty($parts) && !is_null($instance)) {
            return $this->getValueFromObject($instance, implode('.', $parts));
        }

        return $instance;
    }

    public function jsonSerialize()
    {
        return $this->toArray();
    }

    public function toJson($options = 0)
    {
        return json_encode($this->jsonSerialize(), $options);
    }

    public function __toString()
    {
        return $this->toJson();
    }
}


1			<?php
2
3
4			namespace Sco\Admin\View\Columns;
5
6			use Illuminate\Database\Eloquent\Model;
7			use Illuminate\Support\Collection;
8			use Sco\Admin\Contracts\View\ColumnInterface;
9
10			abstract class Column implements ColumnInterface
11			{
12			protected $name;
13
14			protected $label;
15
16			protected $width = 0;
17
18			protected $minWidth = 80;
19
20			protected $sortable = false;
21
22			protected $fixed = false;
23
24			/**
25			* @var Model
26			*/
27			protected $model;
28
29			protected $defaultValue = '';
30
31			protected $template = '<span>{{value}}</span>';
32
33			public function __construct($name, $label)
34			{
35			$this->name = $name;
36			$this->label = $label;
37			}
38
39			public function getName()
40			{
41			return $this->name;
42			}
43
44			public function setWidth($width)
45			{
46			$this->width = $width;
47
48			return $this;
49			}
50
51			public function setMinWidth($width)
52			{
53			$this->minWidth = $width;
54
55			return $this;
56			}
57
58			public function isSortable()
59			{
60			$this->sortable = true;
61
62			return $this;
63			}
64
65			public function isCustomSortable()
66			{
67			$this->sortable = 'custom';
			0 ignored issues – show Documentation Bug introduced 2017-07-17 09:49 UTC by Report Bug Copy Issue Report The property `$sortable` was declared of type `boolean`, but `'custom'` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
68			// TODO
69			// register sort route
70
71			return $this;
72			}
73
74			public function isFixed()
75			{
76			$this->fixed = true;
77
78			return $this;
79			}
80
81			public function getModel()
82			{
83			return $this->model;
84			}
85
86			public function setModel(Model $model)
87			{
88			$this->model = $model;
89
90			return $this;
91			}
92
93			public function getTemplate()
94			{
95			return $this->template;
96			}
97
98			public function setTemplate($template)
99			{
100			$this->template = $template;
101
102			return $this;
103			}
104
105			public function toArray()
106			{
107			return [
108			'name' => $this->getName(),
109			'label' => $this->label,
110			'width' => $this->width,
111			'fixed' => $this->fixed,
112			'minWidth' => $this->minWidth,
113			'sortable' => $this->sortable,
114			'template' => $this->getTemplate(),
115			];
116			}
117
118			public function setDefaultValue($value)
119			{
120			$this->defaultValue = $value;
121
122			return $this;
123			}
124
125			public function getDefaultValue()
126			{
127			return $this->defaultValue;
128			}
129
130			public function getValue()
131			{
132			$value = $this->getModelValue();
133			if (is_null($value)) {
134			$value = $this->getDefaultValue();
135			}
136			return $value;
137			}
138
139			protected function getModelValue()
140			{
141			return $this->getValueFromObject($this->getModel(), $this->getName());
142			}
143
144			protected function getValueFromObject($instance, $name)
145			{
146			$parts = explode('.', $name);
147			$part = array_shift($parts);
148
149			if ($instance instanceof Collection) {
150			$instance = $instance->pluck($part);
151			} elseif (!is_null($instance)) {
152			$instance = $instance->getAttribute($part);
153			}
154
155			if (!empty($parts) && !is_null($instance)) {
156			return $this->getValueFromObject($instance, implode('.', $parts));
157			}
158
159			return $instance;
160			}
161
162			public function jsonSerialize()
163			{
164			return $this->toArray();
165			}
166
167			public function toJson($options = 0)
168			{
169			return json_encode($this->jsonSerialize(), $options);
170			}
171
172			public function __toString()
173			{
174			return $this->toJson();
175			}
176			}
177

ScoLib / admin

Push — master ( 1408f3...b929a0 )

Column::getValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like