Sco\Admin\Component\Concerns\HasNavigation

Complexity

Total Complexity

8

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getNavigation()	0	4	1
A	addToNavigation()	0	6	1
A	makePage()	0	18	3
A	getViewUrl()	0	6	1
A	getIcon()	0	4	1
A	setIcon()	0	6	1

<?php

namespace Sco\Admin\Component\Concerns;

use KodiComponents\Navigation\Contracts\BadgeInterface;
use Sco\Admin\Navigation\Badge;
use Sco\Admin\Navigation\Page;

trait HasNavigation
{
    protected $icon;

    /**
     * {@inheritdoc}
     */
    public function getNavigation()
    {
        return $this->app['admin.navigation'];

The property app does not exist. Did you maybe forget to declare it?

    }

    /**
     * {@inheritdoc}
     */
    public function addToNavigation($priority = 100, $badge = null)
    {
        $page = $this->makePage($priority, $badge);
        $this->getNavigation()->addPage($page);
        return $page;
    }

    /**
     * page
     *
     * @param int  $priority
     * @param null $badge
     *
     * @return \Sco\Admin\Navigation\Page
     */
    protected function makePage($priority = 100, $badge = null)
    {
        $page = new Page($this);
        $page->setPriority($priority)
            ->setIcon($this->getIcon())
            ->setAccessLogic(function () {
                return $this->isView();

It seems like isView() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            });

        if ($badge) {
            if (!($badge instanceof BadgeInterface)) {
                $badge = new Badge($badge);
            }
            $page->addBadge($badge);
        }

        return $page;
    }

    /**
     * @param array $parameters
     *
     * @return string
     */
    public function getViewUrl(array $parameters = [])
    {
        array_unshift($parameters, $this->getName());

It seems like getName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return route('admin.model.index', $parameters, false);
    }

    public function getIcon()
    {
        return $this->icon;
    }

    public function setIcon($value)
    {
        $this->icon = $value;

        return $this;
    }
}