Component - Code Metrics - Inspection of "add error page 500" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 956296...cca79d )

by wen

created 2017-08-16 10:16 UTC

Component B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	314
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	51
lcom	1
cbo	8
dl	0
loc	314
rs	8.3206
c	0
b	0
f	0

30 Methods

Rating	Name	Size	Complexity
A	__construct()	16	2
A	setDefaultName()	4	1
A	getModelClassName()	4	1
A	getName()	4	1
A	getTitle()	4	1
A	getModel()	4	1
A	getRepository()	4	1
A	getConfigs()	10	1
A	fireView()	14	3
A	get()	10	1
A	fireCreate()	15	3
A	store()	6	1
A	fireEdit()	18	3
A	update()	5	1
A	delete()	5	1
A	forceDelete()	5	1
A	restore()	5	1
A	bootIfNotBooted()	12	2
A	boot()	4	1
A	isView()	4	2
A	isCreate()	4	2
A	isEdit()	4	2
A	isDelete()	4	1
A	isDestroy()	4	2
A	isRestore()	4	2
A	isRestorableModel()	4	1
B	registerObserver()	17	5
A	registerPermission()	4	1
A	can()	7	3
A	getPermissions()	13	3

How to fix Complexity

<?php

namespace Sco\Admin\Component;

use Illuminate\Foundation\Application;
use Illuminate\Http\Request;
use Sco\Admin\Component\Concerns\HasEvents;
use Sco\Admin\Component\Concerns\HasNavigation;
use Sco\Admin\Contracts\ComponentInterface;
use Sco\Admin\Contracts\Form\FormInterface;
use Sco\Admin\Contracts\RepositoryInterface;
use Sco\Admin\Contracts\View\ViewInterface;
use Sco\Admin\Contracts\WithNavigation;
use Sco\Admin\Exceptions\BadMethodCallException;
use Sco\Admin\Exceptions\InvalidArgumentException;

abstract class Component implements
    ComponentInterface,
    WithNavigation
{
    use HasEvents,
        HasNavigation;

    /**
     * @var
     */
    protected $name;

    /**
     * @var \Illuminate\Foundation\Application
     */
    protected $app;

    protected $title;

    /**
     * @var mixed|\Sco\Admin\Contracts\RepositoryInterface
     */
    protected $repository;

    /**
     * @var \Illuminate\Database\Eloquent\Model
     */
    protected $model;

    protected static $booted = [];

    /**
     * @var \Illuminate\Contracts\Events\Dispatcher
     */
    protected static $dispatcher;

    /**
     * @var string
     */
    protected $permissionObserver;

    protected $permissions;

    protected $permissionMethods = [
        'view', 'create', 'edit',
        'delete', 'destroy', 'restore',
    ];

    public function __construct(Application $app, $modelClass)
    {
        $this->app = $app;

        $this->repository = $this->app->make(RepositoryInterface::class);
        $this->repository->setClass($modelClass);

        $this->model = $this->repository->getModel();
        if (!$this->name) {
            $this->setDefaultName();
        }

        $this->registerObserver($this->permissionObserver);

        $this->bootIfNotBooted();
    }

    protected function setDefaultName()
    {
        $this->name = $this->getModelClassName();
    }

    protected function getModelClassName()
    {
        return snake_case(str_plural(class_basename(get_class($this->getModel()))));
    }

    public function getName()
    {
        return $this->name;
    }

    public function getTitle()
    {
        return $this->title;
    }

    public function getModel()
    {
        return $this->model;
    }

    public function getRepository()
    {
        return $this->repository;
    }

    /**
     * {@inheritdoc}
     */
    public function getConfigs()
    {
        return collect([
            'primaryKey'  => $this->getModel()->getKeyName(),
            'title'       => $this->getTitle(),
            'permissions' => $this->getPermissions(),
            'view'        => $this->fireView(),
            //'elements'    => $this->getElements()->values(),

        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function fireView()
    {
        if (!method_exists($this, 'callView')) {
            throw new BadMethodCallException('Not Found Method "callView"');
        }

        $view = $this->app->call([$this, 'callView']);

        if (!$view instanceof ViewInterface) {
            throw new InvalidArgumentException('callView must be instanced of Sco\Admin\Contracts\View\ViewInterface');
        }

        return $view;
    }

    public function get()
    {
        $view = $this->fireView();

        $this->getRepository();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

        $view->setRepository($this->getRepository());

        return $view->get();
    }

    /**
     * {@inheritdoc}
     */
    public function fireCreate()
    {
        if (!method_exists($this, 'callCreate')) {
            return;
        }

        $form = $this->app->call([$this, 'callCreate']);
        if (!$form instanceof FormInterface) {
            throw new InvalidArgumentException('callCreate must be instanced of Sco\Admin\Contracts\Form\FormInterface');
        }

        $form->setModel($this->getModel());

        return $form;
    }

    /**
     * {@inheritdoc}
     */
    public function store()
    {
        $form = $this->fireCreate();

        $form->validate()->save();
    }

    /**
     * {@inheritdoc}
     */
    public function fireEdit($id)
    {
        if (!method_exists($this, 'callEdit')) {
            return;
        }

        $form = $this->app->call([$this, 'callEdit'], ['id' => $id]);

        if (!$form instanceof ViewInterface) {
            throw new InvalidArgumentException('callEdit must be instanced of Sco\Admin\Contracts\View\ViewInterface');
        }

        $model = $this->getRepository()->findOrFail($id);

        $form->setModel($model);


        return $form;
    }

    /**
     * {@inheritdoc}
     */
    public function update($id)
    {
        $form = $this->fireEdit($id);
        $form->validate()->save();

    }

    public function delete($id)
    {
        $this->getRepository()->findOrFail($id)->delete();
        return true;
    }

    public function forceDelete($id)
    {
        $this->getRepository()->forceDelete($id);
        return true;
    }

    public function restore($id)
    {
        $this->getRepository()->restore($id);
        return true;
    }

    protected function bootIfNotBooted()
    {
        if (!isset(static::$booted[static::class])) {
            static::$booted[static::class] = true;

            $this->fireEvent('booting', false);

            $this->boot();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

            $this->fireEvent('booted', false);
        }
    }

    public function boot()
    {
        return true;
    }

    public function isView()
    {
        return method_exists($this, 'callView') && $this->can('view');
    }

    public function isCreate()
    {
        return method_exists($this, 'callCreate') && $this->can('create');
    }

    public function isEdit()
    {
        return method_exists($this, 'callEdit') && $this->can('edit');
    }

    public function isDelete()
    {
        return $this->can('delete');
    }

    public function isDestroy()
    {
        return $this->isRestorableModel() && $this->can('destroy');
    }

    public function isRestore()
    {
        return $this->isRestorableModel() && $this->can('restore');
    }

    protected function isRestorableModel()
    {
        return $this->getRepository()->isRestorable();
    }

    public function registerObserver($class = null)
    {
        if (!$class) {
            return;
        }

        $className = is_string($class) ? $class : get_class($class);

        foreach ($this->permissionMethods as $method) {
            if (method_exists($class, $method)) {
                $this->registerPermission(
                    $method,
                    [$this->app->make($className), $method]
                );
            }
        }
    }

    public function registerPermission($permission, $callback)
    {
        $this->permissions[$permission] = $callback;
    }

    public function can($permission)
    {
        if (is_callable($this->permissions[$permission])) {
            return call_user_func_array($this->permissions[$permission], [$this]);
        }
        return $this->permissions[$permission] ? true : false;
    }

    public function getPermissions()
    {
        $data = collect();
        foreach ($this->permissionMethods as $perm) {
            $method = 'is' . ucfirst($perm);
            if (!method_exists($this, $method)) {
                $method = 'can';
            }

            $data->put($perm, $this->{$method}($perm));
        }
        return $data;
    }
}


1			<?php
2
3			namespace Sco\Admin\Component;
4
5			use Illuminate\Foundation\Application;
6			use Illuminate\Http\Request;
7			use Sco\Admin\Component\Concerns\HasEvents;
8			use Sco\Admin\Component\Concerns\HasNavigation;
9			use Sco\Admin\Contracts\ComponentInterface;
10			use Sco\Admin\Contracts\Form\FormInterface;
11			use Sco\Admin\Contracts\RepositoryInterface;
12			use Sco\Admin\Contracts\View\ViewInterface;
13			use Sco\Admin\Contracts\WithNavigation;
14			use Sco\Admin\Exceptions\BadMethodCallException;
15			use Sco\Admin\Exceptions\InvalidArgumentException;
16
17			abstract class Component implements
18			ComponentInterface,
19			WithNavigation
20			{
21			use HasEvents,
22			HasNavigation;
23
24			/**
25			* @var
26			*/
27			protected $name;
28
29			/**
30			* @var \Illuminate\Foundation\Application
31			*/
32			protected $app;
33
34			protected $title;
35
36			/**
37			* @var mixed\|\Sco\Admin\Contracts\RepositoryInterface
38			*/
39			protected $repository;
40
41			/**
42			* @var \Illuminate\Database\Eloquent\Model
43			*/
44			protected $model;
45
46			protected static $booted = [];
47
48			/**
49			* @var \Illuminate\Contracts\Events\Dispatcher
50			*/
51			protected static $dispatcher;
52
53			/**
54			* @var string
55			*/
56			protected $permissionObserver;
57
58			protected $permissions;
59
60			protected $permissionMethods = [
61			'view', 'create', 'edit',
62			'delete', 'destroy', 'restore',
63			];
64
65			public function __construct(Application $app, $modelClass)
66			{
67			$this->app = $app;
68
69			$this->repository = $this->app->make(RepositoryInterface::class);
70			$this->repository->setClass($modelClass);
71
72			$this->model = $this->repository->getModel();
73			if (!$this->name) {
74			$this->setDefaultName();
75			}
76
77			$this->registerObserver($this->permissionObserver);
78
79			$this->bootIfNotBooted();
80			}
81
82			protected function setDefaultName()
83			{
84			$this->name = $this->getModelClassName();
85			}
86
87			protected function getModelClassName()
88			{
89			return snake_case(str_plural(class_basename(get_class($this->getModel()))));
90			}
91
92			public function getName()
93			{
94			return $this->name;
95			}
96
97			public function getTitle()
98			{
99			return $this->title;
100			}
101
102			public function getModel()
103			{
104			return $this->model;
105			}
106
107			public function getRepository()
108			{
109			return $this->repository;
110			}
111
112			/**
113			* {@inheritdoc}
114			*/
115			public function getConfigs()
116			{
117			return collect([
118			'primaryKey' => $this->getModel()->getKeyName(),
119			'title' => $this->getTitle(),
120			'permissions' => $this->getPermissions(),
121			'view' => $this->fireView(),
122			//'elements' => $this->getElements()->values(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-18 09:48 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
123			]);
124			}
125
126			/**
127			* {@inheritdoc}
128			*/
129			public function fireView()
130			{
131			if (!method_exists($this, 'callView')) {
132			throw new BadMethodCallException('Not Found Method "callView"');
133			}
134
135			$view = $this->app->call([$this, 'callView']);
136
137			if (!$view instanceof ViewInterface) {
138			throw new InvalidArgumentException('callView must be instanced of Sco\Admin\Contracts\View\ViewInterface');
139			}
140
141			return $view;
142			}
143
144			public function get()
145			{
146			$view = $this->fireView();
147
148			$this->getRepository();
			0 ignored issues – show Unused Code introduced 2017-07-24 08:59 UTC by Report Bug Copy Issue Report The call to the method `Sco\Admin\Component\Component::getRepository()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
149
150			$view->setRepository($this->getRepository());
151
152			return $view->get();
153			}
154
155			/**
156			* {@inheritdoc}
157			*/
158			public function fireCreate()
159			{
160			if (!method_exists($this, 'callCreate')) {
161			return;
162			}
163
164			$form = $this->app->call([$this, 'callCreate']);
165			if (!$form instanceof FormInterface) {
166			throw new InvalidArgumentException('callCreate must be instanced of Sco\Admin\Contracts\Form\FormInterface');
167			}
168
169			$form->setModel($this->getModel());
170
171			return $form;
172			}
173
174			/**
175			* {@inheritdoc}
176			*/
177			public function store()
178			{
179			$form = $this->fireCreate();
180
181			$form->validate()->save();
182			}
183
184			/**
185			* {@inheritdoc}
186			*/
187			public function fireEdit($id)
188			{
189			if (!method_exists($this, 'callEdit')) {
190			return;
191			}
192
193			$form = $this->app->call([$this, 'callEdit'], ['id' => $id]);
194
195			if (!$form instanceof ViewInterface) {
196			throw new InvalidArgumentException('callEdit must be instanced of Sco\Admin\Contracts\View\ViewInterface');
197			}
198
199			$model = $this->getRepository()->findOrFail($id);
200
201			$form->setModel($model);
			0 ignored issues – show Bug introduced 2017-08-16 10:19 UTC by Report Bug Copy Issue Report The method `setModel()` does not seem to exist on `object<Sco\Admin\Contracts\View\ViewInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
202
203			return $form;
204			}
205
206			/**
207			* {@inheritdoc}
208			*/
209			public function update($id)
210			{
211			$form = $this->fireEdit($id);
212			$form->validate()->save();
			0 ignored issues – show Bug introduced 2017-08-16 10:19 UTC by Report Bug Copy Issue Report The method `validate()` does not seem to exist on `object<Sco\Admin\Contracts\View\ViewInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
213			}
214
215			public function delete($id)
216			{
217			$this->getRepository()->findOrFail($id)->delete();
218			return true;
219			}
220
221			public function forceDelete($id)
222			{
223			$this->getRepository()->forceDelete($id);
224			return true;
225			}
226
227			public function restore($id)
228			{
229			$this->getRepository()->restore($id);
230			return true;
231			}
232
233			protected function bootIfNotBooted()
234			{
235			if (!isset(static::$booted[static::class])) {
236			static::$booted[static::class] = true;
237
238			$this->fireEvent('booting', false);
239
240			$this->boot();
			0 ignored issues – show Unused Code introduced 2017-07-18 12:53 UTC by Report Bug Copy Issue Report The call to the method `Sco\Admin\Component\Component::boot()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
241
242			$this->fireEvent('booted', false);
243			}
244			}
245
246			public function boot()
247			{
248			return true;
249			}
250
251			public function isView()
252			{
253			return method_exists($this, 'callView') && $this->can('view');
254			}
255
256			public function isCreate()
257			{
258			return method_exists($this, 'callCreate') && $this->can('create');
259			}
260
261			public function isEdit()
262			{
263			return method_exists($this, 'callEdit') && $this->can('edit');
264			}
265
266			public function isDelete()
267			{
268			return $this->can('delete');
269			}
270
271			public function isDestroy()
272			{
273			return $this->isRestorableModel() && $this->can('destroy');
274			}
275
276			public function isRestore()
277			{
278			return $this->isRestorableModel() && $this->can('restore');
279			}
280
281			protected function isRestorableModel()
282			{
283			return $this->getRepository()->isRestorable();
284			}
285
286			public function registerObserver($class = null)
287			{
288			if (!$class) {
289			return;
290			}
291
292			$className = is_string($class) ? $class : get_class($class);
293
294			foreach ($this->permissionMethods as $method) {
295			if (method_exists($class, $method)) {
296			$this->registerPermission(
297			$method,
298			[$this->app->make($className), $method]
299			);
300			}
301			}
302			}
303
304			public function registerPermission($permission, $callback)
305			{
306			$this->permissions[$permission] = $callback;
307			}
308
309			public function can($permission)
310			{
311			if (is_callable($this->permissions[$permission])) {
312			return call_user_func_array($this->permissions[$permission], [$this]);
313			}
314			return $this->permissions[$permission] ? true : false;
315			}
316
317			public function getPermissions()
318			{
319			$data = collect();
320			foreach ($this->permissionMethods as $perm) {
321			$method = 'is' . ucfirst($perm);
322			if (!method_exists($this, $method)) {
323			$method = 'can';
324			}
325
326			$data->put($perm, $this->{$method}($perm));
327			}
328			return $data;
329			}
330			}
331

ScoLib / admin

Push — master ( 956296...cca79d )

Component B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

30 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like