EntrustPermissionTrait::bootEntrustPermissionTrait() - Code Metrics - Inspection of "change rbac controller" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 80411a...1281a7 )

by wen

created 2017-05-27 09:32 UTC

bootEntrustPermissionTrait() A

↳ Parent: EntrustPermissionTrait

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	1
nop	0

<?php

namespace Sco\Admin\Traits;

/**
 * This file is part of Entrust,
 * a role & permission management solution for Laravel.
 *
 * @license MIT
 * @package Zizaco\Entrust
 */

use Illuminate\Support\Facades\Config;
use Sco\Admin\Models\Role;

trait EntrustPermissionTrait
{
    /**
     * Many-to-Many relations with role model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function roles()
    {
        return $this->belongsToMany(Config::get('admin.role'),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Config::get('admin.permission_role_table'),
            Config::get('admin.permission_foreign_key'),
            Config::get('admin.role_foreign_key'));
    }

    /**
     * Boot the permission model
     * Attach event listener to remove the many-to-many records when trying to
     * delete Will NOT delete any records if the permission model uses soft
     * deletes.
     *
     * @return void|bool
     */
    public static function bootEntrustPermissionTrait()
    {
        static::deleting(function ($permission) {
            if (!method_exists(Config::get('admin.permission'),
                'bootSoftDeletes')
            ) {
                $permission->roles()->sync([]);
            }

            return true;
        });
    }
}


1			<?php
2
3			namespace Sco\Admin\Traits;
4
5			/**
6			* This file is part of Entrust,
7			* a role & permission management solution for Laravel.
8			*
9			* @license MIT
10			* @package Zizaco\Entrust
11			*/
12
13			use Illuminate\Support\Facades\Config;
14			use Sco\Admin\Models\Role;
15
16			trait EntrustPermissionTrait
17			{
18			/**
19			* Many-to-Many relations with role model.
20			*
21			* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
22			*/
23			public function roles()
24			{
25			return $this->belongsToMany(Config::get('admin.role'),
			0 ignored issues – show Bug introduced 2017-05-24 08:55 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			Config::get('admin.permission_role_table'),
27			Config::get('admin.permission_foreign_key'),
28			Config::get('admin.role_foreign_key'));
29			}
30
31			/**
32			* Boot the permission model
33			* Attach event listener to remove the many-to-many records when trying to
34			* delete Will NOT delete any records if the permission model uses soft
35			* deletes.
36			*
37			* @return void\|bool
38			*/
39			public static function bootEntrustPermissionTrait()
40			{
41			static::deleting(function ($permission) {
42			if (!method_exists(Config::get('admin.permission'),
43			'bootSoftDeletes')
44			) {
45			$permission->roles()->sync([]);
46			}
47
48			return true;
49			});
50			}
51			}
52

ScoLib / admin

Push — master ( 80411a...1281a7 )

bootEntrustPermissionTrait() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like