Sco\Admin\Http\Controllers\Users\UserController::save()

Complexity

Conditions	3
Paths	4

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	UserController::getList()	0	5	1
A	UserController::store()	0	8	1

<?php


namespace Sco\Admin\Http\Controllers\Users;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Admin\Http\Requests\StoreUserRequest;
use Sco\Admin\Http\Requests\UpdateUserRequest;
use Sco\Admin\Models\Role;

class UserController extends Controller
{

    /**
     * @return \Illuminate\Foundation\Auth\User
     */
    private function getUserModel()
    {
        $userModelName = config('admin.user');
        return new $userModelName();
    }

    public function getList()
    {
        $users = $this->getUserModel()->with('roles')->paginate();

The method paginate does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

        return response()->json($users);
    }

    public function store(StoreUserRequest $request)
    {
        $model = $this->getUserModel();
        $data = $request->only(['name', 'email', 'password']);
        $data['password'] = bcrypt($data['password']);
        $model->fill($data)->save();
        return response()->json(['message' => 'ok']);
    }

    public function update(UpdateUserRequest $request)
    {
        $user = $this->getUserModel()->findOrFail($request->input('id'));
        $data = $request->only(['name', 'email']);
        if (!empty($request->input('password'))) {
            $data['password'] = bcrypt($request->input('password'));

It seems like $request->input('password') targeting Illuminate\Http\Concerns\InteractsWithInput::input() can also be of type array; however, bcrypt() does only seem to accept string, maybe add an additional type check?

        }
        $user->fill($data)->save();
        return response()->json(['message' => 'ok']);
    }

    public function delete($id)

This method seems to be duplicated in your project.

    {
        if ($id == 1) {
            throw new AdminHttpException('超级管理员不能删除');
        }

        $model = $this->getUserModel()->findOrFail($id);
        $model->delete();
        return response()->json(['message' => 'ok']);
    }

    public function saveRole(Request $request)
    {
        $user = $this->getUserModel()->findOrFail($request->input('id'));
        $user->roles()->sync($request->input('roles'));

        return response()->json(['message' => 'ok']);
    }

    public function getAllRole()
    {
        $roles = Role::all();
        return response()->json($roles);

It seems like $roles defined by \Sco\Admin\Models\Role::all() on line 72 can also be of type object<Illuminate\Database\Eloquent\Collection>; however, Illuminate\Contracts\Routing\ResponseFactory::json() does only seem to accept string|array, maybe add an additional type check?

    }
}