Sco\Admin\Http\Controllers\Users\RoleController::save()

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	RoleController::store()	0	10	1

<?php


namespace Sco\Admin\Http\Controllers\Users;

use Auth;
use DB;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Admin\Http\Requests\StoreRoleRequest;
use Sco\Admin\Http\Requests\UpdateRoleRequest;
use Sco\Admin\Models\Permission;
use Sco\Admin\Models\Role;

class RoleController extends Controller
{
    public function get($id)
    {
        return Role::with(['perms' => function ($query) {

The method findOrFail does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            return $query->select('id');
        }])->findOrFail($id);
    }

    public function getList()
    {
        $roles = Role::paginate();
        return response()->json($roles);
    }

    public function getPermissionList()
    {
        $perms = (new Permission())->getPermRouteList();
        return response()->json($perms, 200, [], JSON_FORCE_OBJECT);

$perms is of type object<Illuminate\Support\Collection>|null, but the function expects a string|array.

    }

    public function store(StoreRoleRequest $request)
    {
        $role = new Role();
        $role->fill($request->input());

It seems like $request->input() targeting Illuminate\Http\Concerns\InteractsWithInput::input() can also be of type string; however, Illuminate\Database\Eloquent\Model::fill() does only seem to accept array, maybe add an additional type check?

        DB::transaction(function () use ($role, $request) {
            $role->save();
            $role->savePermissions($request->input('perms'));
        });
        return response()->json(['message' => 'ok']);
    }

    public function update(UpdateRoleRequest $request)
    {
        $role = Role::findOrFail($request->input('id'));
        if ($role->name == 'admin' && !Auth::user()->hasRole($role->name)) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        $role->fill($request->input());
        DB::transaction(function () use ($role, $request) {
            $role->save();
            $role->savePermissions($request->input('perms'));
        });
        return response()->json(['message' => 'ok']);
    }

    public function destroy($id)

This method seems to be duplicated in your project.

    {
        $role = Role::findOrFail($id);
        if ($role->name == 'admin') {
            throw new AdminHttpException('超级管理员角色不能删除');
        }

        $role->delete();

        return response()->json(['message' => 'ok']);
    }

    /**
     * 批量删除角色
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function batchDestroy(Request $request)
    {
        if (!is_array($request->input('ids'))) {
            throw new AdminHttpException('参数错误');
        }

        DB::transaction(function () use ($request) {
            foreach ($request->input('ids') as $id) {

The expression $request->input('ids') of type string|array is not guaranteed to be traversable. How about adding an additional type check?

                $role = Role::findOrFail($id);
                if ($role->name == 'admin') {
                    throw new AdminHttpException('超级管理员角色不能删除');
                }

                $role->delete();
            }
        });

        return response()->json(['message' => 'ok']);
    }
}