RoleController::destroy() - Code Metrics - Inspection of "change rbac controller" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 80411a...1281a7 )

by wen

created 2017-05-27 09:32 UTC

RoleController::destroy() A

↳ Parent: RoleController

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
dl	11
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1

<?php


namespace Sco\Admin\Http\Controllers\Users;

use Auth;
use DB;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Admin\Http\Requests\StoreRoleRequest;
use Sco\Admin\Http\Requests\UpdateRoleRequest;
use Sco\Admin\Models\Permission;
use Sco\Admin\Models\Role;

class RoleController extends Controller
{
    public function get($id)
    {
        return Role::with(['perms' => function ($query) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return $query->select('id');
        }])->findOrFail($id);
    }

    public function getList()
    {
        $roles = Role::paginate();
        return response()->json($roles);
    }

    public function getPermissionList()
    {
        $perms = (new Permission())->getPermRouteList();
        return response()->json($perms, 200, [], JSON_FORCE_OBJECT);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function store(StoreRoleRequest $request)
    {
        $role = new Role();
        $role->fill($request->input());

        DB::transaction(function () use ($role, $request) {
            $role->save();
            $role->savePermissions($request->input('perms'));
        });
        return response()->json(['message' => 'ok']);
    }

    public function update(UpdateRoleRequest $request)
    {
        $role = Role::findOrFail($request->input('id'));
        if ($role->name == 'admin' && !Auth::user()->hasRole($role->name)) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        $role->fill($request->input());
        DB::transaction(function () use ($role, $request) {
            $role->save();
            $role->savePermissions($request->input('perms'));
        });
        return response()->json(['message' => 'ok']);
    }

    public function destroy($id)

    {
        $role = Role::findOrFail($id);
        if ($role->name == 'admin') {
            throw new AdminHttpException('超级管理员角色不能删除');
        }

        $role->delete();

        return response()->json(['message' => 'ok']);
    }

    /**
     * 批量删除角色
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function batchDestroy(Request $request)
    {
        if (!is_array($request->input('ids'))) {
            throw new AdminHttpException('参数错误');
        }

        DB::transaction(function () use ($request) {
            foreach ($request->input('ids') as $id) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $role = Role::findOrFail($id);
                if ($role->name == 'admin') {
                    throw new AdminHttpException('超级管理员角色不能删除');
                }

                $role->delete();
            }
        });

        return response()->json(['message' => 'ok']);
    }
}


1		<?php
2
3
4		namespace Sco\Admin\Http\Controllers\Users;
5
6		use Auth;
7		use DB;
8		use Illuminate\Http\Request;
9		use Illuminate\Routing\Controller;
10		use Sco\Admin\Exceptions\AdminHttpException;
11		use Sco\Admin\Http\Requests\StoreRoleRequest;
12		use Sco\Admin\Http\Requests\UpdateRoleRequest;
13		use Sco\Admin\Models\Permission;
14		use Sco\Admin\Models\Role;
15
16		class RoleController extends Controller
17		{
18		public function get($id)
19		{
20		return Role::with(['perms' => function ($query) {
		0 ignored issues – show Bug introduced 2017-05-08 13:04 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21		return $query->select('id');
22		}])->findOrFail($id);
23		}
24
25		public function getList()
26		{
27		$roles = Role::paginate();
28		return response()->json($roles);
29		}
30
31		public function getPermissionList()
32		{
33		$perms = (new Permission())->getPermRouteList();
34		return response()->json($perms, 200, [], JSON_FORCE_OBJECT);
		0 ignored issues – show Documentation introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report `$perms` is of type `object<Illuminate\Support\Collection>\|null`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
35		}
36
37		public function store(StoreRoleRequest $request)
38		{
39		$role = new Role();
40		$role->fill($request->input());
		0 ignored issues – show Bug introduced 2017-05-27 09:35 UTC by Report Bug Copy Issue Report It seems like `$request->input()` targeting `Illuminate\Http\Concerns...ractsWithInput::input()` can also be of type `string`; however, `Illuminate\Database\Eloquent\Model::fill()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
41		DB::transaction(function () use ($role, $request) {
42		$role->save();
43		$role->savePermissions($request->input('perms'));
44		});
45		return response()->json(['message' => 'ok']);
46		}
47
48		public function update(UpdateRoleRequest $request)
49		{
50		$role = Role::findOrFail($request->input('id'));
51		if ($role->name == 'admin' && !Auth::user()->hasRole($role->name)) {
52		return response()->json(['error' => 'Unauthenticated.'], 401);
53		}
54
55		$role->fill($request->input());
56		DB::transaction(function () use ($role, $request) {
57		$role->save();
58		$role->savePermissions($request->input('perms'));
59		});
60		return response()->json(['message' => 'ok']);
61		}
62
63	View Code Duplication	public function destroy($id)
		0 ignored issues – show Duplication introduced 2017-05-27 09:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$role = Role::findOrFail($id);
66		if ($role->name == 'admin') {
67		throw new AdminHttpException('超级管理员角色不能删除');
68		}
69
70		$role->delete();
71
72		return response()->json(['message' => 'ok']);
73		}
74
75		/**
76		* 批量删除角色
77		*
78		* @param \Illuminate\Http\Request $request
79		*
80		* @return \Illuminate\Http\JsonResponse
81		*/
82		public function batchDestroy(Request $request)
83		{
84		if (!is_array($request->input('ids'))) {
85		throw new AdminHttpException('参数错误');
86		}
87
88		DB::transaction(function () use ($request) {
89		foreach ($request->input('ids') as $id) {
		0 ignored issues – show Bug introduced 2017-05-25 09:28 UTC by Report Bug Copy Issue Report The expression `$request->input('ids')` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
90		$role = Role::findOrFail($id);
91		if ($role->name == 'admin') {
92		throw new AdminHttpException('超级管理员角色不能删除');
93		}
94
95		$role->delete();
96		}
97		});
98
99		return response()->json(['message' => 'ok']);
100		}
101		}
102

ScoLib / admin

Push — master ( 80411a...1281a7 )

RoleController::destroy() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like