MultiSelect::getValue() - Code Metrics - Inspection of "form element" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f05a87...6b2b65 )

by wen

created 2017-09-13 09:40 UTC

MultiSelect::getValue() B

↳ Parent: MultiSelect

Complexity

Conditions	5
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	17
c	1
b	0
f	0
rs	8.8571
cc	5
eloc	10
nc	4
nop	0

<?php

namespace Sco\Admin\Form\Elements;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;

class MultiSelect extends Select
{
    protected $defaultValue = [];

    public function getValue()
    {
        $value = $this->getValueFromModel();
        if (empty($value)) {
            return $value;
        }

        if ($this->isOptionsModel() && $this->isRelation()) {
            $model = $this->getOptionsModel();
            $key = $this->getOptionsValueAttribute() ?: $model->getKeyName();

            $value = $value->pluck($key)->map(function ($item) {
                return (string)$item;
            });
        }
        return $value;
    }

    protected function isOptionsModel()
    {
        return is_string($this->options) || $this->options instanceof Model;
    }

    protected function isRelation()
    {
        return method_exists($this->getModel(), $this->getName());
    }

    public function save()
    {
        if (!($this->isOptionsModel() && $this->isRelation())) {
            parent::save();
        }
    }

    public function finishSave()
    {
        if (!($this->isOptionsModel() && $this->isRelation())) {
            return;
        }
        $attribute = $this->getName();

        $relation = $this->getModel()->{$attribute}();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function toArray()
    {
        return parent::toArray() + [
                'multiple' => true,
            ];
    }
}


1			<?php
2
3			namespace Sco\Admin\Form\Elements;
4
5			use Illuminate\Database\Eloquent\Model;
6			use Illuminate\Http\Request;
7
8			class MultiSelect extends Select
9			{
10			protected $defaultValue = [];
11
12			public function getValue()
13			{
14			$value = $this->getValueFromModel();
15			if (empty($value)) {
16			return $value;
17			}
18
19			if ($this->isOptionsModel() && $this->isRelation()) {
20			$model = $this->getOptionsModel();
21			$key = $this->getOptionsValueAttribute() ?: $model->getKeyName();
22
23			$value = $value->pluck($key)->map(function ($item) {
24			return (string)$item;
25			});
26			}
27			return $value;
28			}
29
30			protected function isOptionsModel()
31			{
32			return is_string($this->options) \|\| $this->options instanceof Model;
33			}
34
35			protected function isRelation()
36			{
37			return method_exists($this->getModel(), $this->getName());
38			}
39
40			public function save()
41			{
42			if (!($this->isOptionsModel() && $this->isRelation())) {
43			parent::save();
44			}
45			}
46
47			public function finishSave()
48			{
49			if (!($this->isOptionsModel() && $this->isRelation())) {
50			return;
51			}
52			$attribute = $this->getName();
53
54			$relation = $this->getModel()->{$attribute}();
			0 ignored issues – show Unused Code introduced 2017-09-13 09:54 UTC by Report Bug Copy Issue Report `$relation` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55			}
56
57			public function toArray()
58			{
59			return parent::toArray() + [
60			'multiple' => true,
61			];
62			}
63			}
64

ScoLib / admin

Push — master ( f05a87...6b2b65 )

MultiSelect::getValue() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like