Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | class Checkbox extends Select |
||
6 | { |
||
7 | protected $type = 'checkbox'; |
||
8 | |||
9 | protected $defaultValue = []; |
||
10 | |||
11 | protected $max; |
||
12 | protected $min = 0; |
||
13 | protected $showCheckAll = false; |
||
14 | |||
15 | public function getMax() |
||
19 | |||
20 | public function setMax($value) |
||
28 | |||
29 | public function getMin() |
||
33 | |||
34 | public function setMin($value) |
||
42 | |||
43 | public function isShowCheckAll() |
||
47 | |||
48 | public function enableShowCheckAll() |
||
54 | |||
55 | public function getValue() |
||
63 | |||
64 | protected function prepareValue($value) |
||
72 | |||
73 | View Code Duplication | public function toArray() |
|
81 | } |
||
82 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.