RoleController::save() - Code Metrics - Inspection of "fix vue auth" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5867cb...35a1b6 )

by wen

created 2017-05-10 09:50 UTC

RoleController::save() B

↳ Parent: RoleController

Complexity

Conditions	4
Paths	3

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	22
rs	8.9197
cc	4
eloc	13
nc	3
nop	1

<?php


namespace Sco\Admin\Http\Controllers\Manager;

use Auth;
use DB;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Admin\Http\Requests\RoleRequest;
use Sco\Admin\Models\Permission;
use Sco\Admin\Models\Role;

class RoleController extends Controller
{
    public function get($id)
    {
        return Role::with(['perms' => function ($query) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return $query->select('id');
        }])->findOrFail($id);
    }

    public function getList()
    {
        $roles = Role::with([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'perms' => function ($query) {
                $query->select('id');
            },
        ])->paginate();
        return response()->json($roles);
    }

    public function getAll()
    {
        $roles = Role::all();
        return response()->json($roles);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function getPermissionList()
    {
        $perms = (new Permission())->getPermRouteList();
        return response()->json($perms, 200, [], JSON_FORCE_OBJECT);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function save(RoleRequest $request)
    {
        if (empty($request->input('id'))) {
            $model = new Role();
        } else {
            $model = Role::findOrFail($request->input('id'));
            if ($model->id == 1 && $model->id != Auth::id()) {
                return response()->json(['error' => 'Unauthenticated.'], 401);
            }
        }


        $model->name         = $request->input('name');
        $model->display_name = $request->input('display_name');

        DB::transaction(function () use ($model, $request) {
            $model->save();
            $model->savePermissions($request->input('perms'));
        });

        return response()->json(['message' => 'ok']);
    }

    public function delete($id)

    {
        if ($id == 1) {
            throw new AdminHttpException('超级管理员角色不能删除');
        }

        $role = Role::findOrFail($id);
        $role->delete();

        return response()->json(['message' => 'ok']);
    }

    /**
     * 批量删除角色
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function batchDelete(Request $request)
    {
        if (!is_array($request->input('ids'))) {
            throw new AdminHttpException('参数错误');
        }

        DB::transaction(function () use ($request) {
            Role::destroy($request->input('ids'));
        });

        return response()->json(['message' => 'ok']);
    }
}


1		<?php
2
3
4		namespace Sco\Admin\Http\Controllers\Manager;
5
6		use Auth;
7		use DB;
8		use Illuminate\Http\Request;
9		use Illuminate\Routing\Controller;
10		use Sco\Admin\Exceptions\AdminHttpException;
11		use Sco\Admin\Http\Requests\RoleRequest;
12		use Sco\Admin\Models\Permission;
13		use Sco\Admin\Models\Role;
14
15		class RoleController extends Controller
16		{
17		public function get($id)
18		{
19		return Role::with(['perms' => function ($query) {
		0 ignored issues – show Bug introduced 2017-05-08 13:04 UTC by Report Bug Copy Issue Report The method `findOrFail` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
20		return $query->select('id');
21		}])->findOrFail($id);
22		}
23
24		public function getList()
25		{
26		$roles = Role::with([
		0 ignored issues – show Bug introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report The method `paginate` does only exist in `Illuminate\Database\Eloquent\Builder`, but not in `Illuminate\Database\Eloquent\Model`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		'perms' => function ($query) {
28		$query->select('id');
29		},
30		])->paginate();
31		return response()->json($roles);
32		}
33
34		public function getAll()
35		{
36		$roles = Role::all();
37		return response()->json($roles);
		0 ignored issues – show Bug introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report It seems like `$roles` defined by `\Sco\Admin\Models\Role::all()` on line `36` can also be of type `object<Illuminate\Database\Eloquent\Collection>`; however, `Illuminate\Contracts\Rou...ResponseFactory::json()` does only seem to accept `string\|array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
38		}
39
40		public function getPermissionList()
41		{
42		$perms = (new Permission())->getPermRouteList();
43		return response()->json($perms, 200, [], JSON_FORCE_OBJECT);
		0 ignored issues – show Documentation introduced 2017-05-08 02:24 UTC by Report Bug Copy Issue Report `$perms` is of type `object<Illuminate\Support\Collection>\|null`, but the function expects a `string\|array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44		}
45
46		public function save(RoleRequest $request)
47		{
48		if (empty($request->input('id'))) {
49		$model = new Role();
50		} else {
51		$model = Role::findOrFail($request->input('id'));
52		if ($model->id == 1 && $model->id != Auth::id()) {
53		return response()->json(['error' => 'Unauthenticated.'], 401);
54		}
55		}
56
57
58		$model->name = $request->input('name');
59		$model->display_name = $request->input('display_name');
60
61		DB::transaction(function () use ($model, $request) {
62		$model->save();
63		$model->savePermissions($request->input('perms'));
64		});
65
66		return response()->json(['message' => 'ok']);
67		}
68
69	View Code Duplication	public function delete($id)
		0 ignored issues – show Duplication introduced 2017-04-24 07:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		if ($id == 1) {
72		throw new AdminHttpException('超级管理员角色不能删除');
73		}
74
75		$role = Role::findOrFail($id);
76		$role->delete();
77
78		return response()->json(['message' => 'ok']);
79		}
80
81		/**
82		* 批量删除角色
83		*
84		* @param \Illuminate\Http\Request $request
85		*
86		* @return \Illuminate\Http\JsonResponse
87		*/
88		public function batchDelete(Request $request)
89		{
90		if (!is_array($request->input('ids'))) {
91		throw new AdminHttpException('参数错误');
92		}
93
94		DB::transaction(function () use ($request) {
95		Role::destroy($request->input('ids'));
96		});
97
98		return response()->json(['message' => 'ok']);
99		}
100		}
101

ScoLib / admin

Push — master ( 5867cb...35a1b6 )

RoleController::save() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like