Permission::clearCache() - Code Metrics - Inspection of "develop admin menu delete" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e5a61d...342745 )

by wen

created 2017-04-03 13:17 UTC

Permission::clearCache() A

↳ Parent: Permission

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Sco\Admin\Models;

use DB;
use Cache;
use Illuminate\Http\Request;
use Sco\Admin\Exceptions\AdminHttpException;
use Sco\Tree\Traits\TreeTrait;
use Zizaco\Entrust\EntrustPermission;

class Permission extends EntrustPermission
{
    use TreeTrait;

    protected $guarded = ['created_at', 'updated_at'];

    protected $treeNodeParentIdName = 'pid';

    private $allRoutes = null;

    private $validList = null;

    private $permList = null;

    private $menuList = null;


    /**
     * @return \Illuminate\Support\Collection
     */
    public function getMenuTreeList()
    {
        $routes = $this->getDescendants(0);
        //dd($routes);
        return $routes;
    }

    private function getAll()
    {
        if ($this->allRoutes) {
            return $this->allRoutes;
        }

        $this->allRoutes = Cache::rememberForever('permission_all',
            function () {
                return $this->orderBy('sort')->get();
            });
        return $this->allRoutes;
    }

    /**
     * Tree Trait 获取所有节点
     *
     * @return mixed|null
     */
    protected function getTreeAllNodes()
    {
        return $this->getAll();
    }

    /**
     * 获取有效的路由列表
     *
     * @return \Illuminate\Support\Collection
     */
    public function getValidRouteList()
    {
        if ($this->validList) {
            return $this->validList;
        }

        $all = $this->getAll();

        $this->validList = collect([]);
        foreach ($all as $route) {
            if (!empty($route->uri) && $route->uri != '#') {
                $this->validList->push($route);
            }
        }
        return $this->validList;
    }

    /**
     * 获取权限列表
     *
     * @return \Illuminate\Support\Collection|null
     */
    public function getPermRouteList()
    {
        if ($this->permList) {
            return $this->permList;
        }

        return $this->permList = $this->getLayerOfDescendants(0);
    }

    public function getMenuList()
    {
        if ($this->menuList) {
            return $this->menuList;
        }
        $all = $this->getAll();

        $routes = collect([]);
        foreach ($all as $route) {
            if ($route->is_menu) {
                $routes->push($route);
            }
        }

        $this->setAllNodes($routes);
        return $this->menuList = $this->getLayerOfDescendants(0);
    }

    public function getInfoById($id)
    {
        return $this->getSelf($id);
    }

    public function getInfoByName($name)
    {
        $all = $this->getAll();
        $key = $all->search(function ($item) use ($name) {
            return $item->name == $name;
        });
        return $key === false ? false : $all->get($key);
    }

    public function getParentTree($id)
    {
        return $this->getAncestors($id);
    }

    public function getParentTreeAndSelfById($id)

    {
        $self = $this->getInfoById($id);
        if ($self) {
            $parent = $this->getParentTree($self->id);
            $parent->push($self);
            return $parent;
        }
        return false;
    }

    public function getParentTreeAndSelfByName($name)

    {
        $self = $this->getInfoByName($name);
        if ($self) {
            $parent = $this->getParentTree($self->id);
            $parent->push($self);
            return $parent;
        }
        return false;
    }

    public function saveMenu(Request $request)
    {
        if ($request->exists('id')) {
            $model = $this->findOrFail($request->input('id'));

            $model->pid          = $request->input('pid');
            $model->display_name = $request->input('display_name');
            $model->name         = $request->input('name');
            $model->icon         = $request->input('icon');
            $model->is_menu      = $request->input('is_menu');
            $model->sort         = $request->input('sort');
            $model->description  = $request->input('description');

            $model->save();
        } else {
            $this->create($request->input());
        }

        $this->clearCache();
        return true;
    }

    public function deleteMenu($id)
    {
        $info = $this->getInfoById($id);
        if (is_null($info)) {
            throw new AdminHttpException(404, '菜单不存在');
        }

        $childs = $this->getDescendants($id)->keys();
        $childs->push($id);
        DB::transaction(function () use ($childs) {
            $this->destroy($childs->toArray());
        });

        $this->clearCache();

        return true;
    }

    private function clearCache()
    {
        Cache::forget('permission_all');
    }
}


1		<?php
2
3		namespace Sco\Admin\Models;
4
5		use DB;
6		use Cache;
7		use Illuminate\Http\Request;
8		use Sco\Admin\Exceptions\AdminHttpException;
9		use Sco\Tree\Traits\TreeTrait;
10		use Zizaco\Entrust\EntrustPermission;
11
12		class Permission extends EntrustPermission
13		{
14		use TreeTrait;
15
16		protected $guarded = ['created_at', 'updated_at'];
17
18		protected $treeNodeParentIdName = 'pid';
19
20		private $allRoutes = null;
21
22		private $validList = null;
23
24		private $permList = null;
25
26		private $menuList = null;
27
28
29		/**
30		* @return \Illuminate\Support\Collection
31		*/
32		public function getMenuTreeList()
33		{
34		$routes = $this->getDescendants(0);
35		//dd($routes);
36		return $routes;
37		}
38
39		private function getAll()
40		{
41		if ($this->allRoutes) {
42		return $this->allRoutes;
43		}
44
45		$this->allRoutes = Cache::rememberForever('permission_all',
46		function () {
47		return $this->orderBy('sort')->get();
48		});
49		return $this->allRoutes;
50		}
51
52		/**
53		* Tree Trait 获取所有节点
54		*
55		* @return mixed\|null
56		*/
57		protected function getTreeAllNodes()
58		{
59		return $this->getAll();
60		}
61
62		/**
63		* 获取有效的路由列表
64		*
65		* @return \Illuminate\Support\Collection
66		*/
67		public function getValidRouteList()
68		{
69		if ($this->validList) {
70		return $this->validList;
71		}
72
73		$all = $this->getAll();
74
75		$this->validList = collect([]);
76		foreach ($all as $route) {
77		if (!empty($route->uri) && $route->uri != '#') {
78		$this->validList->push($route);
79		}
80		}
81		return $this->validList;
82		}
83
84		/**
85		* 获取权限列表
86		*
87		* @return \Illuminate\Support\Collection\|null
88		*/
89		public function getPermRouteList()
90		{
91		if ($this->permList) {
92		return $this->permList;
93		}
94
95		return $this->permList = $this->getLayerOfDescendants(0);
96		}
97
98		public function getMenuList()
99		{
100		if ($this->menuList) {
101		return $this->menuList;
102		}
103		$all = $this->getAll();
104
105		$routes = collect([]);
106		foreach ($all as $route) {
107		if ($route->is_menu) {
108		$routes->push($route);
109		}
110		}
111
112		$this->setAllNodes($routes);
113		return $this->menuList = $this->getLayerOfDescendants(0);
114		}
115
116		public function getInfoById($id)
117		{
118		return $this->getSelf($id);
119		}
120
121		public function getInfoByName($name)
122		{
123		$all = $this->getAll();
124		$key = $all->search(function ($item) use ($name) {
125		return $item->name == $name;
126		});
127		return $key === false ? false : $all->get($key);
128		}
129
130		public function getParentTree($id)
131		{
132		return $this->getAncestors($id);
133		}
134
135	View Code Duplication	public function getParentTreeAndSelfById($id)
		0 ignored issues – show Duplication introduced 2017-02-27 13:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136		{
137		$self = $this->getInfoById($id);
138		if ($self) {
139		$parent = $this->getParentTree($self->id);
140		$parent->push($self);
141		return $parent;
142		}
143		return false;
144		}
145
146	View Code Duplication	public function getParentTreeAndSelfByName($name)
		0 ignored issues – show Duplication introduced 2017-02-27 13:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		$self = $this->getInfoByName($name);
149		if ($self) {
150		$parent = $this->getParentTree($self->id);
151		$parent->push($self);
152		return $parent;
153		}
154		return false;
155		}
156
157		public function saveMenu(Request $request)
158		{
159		if ($request->exists('id')) {
160		$model = $this->findOrFail($request->input('id'));
161
162		$model->pid = $request->input('pid');
163		$model->display_name = $request->input('display_name');
164		$model->name = $request->input('name');
165		$model->icon = $request->input('icon');
166		$model->is_menu = $request->input('is_menu');
167		$model->sort = $request->input('sort');
168		$model->description = $request->input('description');
169
170		$model->save();
171		} else {
172		$this->create($request->input());
173		}
174
175		$this->clearCache();
176		return true;
177		}
178
179		public function deleteMenu($id)
180		{
181		$info = $this->getInfoById($id);
182		if (is_null($info)) {
183		throw new AdminHttpException(404, '菜单不存在');
184		}
185
186		$childs = $this->getDescendants($id)->keys();
187		$childs->push($id);
188		DB::transaction(function () use ($childs) {
189		$this->destroy($childs->toArray());
190		});
191
192		$this->clearCache();
193
194		return true;
195		}
196
197		private function clearCache()
198		{
199		Cache::forget('permission_all');
200		}
201		}
202

ScoLib / admin

Push — master ( e5a61d...342745 )

Permission::clearCache() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like