MultiSelect::finishSave() - Code Metrics - Inspection of "form element" - ScoLib/admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 797ef7...545216 )

by wen

created 2017-12-08 09:57 UTC

MultiSelect::finishSave() A

↳ Parent: MultiSelect

Complexity

Conditions	4
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	13
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	13
loc	13
rs	9.2
cc	4
eloc	8
nc	3
nop	0

<?php

namespace Sco\Admin\Form\Elements;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Illuminate\Http\Request;

class MultiSelect extends Select
{
    protected $defaultValue = [];

    public function getValue()
    {
        $value = $this->getValueFromModel();
        if (empty($value)) {
            return $value;
        }

        if ($this->isOptionsModel() && $this->isRelation()) {
            $model = $this->getOptionsModel();
            $key = $this->getOptionsValueAttribute() ?: $model->getKeyName();

            $value = $value->pluck($key)->map(function ($item) {
                return (string)$item;
            });
        }
        return $value;
    }

    public function finishSave()

    {
        if (!($this->isOptionsModel() && $this->isRelation())) {
            return;
        }
        $attribute = $this->getName();
        $values = $this->getValueFromRequest();

        $relation = $this->getModel()->{$attribute}();
        if ($relation instanceof BelongsToMany) {
            $relation->sync($values);
        }
    }

    public function toArray()
    {
        return parent::toArray() + [
                'multiple' => true,
            ];
    }
}


1		<?php
2
3		namespace Sco\Admin\Form\Elements;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Illuminate\Database\Eloquent\Relations\BelongsToMany;
7		use Illuminate\Http\Request;
8
9		class MultiSelect extends Select
10		{
11		protected $defaultValue = [];
12
13		public function getValue()
14		{
15		$value = $this->getValueFromModel();
16		if (empty($value)) {
17		return $value;
18		}
19
20		if ($this->isOptionsModel() && $this->isRelation()) {
21		$model = $this->getOptionsModel();
22		$key = $this->getOptionsValueAttribute() ?: $model->getKeyName();
23
24		$value = $value->pluck($key)->map(function ($item) {
25		return (string)$item;
26		});
27		}
28		return $value;
29		}
30
31	View Code Duplication	public function finishSave()
		0 ignored issues – show Duplication introduced 2017-09-20 09:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		if (!($this->isOptionsModel() && $this->isRelation())) {
34		return;
35		}
36		$attribute = $this->getName();
37		$values = $this->getValueFromRequest();
38
39		$relation = $this->getModel()->{$attribute}();
40		if ($relation instanceof BelongsToMany) {
41		$relation->sync($values);
42		}
43		}
44
45		public function toArray()
46		{
47		return parent::toArray() + [
48		'multiple' => true,
49		];
50		}
51		}
52

ScoLib / admin

Push — master ( 797ef7...545216 )

MultiSelect::finishSave() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like