SchulIT / idp

src/Settings/AppSettings.php

<?php

namespace App\Settings;

class AppSettings extends AbstractSettings {
    public function getHelpdeskMail(): ?string {
        return $this->getValue('helpdesk.mail');
    }

    public function setHelpdeskInfo(?string $info): void {
        $this->setValue('helpdesk.info', $info);
    }

    public function isPasswordCompromisedCheckEnabled(): bool {
        return $this->getValue('security.password_compromised_check', true);

The expression return $this->getValue('security.password_compromised_check', true) could return the type null which is incompatible with the type-hinted return boolean. Consider adding an additional type-check to rule them out.

    }

    public function setPasswordCompromisedCheckEnabled(bool $enabled): void {
        $this->setValue('security.password_compromised_check', $enabled);
    }

}