SchulIT / idp

src/Security/Registration/RegistrationCodeManager.php

<?php

namespace App\Security\Registration;

use App\Entity\RegistrationCode;
use App\Entity\User;
use App\Repository\RegistrationCodeRepositoryInterface;
use App\Repository\UserRepositoryInterface;
use App\Repository\UserTypeRepositoryInterface;
use App\Security\EmailConfirmation\ConfirmationManager;
use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;

class RegistrationCodeManager {

    public function __construct(private RegistrationCodeRepositoryInterface $codeRepository, private UserRepositoryInterface $userRepository, private UserPasswordHasherInterface $passwordHasher, private UserTypeRepositoryInterface $typeRepository, private ConfirmationManager $confirmationManager)
    {
    }

    public function getTemplateUser(): User {
        $type = $this->typeRepository->findOneByAlias('parent');
        $user = new User();
        $user->setType($type);

It seems like $type can also be of type null; however, parameter $userType of App\Entity\User::setType() does only seem to accept App\Entity\UserType, maybe add an additional type check?

        return $user;
    }

    public function isRedeemed(RegistrationCode $code): bool {
        return $code->getRedeemingUser() !== null;
    }

    /**
     * @throws CodeAlreadyRedeemedException
     */
    public function complete(RegistrationCode $code, User $user, string $password): void {
        if($this->isRedeemed($code)) {
            throw new CodeAlreadyRedeemedException();
        }

        $type = $this->typeRepository->findOneByAlias('parent');
        $user
            ->setType($type)

It seems like $type can also be of type null; however, parameter $userType of App\Entity\User::setType() does only seem to accept App\Entity\UserType, maybe add an additional type check?

            ->setIsEmailConfirmationPending($user->getEmail() !== null)
            ->setPassword($this->passwordHasher->hashPassword($user, $password));

        $user->addLinkedStudent($code->getStudent());

It seems like $code->getStudent() can also be of type null; however, parameter $user of App\Entity\User::addLinkedStudent() does only seem to accept App\Entity\User, maybe add an additional type check?

        $code->setRedeemingUser($user);

        $this->userRepository->persist($user);
        $this->codeRepository->persist($code);

        if($user->getEmail() !== null) {
            $this->confirmationManager->newConfirmation($user, $user->getEmail());
            $user->setIsEmailConfirmationPending(true);
            $user->setEmail(null);

            $this->userRepository->persist($user);
        }
    }
}