LinkStudentsHelper::getLinks() - Code Metrics - Inspection of "Fixes CI" - SchulIT/idp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5b6d3c...e19d53 )

by Marcel

created 2020-06-29 22:18 UTC

LinkStudentsHelper::getLinks() A

↳ Parent: LinkStudentsHelper

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0175

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	7
c	1
b	0
f	0
nc	3
nop	1
dl	0
loc	13
ccs	7
cts	8
cp	0.875
crap	3.0175
rs	10

<?php

namespace App\Link;

use App\Entity\User;
use App\Repository\UserRepositoryInterface;

class LinkStudentsHelper {

    public const StudentEduPerson = 'student';

    private $repository;

    public function __construct(UserRepositoryInterface $userRepository) {
        $this->repository = $userRepository;
    }

    /**
     * Establishes a link between the current user and a student user
     *
     * @param User $currentUser
     * @param User $student
     * @throws NotAStudentException
     */
    public function link(User $currentUser, User $student) {
        $studentEduPerson = $student->getType()->getEduPerson();

        if(!in_array(static::StudentEduPerson, $studentEduPerson)) {
            throw new NotAStudentException();
        }

        $ids = explode(',', $currentUser->getExternalId());
        $ids[] = $student->getExternalId();
        $currentUser->setExternalId(implode(',', $ids));

        $this->repository->persist($currentUser);
    }

    /**
     * Returns all linked student users
     *
     * @param User $user
     * @return User[]
     */
    public function getLinks(User $user): array {
        $ids = explode(',', $user->getExternalId());
        $users = [ ];

        foreach($ids as $id) {
            $user = $this->repository->findOneByExternalId($id);

            if($user !== null) {
                $users[] = $user;
            }
        }

        return $users;
    }
}

1		<?php
2
3		namespace App\Link;
4
5		use App\Entity\User;
6		use App\Repository\UserRepositoryInterface;
7
8		class LinkStudentsHelper {
9
10		public const StudentEduPerson = 'student';
11
12		private $repository;
13
14	2	public function __construct(UserRepositoryInterface $userRepository) {
15	2	$this->repository = $userRepository;
16	2	}
17
18		/**
19		* Establishes a link between the current user and a student user
20		*
21		* @param User $currentUser
22		* @param User $student
23		* @throws NotAStudentException
24		*/
25		public function link(User $currentUser, User $student) {
26		$studentEduPerson = $student->getType()->getEduPerson();
27
28		if(!in_array(static::StudentEduPerson, $studentEduPerson)) {
29		throw new NotAStudentException();
30		}
31
32		$ids = explode(',', $currentUser->getExternalId());
33		$ids[] = $student->getExternalId();
34		$currentUser->setExternalId(implode(',', $ids));
35
36		$this->repository->persist($currentUser);
37		}
38
39		/**
40		* Returns all linked student users
41		*
42		* @param User $user
43		* @return User[]
44		*/
45	2	public function getLinks(User $user): array {
46	2	$ids = explode(',', $user->getExternalId());
47	2	$users = [ ];
48
49	2	foreach($ids as $id) {
50	2	$user = $this->repository->findOneByExternalId($id);
51
52	2	if($user !== null) {
53		$users[] = $user;
54		}
55		}
56
57	2	return $users;
58		}
59		}

SchulIT / idp

Push — master ( 5b6d3c...e19d53 )

LinkStudentsHelper::getLinks() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like