AttributePersister::persist() - Code Metrics - Inspection of "Check current password before changing it (closes..." - SchulIT/idp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f92548...5447f3 )

by Marcel

created 2020-07-20 22:41 UTC

AttributePersister::persist() C

↳ Parent: AttributePersister

Complexity

Conditions	12
Paths	40

Size

Total Lines	39
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	156

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	12
eloc	22
c	1
b	0
f	0
nc	40
nop	3
dl	0
loc	39
ccs	0
cts	23
cp	0
crap	156
rs	6.9666

How to fix Complexity

<?php

namespace App\Service;

use App\Entity\ServiceAttribute;
use App\Entity\ServiceAttributeRegistrationCodeValue;
use App\Entity\ServiceAttributeUserRoleValue;
use App\Entity\ServiceAttributeUserTypeValue;
use App\Entity\ServiceAttributeValue;
use App\Entity\User;
use App\Entity\RegistrationCode;
use App\Entity\UserRole;
use App\Entity\UserType;
use App\Repository\ServiceAttributeRepositoryInterface;
use App\Repository\ServiceAttributeValueRepositoryInterface;
use App\Repository\TransactionalRepositoryInterface;
use App\Traits\ArrayTrait;

/**
 * Helper which persists attributes of a user in the database.
 */
class AttributePersister {
    use ArrayTrait;

    private $attributeRepository;
    private $attributeValueRepository;

    public function __construct(ServiceAttributeRepositoryInterface $attributeRepository, ServiceAttributeValueRepositoryInterface $attributeValueRepository) {
        $this->attributeRepository = $attributeRepository;
        $this->attributeValueRepository = $attributeValueRepository;
    }

    public function persist(array $values, array $currentAttributes, \Closure $factory) {
        /** @var ServiceAttribute[] $attributes */
        $attributes = $this->makeArrayWithKeys(
            $this->attributeRepository->findAll(),
            function(ServiceAttribute $attribute) {
                return $attribute->getName();
            }
        );

        if($this->attributeValueRepository instanceof TransactionalRepositoryInterface) {
            $this->attributeValueRepository->beginTransaction();
                                             beginTransaction();
        }

        foreach($values as $name => $value) {
            if(!array_key_exists($name, $attributes)) {
                continue; // TODO: maybe throw Exception here?!
            }

            $currentAttributeValue = null;

            if (array_key_exists($name, $currentAttributes)) {
                $currentAttributeValue = $currentAttributes[$name];
            }

            if($currentAttributeValue !== null && ($value === null || empty($value))) {
                $this->attributeValueRepository->remove($currentAttributeValue);
            } elseif ($value !== null && !empty($value)) {
                if($currentAttributeValue === null) {
                    $currentAttributeValue = $factory();
                    $currentAttributeValue->setAttribute($attributes[$name]);
                }

                $currentAttributeValue->setValue($value);
                $this->attributeValueRepository->persist($currentAttributeValue);
            }
        }

        if($this->attributeValueRepository instanceof TransactionalRepositoryInterface) {
            $this->attributeValueRepository->commit();
                                             commit();
        }
    }

    public function persistUserAttributes(array $values, User $user) {
        $factory = function() use ($user) {
            $value = (new ServiceAttributeValue())
                ->setUser($user);
            $user->getAttributes()->add($value);

            return $value;
        };

        /** @var ServiceAttributeValue[] $currentUserAttributes */
        $currentUserAttributes = $this->makeArrayWithKeys(
            $user->getAttributes()->toArray(),
            function(ServiceAttributeValue $attributeValue) {
                return $attributeValue->getAttribute()->getName();
            }
        );

        $this->persist($values, $currentUserAttributes, $factory);
    }

    public function persistUserRoleAttributes(array $values, UserRole $userRole) {
        $factory = function() use ($userRole) {
            $value = (new ServiceAttributeUserRoleValue())
                ->setUserRole($userRole);
            $userRole->getAttributes()->add($value);

            return $value;
        };

        /** @var ServiceAttributeUserRoleValue[] $currentUserAttributes */
        $currentUserAttributes = $this->makeArrayWithKeys(
            $userRole->getAttributes()->toArray(),
            function(ServiceAttributeUserRoleValue $attributeValue) {
                return $attributeValue->getAttribute()->getName();
            }
        );

        $this->persist($values, $currentUserAttributes, $factory);
    }

    public function persistUserTypeAttributes(array $values, UserType $userType) {
        $factory = function() use ($userType) {
            $value = (new ServiceAttributeUserTypeValue())
                ->setUserType($userType);
            $userType->getAttributes()->add($value);

            return $value;
        };

        /** @var ServiceAttributeUserRoleValue[] $currentUserAttributes */
        $currentUserAttributes = $this->makeArrayWithKeys(
            $userType->getAttributes()->toArray(),
            function(ServiceAttributeUserTypeValue $attributeValue) {
                return $attributeValue->getAttribute()->getName();
            }
        );

        $this->persist($values, $currentUserAttributes, $factory);
    }

    public function persistRegistrationCodeAttributes(array $values, RegistrationCode $code) {
        $factory = function() use ($code) {
            $value = (new ServiceAttributeRegistrationCodeValue())
                ->setRegistrationCode($code);
            $code->getAttributes()->add($value);

            return $value;
        };

        $currentRegistrationCodeAttributes = $this->makeArrayWithKeys(
            $code->getAttributes()->toArray(),
            function(ServiceAttributeRegistrationCodeValue $attributeValue) {
                return $attributeValue->getAttribute()->getName();
            }
        );

        $this->persist($values, $currentRegistrationCodeAttributes, $factory);
    }
}

SchulIT / idp

Push — master ( f92548...5447f3 )

AttributePersister::persist() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like