SchulIT / icc

src/Grouping/TeacherFirstCharacterStrategy.php

<?php

namespace App\Grouping;

use App\Entity\Teacher;

class TeacherFirstCharacterStrategy implements GroupingStrategyInterface {

    /**
     * @param Teacher $object
     * @return string
     */
    public function computeKey($object, array $options = [ ]) {
        return ucfirst(substr($object->getAcronym(), 0, 1));

It seems like $object->getAcronym() can also be of type null; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * @param string $keyA
     * @param string $keyB
     */
    public function areEqualKeys($keyA, $keyB, array $options = [ ]): bool {
        return $keyA === $keyB;
    }

    /**
     * @param string $key
     */
    public function createGroup($key, array $options = [ ]): GroupInterface {
        return new TeacherFirstCharacterGroup($key);
    }
}