SchulIT / icc

src/Converter/StudyGroupsGradeStringConverter.php

<?php

namespace App\Converter;

use App\Entity\Grade;
use App\Entity\StudyGroup;
use App\Entity\StudyGroupType;
use App\Sorting\Sorter;
use App\Sorting\StudyGroupStrategy;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Symfony\Contracts\Translation\TranslatorInterface;

class StudyGroupsGradeStringConverter {

    public function __construct(private TranslatorInterface $translator, private Sorter $sorter, private GradesCollapsedArrayConverter $gradeConverter)
    {
    }

    /**
     * @param StudyGroup[]|iterable $studyGroups
     * @param Grade[]|iterable $onlyGrades
     */
    public function convert(iterable $studyGroups, bool $sort = false, iterable $onlyGrades = [ ]): string {
        if($studyGroups instanceof Collection) {
            $studyGroups = $studyGroups->toArray();
        }

        if($onlyGrades instanceof Collection) {
            $onlyGrades = $onlyGrades->toArray();
        }

        /** @var int[] $onlyGrades */
        $onlyGrades = array_map(fn(Grade $grade) => $grade->getId(), $onlyGrades);

        if($sort === true) {
            $this->sorter->sort($studyGroups, StudyGroupStrategy::class);

It seems like $studyGroups can also be of type iterable; however, parameter $array of App\Sorting\Sorter::sort() does only seem to accept array, maybe add an additional type check?

        }

        $output = [ ];

The assignment to $output is dead and can be removed.

        // First: Grades
        $grades = array_filter($studyGroups, fn(StudyGroup $group) => $group->getType() === StudyGroupType::Grade);

It seems like $studyGroups can also be of type iterable; however, parameter $array of array_filter() does only seem to accept array, maybe add an additional type check?

        $output = $this->gradeConverter->convert(
            array_map(fn(StudyGroup $group) => $group->getGrades()->first(), $grades)
        );

        // Second: Individual groups
        $studyGroups = array_filter($studyGroups, fn(StudyGroup $group) => $group->getType() !== StudyGroupType::Grade);

        $output += array_map(fn(StudyGroup $studyGroup) => $this->translator->trans('studygroup.string', [
            '%name%' => $studyGroup->getName(),
            '%grade%' => implode(', ', $this->gradeConverter->convert($studyGroup->getGrades()->filter(function(Grade $grade) use($onlyGrades) {
                if(empty($onlyGrades)) {
                    return true;
                }

                return in_array($grade->getId(), $onlyGrades);
            })->toArray()))
        ]), $studyGroups);

        return implode(', ', $output);
    }
}