App\Repository\TeacherAbsenceLessonRepository

Complexity

Total Complexity

1

Size/Duplication

Total Lines	12
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	findOneForLesson()	0	10	1

<?php

namespace App\Repository;

use App\Entity\TeacherAbsenceLesson;
use App\Entity\TimetableLesson;

class TeacherAbsenceLessonRepository extends AbstractRepository implements TeacherAbsenceLessonRepositoryInterface {

    public function findOneForLesson(TimetableLesson $lesson): ?TeacherAbsenceLesson {
        return $this->em->createQueryBuilder()

The expression return $this->em->createQueryBuilder()->select('al')->from(App\Entity\TeacherAbsenceLesson::class, 'al')->leftJoin('al.lesson', 'l')->where('l.id = :lesson')->setParameter('lesson', $lesson->getId())->setMaxResults(1)->getQuery()->getOneOrNullResult() could return the type integer which is incompatible with the type-hinted return App\Entity\TeacherAbsenceLesson|null. Consider adding an additional type-check to rule them out.

            ->select('al')
            ->from(TeacherAbsenceLesson::class, 'al')
            ->leftJoin('al.lesson', 'l')
            ->where('l.id = :lesson')
            ->setParameter('lesson', $lesson->getId())
            ->setMaxResults(1)
            ->getQuery()
            ->getOneOrNullResult();
    }
}