UserChecker::onAuthenticationSuccess() - Code Metrics - Inspection of "Teacher is not required" - SchulIT/icc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 58b7d4...bb40b7 )

by Marcel

created 2023-01-12 18:37 UTC

UserChecker::onAuthenticationSuccess() B

↳ Parent: UserChecker

Complexity

Conditions	9
Paths	10

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	11
c	1
b	0
f	0
dl	0
loc	21
rs	8.0555
ccs	11
cts	11
cp	1
cc	9
nc	10
nop	1
crap	9

<?php

namespace App\Security;

use App\Entity\IcsAccessToken;
use App\Entity\User;
use App\Entity\UserType;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Security\Core\Event\AuthenticationSuccessEvent;
use Symfony\Component\Security\Core\Exception\AccountStatusException;
use Symfony\Component\Security\Core\User\UserCheckerInterface;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * Checks whether the user meets certain critiera or sends
 * an error page:
 *
 * - students must have exactly one associated student
 * - parents must have at least one associated student
 * - teachers must have one associated teacher
 */
class UserChecker implements UserCheckerInterface {

    public function checkPreAuth(UserInterface $user) {
        
    }

    public function checkPostAuth(UserInterface $user) {
        if($user instanceof IcsAccessToken) {
            $user = $user->getUser();
        }

        if(!$user instanceof User) {
            return;
        }

        if($user->isTeacher() && $user->getTeacher() === null) {
            throw new InvalidAccountException('invalid_account.teacher');
        }

        if($user->isStudent() && $user->getStudents()->count() !== 1) {
            throw new InvalidAccountException('invalid_account.student');
        }

        if($user->isParent() && $user->getStudents()->count() === 0) {
            throw new InvalidAccountException('invalid_account.parent');
        }
    }
}

1		<?php
2
3		namespace App\Security;
4
5		use App\Entity\IcsAccessToken;
6		use App\Entity\User;
7		use App\Entity\UserType;
8		use Symfony\Component\EventDispatcher\EventSubscriberInterface;
9		use Symfony\Component\Security\Core\Event\AuthenticationSuccessEvent;
10		use Symfony\Component\Security\Core\Exception\AccountStatusException;
11		use Symfony\Component\Security\Core\User\UserCheckerInterface;
12		use Symfony\Component\Security\Core\User\UserInterface;
13
14		/**
15		* Checks whether the user meets certain critiera or sends
16		* an error page:
17		*
18		* - students must have exactly one associated student
19		* - parents must have at least one associated student
20		* - teachers must have one associated teacher
21		*/
22		class UserChecker implements UserCheckerInterface {
23
24	10	public function checkPreAuth(UserInterface $user) {
25	10
26		}
27	10
28	3	public function checkPostAuth(UserInterface $user) {
29		if($user instanceof IcsAccessToken) {
30		$user = $user->getUser();
31	7	}
32	1
33		if(!$user instanceof User) {
34		return;
35	6	}
36	2
37		if($user->isTeacher() && $user->getTeacher() === null) {
38		throw new InvalidAccountException('invalid_account.teacher');
39	4	}
40	1
41		if($user->isStudent() && $user->getStudents()->count() !== 1) {
42	3	throw new InvalidAccountException('invalid_account.student');
43		}
44
45		if($user->isParent() && $user->getStudents()->count() === 0) {
46		throw new InvalidAccountException('invalid_account.parent');
47		}
48		}
49		}

SchulIT / icc

Push — master ( 58b7d4...bb40b7 )

UserChecker::onAuthenticationSuccess() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like